Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

code improvements

Pedro Ladeiraf12bc2ce98d9
diff --git a/apps/web/lib/fetchers/get-program.ts b/apps/web/lib/fetchers/get-program.ts
index 7f5ef47e31..ad26b39f79 100644
--- a/apps/web/lib/fetchers/get-program.ts
+++ b/apps/web/lib/fetchers/get-program.ts
@@ -9,6 +9,23 @@ type Result = Program & {
groups: GroupWithFormDataProps[];
};
+// Partner pages serialize this loader to the client. Screening config stays on
+// the workspace program API.
+export function omitInternalProgramFields<
+ T extends {
+ applicationScreeningCriteria?: string | null;
+ aiAutoApproveEnabledAt?: Date | null;
+ },
+>(program: T) {
+ const {
+ applicationScreeningCriteria: _applicationScreeningCriteria,
+ aiAutoApproveEnabledAt: _aiAutoApproveEnabledAt,
+ ...publicProgram
+ } = program;
+
+ return publicProgram;
+}
+
export const getProgram = cache(
async ({ slug, groupSlug }: { slug: string; groupSlug?: string }) => {
const programData = await prisma.program.findUnique({
@@ -40,7 +57,7 @@ export const getProgram = cache(
// If no group slug is provided, return the program data with no rewards or discount
if (!groupSlug) {
return {
- ...programData,
+ ...omitInternalProgramFields(programData),
group: null,
rewards: [],
discount: null,
@@ -74,7 +91,7 @@ export const getProgram = cache(
const discount = group.discount;
return {
- ...program,
+ ...omitInternalProgramFields(program),
group: {
...group,
bounties,
diff --git a/apps/web/tests/partners/program-config-exposure.test.ts b/apps/web/tests/partners/program-config-exposure.test.ts
index d52a7fa9db..ba8c722464 100644
--- a/apps/web/tests/partners/program-config-exposure.test.ts
+++ b/apps/web/tests/partners/program-config-exposure.test.ts
@@ -1,9 +1,12 @@
+import { omitInternalProgramFields } from "@/lib/fetchers/get-program";
import {
ProgramEnrollmentSchema,
ProgramSchema,
ProgramSchemaWithInviteEmailData,
} from "@/lib/zod/schemas/programs";
-import { describe, expect, it } from "vitest";
+import { describe, expect, it, vi } from "vitest";
+
+vi.mock("server-only", () => ({}));
const programRow = {
id: "prog_1",
@@ -52,6 +55,29 @@ describe("program config exposure", () => {
expect(parsed).not.toHaveProperty("aiAutoApproveEnabledAt");
});
+ it("is stripped from the public program loader", () => {
+ const publicProgram = omitInternalProgramFields(programRow);
+
+ expect(publicProgram).not.toHaveProperty("applicationScreeningCriteria");
+ expect(publicProgram).not.toHaveProperty("aiAutoApproveEnabledAt");
+ expect(publicProgram).toEqual({
+ id: programRow.id,
+ name: programRow.name,
+ slug: programRow.slug,
+ logo: programRow.logo,
+ domain: programRow.domain,
+ url: programRow.url,
+ description: programRow.description,
+ primaryRewardEvent: programRow.primaryRewardEvent,
+ minPayoutAmount: programRow.minPayoutAmount,
+ payoutMode: programRow.payoutMode,
+ defaultFolderId: programRow.defaultFolderId,
+ defaultGroupId: programRow.defaultGroupId,
+ createdAt: programRow.createdAt,
+ updatedAt: programRow.updatedAt,
+ });
+ });
+
it("is kept on the workspace-scoped program payload", () => {
const parsed = ProgramSchemaWithInviteEmailData.parse({
...programRow,