Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

test(workflow): decrease the number of track leads for better performance

Pedro Ladeiraf147a1ef743c
diff --git a/apps/web/tests/workflows/award-bounty-workflow.test.ts b/apps/web/tests/workflows/award-bounty-workflow.test.ts
index b34f78d9cc..9d3d4cca20 100644
--- a/apps/web/tests/workflows/award-bounty-workflow.test.ts
+++ b/apps/web/tests/workflows/award-bounty-workflow.test.ts
@@ -45,12 +45,12 @@ describe.sequential("Workflow - AwardBounty", async () => {
const h = new IntegrationHarness();
const { http } = await h.init();
- test("Workflow executes when partner reaches goal", async () => {
+ test("Workflow executes when partner reaches goal", { timeout: 90000 }, async () => {
const { status: bountyStatus, data: bounty } = await http.post<Bounty>({
path: "/bounties",
body: {
name: "E2E Performance Bounty - Goal Reached",
- description: "Get 10 leads to earn $10",
+ description: "Get 2 leads to earn $10",
type: "performance",
startsAt: new Date().toISOString(),
endsAt: null,
@@ -60,7 +60,7 @@ describe.sequential("Workflow - AwardBounty", async () => {
performanceCondition: {
attribute: "totalLeads",
operator: "gte",
- value: 10,
+ value: 2,
},
},
});
@@ -87,17 +87,17 @@ describe.sequential("Workflow - AwardBounty", async () => {
const partnerLink = partner.links![0];
- await trackLeads(http, partnerLink, 11);
+ await trackLeads(http, partnerLink, 3);
const submission = await verifyBountySubmission({
bountyId: bounty.id,
partnerId: partner.id,
expectedStatus: "submitted",
- minPerformanceCount: 10,
+ minPerformanceCount: 2,
});
expect(submission.status).toBe("submitted");
- expect(submission.performanceCount).toBeGreaterThanOrEqual(10);
+ expect(submission.performanceCount).toBeGreaterThanOrEqual(2);
expect(submission.completedAt).not.toBeNull();
});
@@ -106,7 +106,7 @@ describe.sequential("Workflow - AwardBounty", async () => {
path: "/bounties",
body: {
name: "E2E Performance Bounty - Not Reached",
- description: "Get 10 leads to earn $10",
+ description: "Get 2 leads to earn $10",
type: "performance",
startsAt: new Date().toISOString(),
endsAt: null,
@@ -116,7 +116,7 @@ describe.sequential("Workflow - AwardBounty", async () => {
performanceCondition: {
attribute: "totalLeads",
operator: "gte",
- value: 10,
+ value: 2,
},
},
});
@@ -142,7 +142,7 @@ describe.sequential("Workflow - AwardBounty", async () => {
const partnerLink = partner.links![0];
- await trackLeads(http, partnerLink, 5);
+ await trackLeads(http, partnerLink, 1);
await new Promise((resolve) => setTimeout(resolve, 10000));
@@ -155,7 +155,7 @@ describe.sequential("Workflow - AwardBounty", async () => {
expect(submission).not.toBeNull();
expect(submission?.status).toBe("draft");
- expect(submission?.performanceCount).toBe(5);
+ expect(submission?.performanceCount).toBe(1);
expect(submission?.completedAt).toBeNull();
});
@@ -164,7 +164,7 @@ describe.sequential("Workflow - AwardBounty", async () => {
path: "/bounties",
body: {
name: "E2E Performance Bounty - Disabled",
- description: "Get 10 leads to earn $10",
+ description: "Get 2 leads to earn $10",
type: "performance",
startsAt: new Date().toISOString(),
endsAt: null,
@@ -174,7 +174,7 @@ describe.sequential("Workflow - AwardBounty", async () => {
performanceCondition: {
attribute: "totalLeads",
operator: "gte",
- value: 10,
+ value: 2,
},
},
});
@@ -211,7 +211,7 @@ describe.sequential("Workflow - AwardBounty", async () => {
const partnerLink = partner.links![0];
- await trackLeads(http, partnerLink, 11);
+ await trackLeads(http, partnerLink, 3);
await new Promise((resolve) => setTimeout(resolve, 10000));
@@ -225,12 +225,12 @@ describe.sequential("Workflow - AwardBounty", async () => {
expect(submission).toBeNull();
});
- test("No duplicate execution on multiple triggers", async () => {
+ test("No duplicate execution on multiple triggers", { timeout: 90000 }, async () => {
const { status: bountyStatus, data: bounty } = await http.post<Bounty>({
path: "/bounties",
body: {
name: "E2E Performance Bounty - No Duplicates",
- description: "Get 10 leads to earn $10",
+ description: "Get 2 leads to earn $10",
type: "performance",
startsAt: new Date().toISOString(),
endsAt: null,
@@ -240,7 +240,7 @@ describe.sequential("Workflow - AwardBounty", async () => {
performanceCondition: {
attribute: "totalLeads",
operator: "gte",
- value: 10,
+ value: 2,
},
},
});
@@ -266,13 +266,13 @@ describe.sequential("Workflow - AwardBounty", async () => {
const partnerLink = partner.links![0];
- await trackLeads(http, partnerLink, 15);
+ await trackLeads(http, partnerLink, 5);
await verifyBountySubmission({
bountyId: bounty.id,
partnerId: partner.id,
expectedStatus: "submitted",
- minPerformanceCount: 10,
+ minPerformanceCount: 2,
});
const submissions = await prisma.bountySubmission.findMany({
diff --git a/apps/web/tests/workflows/move-group-workflow.test.ts b/apps/web/tests/workflows/move-group-workflow.test.ts
index 015cafcbc6..5a80d7a340 100644
--- a/apps/web/tests/workflows/move-group-workflow.test.ts
+++ b/apps/web/tests/workflows/move-group-workflow.test.ts
@@ -242,7 +242,7 @@ describe.sequential("Workflow - MoveGroup", async () => {
{
attribute: "totalLeads",
operator: "gte",
- value: 10,
+ value: 2,
},
],
},
@@ -285,7 +285,7 @@ describe.sequential("Workflow - MoveGroup", async () => {
const partnerLink = partner.links![0];
- await trackLeads(http, partnerLink, 11);
+ await trackLeads(http, partnerLink, 3);
await verifyPartnerGroupMove({
partnerId: partner.id,
diff --git a/apps/web/tests/workflows/utils/verify-bounty-submission.ts b/apps/web/tests/workflows/utils/verify-bounty-submission.ts
index e2c04649ef..1a1e6e5553 100644
--- a/apps/web/tests/workflows/utils/verify-bounty-submission.ts
+++ b/apps/web/tests/workflows/utils/verify-bounty-submission.ts
@@ -9,7 +9,7 @@ interface VerifyBountySubmissionProps {
}
const POLL_INTERVAL_MS = 5000; // 5 seconds
-const TIMEOUT_MS = 30000; // 30 seconds
+const TIMEOUT_MS = 60000; // 60 seconds
export const verifyBountySubmission = async ({
bountyId,
@@ -19,6 +19,8 @@ export const verifyBountySubmission = async ({
}: VerifyBountySubmissionProps) => {
const startTime = Date.now();
+ let lastSubmission: any = null;
+
while (Date.now() - startTime < TIMEOUT_MS) {
const submission = await prisma.bountySubmission.findFirst({
where: {
@@ -27,7 +29,14 @@ export const verifyBountySubmission = async ({
},
});
- if (submission) {
+ lastSubmission = submission;
+
+ if (
+ submission &&
+ submission.status === expectedStatus &&
+ (minPerformanceCount === undefined ||
+ (submission.performanceCount ?? 0) >= minPerformanceCount)
+ ) {
expect(submission.status).toBe(expectedStatus);
if (minPerformanceCount !== undefined) {
@@ -46,8 +55,12 @@ export const verifyBountySubmission = async ({
await new Promise((resolve) => setTimeout(resolve, POLL_INTERVAL_MS));
}
+ const lastState = lastSubmission
+ ? `Last seen: status="${lastSubmission.status}", performanceCount=${lastSubmission.performanceCount}`
+ : "No submission found";
+
throw new Error(
- `Bounty submission not found within ${TIMEOUT_MS / 1000} seconds. ` +
- `bountyId: ${bountyId}, partnerId: ${partnerId}`,
+ `Bounty submission did not reach status "${expectedStatus}" within ${TIMEOUT_MS / 1000} seconds. ` +
+ `bountyId: ${bountyId}, partnerId: ${partnerId}. ${lastState}`,
);
};
diff --git a/apps/web/tests/workflows/utils/verify-campaign-sent.ts b/apps/web/tests/workflows/utils/verify-campaign-sent.ts
index 2daefb30f4..3e9854625d 100644
--- a/apps/web/tests/workflows/utils/verify-campaign-sent.ts
+++ b/apps/web/tests/workflows/utils/verify-campaign-sent.ts
@@ -7,7 +7,7 @@ interface VerifyCampaignSentProps {
}
const POLL_INTERVAL_MS = 5000; // 5 seconds
-const TIMEOUT_MS = 30000; // 30 seconds
+const TIMEOUT_MS = 60000; // 60 seconds
export const verifyCampaignSent = async ({
campaignId,
diff --git a/apps/web/tests/workflows/utils/verify-partner-group-move.ts b/apps/web/tests/workflows/utils/verify-partner-group-move.ts
index d17e87ddce..47c15535bf 100644
--- a/apps/web/tests/workflows/utils/verify-partner-group-move.ts
+++ b/apps/web/tests/workflows/utils/verify-partner-group-move.ts
@@ -8,7 +8,7 @@ interface VerifyPartnerGroupMoveProps {
}
const POLL_INTERVAL_MS = 5000; // 5 seconds
-const TIMEOUT_MS = 30000; // 30 seconds
+const TIMEOUT_MS = 60000; // 60 seconds
export const verifyPartnerGroupMove = async ({
partnerId,
@@ -16,6 +16,7 @@ export const verifyPartnerGroupMove = async ({
expectedGroupId,
}: VerifyPartnerGroupMoveProps) => {
const startTime = Date.now();
+ let lastGroupId: string | null = null;
while (Date.now() - startTime < TIMEOUT_MS) {
const enrollment = await prisma.programEnrollment.findUnique({
@@ -34,6 +35,8 @@ export const verifyPartnerGroupMove = async ({
},
});
+ lastGroupId = enrollment?.groupId ?? null;
+
if (enrollment?.groupId === expectedGroupId) {
expect(enrollment.groupId).toBe(expectedGroupId);
return enrollment;
@@ -44,6 +47,7 @@ export const verifyPartnerGroupMove = async ({
throw new Error(
`Partner group move not found within ${TIMEOUT_MS / 1000} seconds. ` +
- `partnerId: ${partnerId}, expectedGroupId: ${expectedGroupId}`,
+ `partnerId: ${partnerId}, expectedGroupId: ${expectedGroupId}. ` +
+ `Last seen groupId: ${lastGroupId}`,
);
};