Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Validate PayPal webhook cert URL against host allowlist (#3835)

Kiran Kf369fb6f6252
diff --git a/apps/web/app/(ee)/api/paypal/webhook/verify-signature.ts b/apps/web/app/(ee)/api/paypal/webhook/verify-signature.ts
index 5ce01d30fa..65b1b2f6e8 100644
--- a/apps/web/app/(ee)/api/paypal/webhook/verify-signature.ts
+++ b/apps/web/app/(ee)/api/paypal/webhook/verify-signature.ts
@@ -7,6 +7,26 @@ import crypto from "crypto";
const CERT_CACHE_KEY_PREFIX = "paypal:cert:";
const CERT_CACHE_TTL_SECONDS = 60 * 60 * 24 * 7; // 7 days
+const PAYPAL_CERT_HOST_ALLOWLIST = new Set([
+ "api.paypal.com",
+ "api-m.paypal.com",
+ "api.sandbox.paypal.com",
+ "api-m.sandbox.paypal.com",
+]);
+
+function isValidPayPalCertUrl(url: string): boolean {
+ try {
+ const parsed = new URL(url);
+
+ return (
+ parsed.protocol === "https:" &&
+ PAYPAL_CERT_HOST_ALLOWLIST.has(parsed.hostname)
+ );
+ } catch {
+ return false;
+ }
+}
+
async function downloadAndCache(url: string) {
const urlHash = crypto.createHash("sha256").update(url).digest("hex");
const cacheKey = `${CERT_CACHE_KEY_PREFIX}${urlHash}`;
@@ -58,6 +78,11 @@ export async function verifySignature({
return false;
}
+ if (!isValidPayPalCertUrl(certUrl)) {
+ console.error(`[PayPal] Rejected non-PayPal certificate URL: ${certUrl}`);
+ return false;
+ }
+
const certPem = await downloadAndCache(certUrl);
if (!certPem) {