Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

fix tests, bump to v4

Steven Teyf38ec80c023f
diff --git a/apps/web/lib/api/partners/search/providers/turbopuffer.ts b/apps/web/lib/api/partners/search/providers/turbopuffer.ts
index bf08647774..34a20d4d53 100644
--- a/apps/web/lib/api/partners/search/providers/turbopuffer.ts
+++ b/apps/web/lib/api/partners/search/providers/turbopuffer.ts
@@ -31,7 +31,7 @@ import { getEmailNgrams, getQueryNgrams } from "./shared";
* existing namespace. A new version is backfilled alongside the old one and
* swapped in, rather than rebuilt in place.
*/
-export const PARTNER_SEARCH_NAMESPACE = "partner-search-v3";
+export const PARTNER_SEARCH_NAMESPACE = "partner-search-v4";
const WRITE_BATCH_SIZE = 500;
/**
diff --git a/apps/web/tests/partners/get-partners-count-search.test.ts b/apps/web/tests/partners/get-partners-count-search.test.ts
index ebfebca8c9..e829a164bd 100644
--- a/apps/web/tests/partners/get-partners-count-search.test.ts
+++ b/apps/web/tests/partners/get-partners-count-search.test.ts
@@ -1,5 +1,8 @@
import { getPartnersCount } from "@/lib/api/partners/get-partners-count";
-import { PartnerSearchProvider } from "@/lib/api/partners/search";
+import {
+ PARTNER_SEARCH_CANDIDATE_LIMIT,
+ PartnerSearchProvider,
+} from "@/lib/api/partners/search";
import { beforeEach, describe, expect, it, vi } from "vitest";
const mocks = vi.hoisted(() => ({
@@ -41,10 +44,9 @@ describe("getPartnersCount search", () => {
}
});
- it("reports the provider's real total, not the truncated candidate count", async () => {
- // Counting the hits would report the candidate ceiling as the answer.
+ it("reports the truncated candidate count when the total exceeds the candidate ceiling", async () => {
const searchProvider = createSearchProvider(12_000);
- mocks.count.mockResolvedValue(999);
+ mocks.count.mockResolvedValue(PARTNER_SEARCH_CANDIDATE_LIMIT);
const count = await getPartnersCount<number>(
{
@@ -56,11 +58,11 @@ describe("getPartnersCount search", () => {
{ searchProvider },
);
- expect(count).toBe(12_000);
+ expect(count).toBe(PARTNER_SEARCH_CANDIDATE_LIMIT);
expect(searchProvider.countCandidates).toHaveBeenCalledWith({
programId: "prog_test",
query: "examp",
- limit: 999,
+ limit: PARTNER_SEARCH_CANDIDATE_LIMIT,
filters: {
status: { values: ["approved"], exclude: false },
groupId: undefined,
diff --git a/apps/web/tests/partners/get-partners-search.test.ts b/apps/web/tests/partners/get-partners-search.test.ts
index f932ba2f6a..25ddb843f8 100644
--- a/apps/web/tests/partners/get-partners-search.test.ts
+++ b/apps/web/tests/partners/get-partners-search.test.ts
@@ -1,5 +1,8 @@
import { getPartners } from "@/lib/api/partners/get-partners";
-import { PartnerSearchProvider } from "@/lib/api/partners/search";
+import {
+ PARTNER_SEARCH_CANDIDATE_LIMIT,
+ PartnerSearchProvider,
+} from "@/lib/api/partners/search";
import { beforeEach, describe, expect, it, vi } from "vitest";
const mocks = vi.hoisted(() => ({
@@ -104,7 +107,7 @@ describe("getPartners search", () => {
expect(searchProvider.searchCandidates).toHaveBeenCalledWith({
programId: "prog_test",
query: "examp",
- limit: 999,
+ limit: PARTNER_SEARCH_CANDIDATE_LIMIT,
filters: {
status: { values: ["approved"], exclude: false },
groupId: undefined,
@@ -156,9 +159,14 @@ describe("getPartners search", () => {
expect(idQuery.select).toEqual({ id: true });
expect(idQuery.include).toBeUndefined();
- // pge_1 ranks first and lands on page 1, so page 2 asks only for pge_3.
+ // pge_1 ranks first and lands on page 1, so page 2 hydrates only pge_3.
+ // The candidate filters stay on the query so IDs from another program
+ // cannot leak through.
const [pageQuery] = mocks.findMany.mock.calls[1];
- expect(pageQuery.where).toEqual({ id: { in: ["pge_3"] } });
+ expect(pageQuery.where).toMatchObject({
+ programId: "prog_test",
+ id: { in: ["pge_3"] },
+ });
expect(pageQuery.include).toBeDefined();
expect(pageQuery.take).toBeUndefined();
diff --git a/apps/web/tests/partners/partner-search-query.test.ts b/apps/web/tests/partners/partner-search-query.test.ts
index bdc218f47e..da45d2b81f 100644
--- a/apps/web/tests/partners/partner-search-query.test.ts
+++ b/apps/web/tests/partners/partner-search-query.test.ts
@@ -1,4 +1,7 @@
-import { buildPartnerSearchCandidateQuery } from "@/lib/api/partners/search";
+import {
+ buildPartnerSearchCandidateQuery,
+ PARTNER_SEARCH_CANDIDATE_LIMIT,
+} from "@/lib/api/partners/search";
import { describe, expect, it } from "vitest";
const defaultInput = {
@@ -15,7 +18,7 @@ describe("buildPartnerSearchCandidateQuery", () => {
expect(buildPartnerSearchCandidateQuery(defaultInput)).toEqual({
programId: "prog_test",
query: "examp",
- limit: 999,
+ limit: PARTNER_SEARCH_CANDIDATE_LIMIT,
filters: {
status: undefined,
groupId: undefined,