The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
Show zero condition values and 1-month commission durations.
Kiran Kf3d01c9b8bb8
diff --git a/apps/web/lib/commissions/build-commission-description.ts b/apps/web/lib/commissions/build-commission-description.tsindex 333af59f1e..e81cedcd09 100644--- a/apps/web/lib/commissions/build-commission-description.ts+++ b/apps/web/lib/commissions/build-commission-description.ts@@ -44,11 +44,11 @@ export function buildCommissionDescription({if (reward.event === "sale") {if (reward.maxDuration === null) {parts.push("for the customer's lifetime");- } else if (reward.maxDuration && reward.maxDuration > 1) {+ } else if (reward.maxDuration && reward.maxDuration >= 1) {const durationText =reward.maxDuration % 12 === 0? `${reward.maxDuration / 12} year${reward.maxDuration / 12 > 1 ? "s" : ""}`- : `${reward.maxDuration} months`;+ : `${reward.maxDuration} month${reward.maxDuration > 1 ? "s" : ""}`;parts.push(`for ${durationText}`);}}diff --git a/apps/web/tests/commissions/build-commission-description.test.ts b/apps/web/tests/commissions/build-commission-description.test.tsindex b6e2875c0c..3823e948d2 100644--- a/apps/web/tests/commissions/build-commission-description.test.ts+++ b/apps/web/tests/commissions/build-commission-description.test.ts@@ -99,6 +99,12 @@ describe("buildCommissionDescription", () => {});test("formats multi-month and multi-year durations", () => {+ expect(+ buildCommissionDescription({+ reward: saleReward({ maxDuration: 1 }),+ }),+ ).toBe("Earn 10% per sale for 1 month");+expect(buildCommissionDescription({reward: saleReward({ maxDuration: 6 }),diff --git a/apps/web/tests/rewards/format-reward-condition.test.ts b/apps/web/tests/rewards/format-reward-condition.test.tsindex 35de53c45a..9188f012d2 100644--- a/apps/web/tests/rewards/format-reward-condition.test.ts+++ b/apps/web/tests/rewards/format-reward-condition.test.ts@@ -82,6 +82,44 @@ describe("formatRewardConditionParts", () => {valueLabel: "$200.00",});});++ test("formats a valid zero numeric value", () => {+ expect(+ formatRewardConditionParts({+ event: "sale",+ condition: {+ entity: "partner",+ attribute: "totalClicks",+ operator: "equals_to",+ value: 0,+ },+ }),+ ).toEqual({+ entityLabel: "Partner",+ attributeLabel: "Total Clicks",+ operatorLabel: "is",+ valueLabel: "0",+ });+ });++ test("formats a valid zero currency value", () => {+ expect(+ formatRewardConditionParts({+ event: "sale",+ condition: {+ entity: "sale",+ attribute: "amount",+ operator: "greater_than_or_equal",+ value: 0,+ },+ }),+ ).toEqual({+ entityLabel: "Sale",+ attributeLabel: "Amount",+ operatorLabel: "is greater than or equal to",+ valueLabel: "$0.00",+ });+ });});describe("formatRewardConditionClause", () => {diff --git a/apps/web/ui/partners/program-reward-modifiers-tooltip.tsx b/apps/web/ui/partners/program-reward-modifiers-tooltip.tsxindex 416fb079d7..b4326bf032 100644--- a/apps/web/ui/partners/program-reward-modifiers-tooltip.tsx+++ b/apps/web/ui/partners/program-reward-modifiers-tooltip.tsx@@ -160,9 +160,8 @@ const RewardItem = ({<span className="min-w-0">{idx === 0 ? "If" : capitalize(operator)} {entityLabel}{" "}{attributeLabel} {operatorLabel}- {/* Match prior truthiness: hide value when condition.value is- falsy (e.g. 0), same as `condition.value && …` before. */}- {condition.value ? ` ${valueLabel}` : null}+ {/* Omit empty formatter output; still show valid zeros. */}+ {valueLabel ? ` ${valueLabel}` : null}</span></li>);