Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Improve workflow execution logging with consistent [Workflows] prefixes.

Kiran Kf4d4b21b02e2
diff --git a/apps/web/lib/api/workflows/execute-workflows.ts b/apps/web/lib/api/workflows/execute-workflows.ts
index 3d0b43ce9a..cde8578600 100644
--- a/apps/web/lib/api/workflows/execute-workflows.ts
+++ b/apps/web/lib/api/workflows/execute-workflows.ts
@@ -50,7 +50,16 @@ export async function executeWorkflows({
}: WorkflowContext) {
const { programId, partnerId } = identity;
- let workflows = await prisma.workflow.findMany({
+ console.log("[Workflows] Executing workflows...", {
+ trigger,
+ reason,
+ programId,
+ partnerId,
+ identity,
+ metrics,
+ });
+
+ const workflows = await prisma.workflow.findMany({
where: {
programId,
disabledAt: null,
@@ -59,13 +68,12 @@ export async function executeWorkflows({
});
if (workflows.length === 0) {
- console.log(
- `No workflows found to execute for trigger ${trigger} and reason ${reason}.`,
- );
+ console.log("[Workflows] No workflows found to execute for trigger.");
return;
}
- // Parse all workflow configs once upfront, filtering out any that fail to parse
+ console.log(`[Workflows] Found ${workflows.length} workflows to execute.`);
+
const parsedWorkflows = workflows
.map((workflow) => {
try {
@@ -74,10 +82,6 @@ export async function executeWorkflows({
config: parseWorkflowConfig(workflow),
};
} catch (error) {
- console.error(
- `Failed to parse workflow config for workflow ${workflow.id}, skipping:`,
- error,
- );
return null;
}
})
@@ -91,9 +95,7 @@ export async function executeWorkflows({
);
if (parsedWorkflows.length === 0) {
- console.log(
- `No valid workflows found to execute for trigger ${trigger} and reason ${reason}.`,
- );
+ console.log("[Workflows] No valid workflows found to execute.");
return;
}
@@ -101,6 +103,7 @@ export async function executeWorkflows({
let filteredWorkflows = parsedWorkflows;
if (reason) {
const expectedAttributes = REASON_TO_ATTRIBUTES[reason];
+
filteredWorkflows = parsedWorkflows.filter(({ config }) =>
config.conditions.some(({ attribute }) =>
expectedAttributes.includes(attribute),
@@ -109,7 +112,7 @@ export async function executeWorkflows({
if (filteredWorkflows.length === 0) {
console.log(
- `No relevant workflows found to execute for trigger ${trigger} and reason ${reason}.`,
+ `[Workflows] No relevant workflows found to execute for trigger.`,
);
return;
}
@@ -163,14 +166,14 @@ export async function executeWorkflows({
if (!programEnrollment) {
console.error(
- `Partner ${partnerId} is not enrolled in program ${programId}.`,
+ `[Workflows] Partner ${partnerId} is not enrolled in program ${programId}.`,
);
return;
}
if (!programEnrollment.groupId) {
console.error(
- `Partner ${partnerId} is not enrolled in a group in program ${programId}.`,
+ `[Workflows] Partner ${partnerId} is not enrolled in any group in program ${programId}.`,
);
return;
}
@@ -209,7 +212,10 @@ export async function executeWorkflows({
context: workflowContext,
});
} catch (error) {
- console.error(`Failed to execute workflow ${workflow.id}:`, error);
+ console.error(
+ `[Workflows] Failed to execute workflow ${workflow.id}:`,
+ error,
+ );
logger.error("workflows.execute_failed", {
error: toErrorFields(error),
diff --git a/apps/web/lib/api/workflows/parse-workflow-config.ts b/apps/web/lib/api/workflows/parse-workflow-config.ts
index 90d4b32c4f..49c40f6363 100644
--- a/apps/web/lib/api/workflows/parse-workflow-config.ts
+++ b/apps/web/lib/api/workflows/parse-workflow-config.ts
@@ -15,11 +15,13 @@ export function parseWorkflowConfig(
const actions = z.array(workflowActionSchema).parse(workflow.actions);
if (conditions.length === 0) {
- throw new Error("No conditions found in workflow.");
+ throw new Error(
+ `[Workflows] No conditions found in workflow ${workflow.id}.`,
+ );
}
if (actions.length === 0) {
- throw new Error("No actions found in workflow.");
+ throw new Error(`[Workflows] No actions found in workflow ${workflow.id}.`);
}
return {