Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Show partially approved submissions as Pending review to partners

Rafifc1eca820257
diff --git a/apps/web/app/(ee)/app.dub.co/embed/referrals/bounties/submission-detail.tsx b/apps/web/app/(ee)/app.dub.co/embed/referrals/bounties/submission-detail.tsx
index 22fc4d2ddb..afa4270b3a 100644
--- a/apps/web/app/(ee)/app.dub.co/embed/referrals/bounties/submission-detail.tsx
+++ b/apps/web/app/(ee)/app.dub.co/embed/referrals/bounties/submission-detail.tsx
@@ -1,6 +1,6 @@
"use client";
-import { BountySubmissionStatusBadges } from "@/lib/bounty/bounty-submission-status-badges";
+import { getPartnerSubmissionStatusBadge } from "@/lib/bounty/bounty-submission-status-badges";
import { REJECT_BOUNTY_SUBMISSION_REASONS } from "@/lib/bounty/constants";
import { getPeriodLabel } from "@/lib/bounty/periods";
import { resolveBountyDetails } from "@/lib/bounty/utils";
@@ -193,7 +193,7 @@ function SubmissionRightColumn({
submission: PartnerBountySubmission;
}) {
const bountyInfo = resolveBountyDetails(bounty);
- const statusBadge = BountySubmissionStatusBadges[submission.status];
+ const statusBadge = getPartnerSubmissionStatusBadge(submission.status);
const submittedDate = submission.completedAt ?? submission.createdAt;
const textValue = (text: string) => (
@@ -211,9 +211,7 @@ function SubmissionRightColumn({
icon={statusBadge.icon}
className="w-fit rounded-lg py-1"
>
- {submission.status === "submitted"
- ? "Pending review"
- : statusBadge.label}
+ {statusBadge.label}
</StatusBadge>
),
});
diff --git a/apps/web/app/(ee)/app.dub.co/embed/referrals/bounties/submissions-table.tsx b/apps/web/app/(ee)/app.dub.co/embed/referrals/bounties/submissions-table.tsx
index 2ae845320a..56105d6f3a 100644
--- a/apps/web/app/(ee)/app.dub.co/embed/referrals/bounties/submissions-table.tsx
+++ b/apps/web/app/(ee)/app.dub.co/embed/referrals/bounties/submissions-table.tsx
@@ -1,6 +1,6 @@
"use client";
-import { BountySubmissionStatusBadges } from "@/lib/bounty/bounty-submission-status-badges";
+import { getPartnerSubmissionStatusBadge } from "@/lib/bounty/bounty-submission-status-badges";
import {
type SubmissionPeriod,
getSubmissionPeriods,
@@ -47,11 +47,7 @@ export function EmbedBountySubmissionsTable({
original: SubmissionPeriod<PartnerBountySubmission>;
};
}) => {
- const config = BountySubmissionStatusBadges[original.status];
- const label =
- original.status === "submitted"
- ? "Pending review"
- : config?.label;
+ const config = getPartnerSubmissionStatusBadge(original.status);
return (
<div className="flex items-center gap-3">
<span className="text-content-subtle min-w-[52px] text-sm font-medium leading-5 tracking-[-0.28px]">
@@ -63,7 +59,7 @@ export function EmbedBountySubmissionsTable({
variant={config.variant}
icon={config.icon}
>
- {label}
+ {config.label}
</StatusBadge>
</span>
)}
@@ -79,13 +75,11 @@ export function EmbedBountySubmissionsTable({
minSize: 120,
size: 160,
cell: ({ row: { original } }) => {
- const config = BountySubmissionStatusBadges[original.status];
+ const config = getPartnerSubmissionStatusBadge(original.status);
if (!config) return null;
- const label =
- original.status === "submitted" ? "Pending review" : config.label;
return (
<StatusBadge variant={config.variant} icon={config.icon}>
- {label}
+ {config.label}
</StatusBadge>
);
},
diff --git a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/bounties/[bountyId]/bounty-submissions-table.tsx b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/bounties/[bountyId]/bounty-submissions-table.tsx
index eae29e419d..3e1e4d7264 100644
--- a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/bounties/[bountyId]/bounty-submissions-table.tsx
+++ b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/bounties/[bountyId]/bounty-submissions-table.tsx
@@ -1,6 +1,6 @@
"use client";
-import { BountySubmissionStatusBadges } from "@/lib/bounty/bounty-submission-status-badges";
+import { getPartnerSubmissionStatusBadge } from "@/lib/bounty/bounty-submission-status-badges";
import {
type SubmissionPeriod,
getSubmissionPeriods,
@@ -56,11 +56,7 @@ export function BountySubmissionsTable({
}: {
row: { original: SubmissionPeriod<PartnerBountySubmission> };
}) => {
- const config = BountySubmissionStatusBadges[original.status];
- const label =
- original.status === "submitted"
- ? "Pending review"
- : config?.label;
+ const config = getPartnerSubmissionStatusBadge(original.status);
return (
<div className="flex items-center gap-3">
@@ -73,7 +69,7 @@ export function BountySubmissionsTable({
variant={config.variant}
icon={config.icon}
>
- {label}
+ {config.label}
</StatusBadge>
</span>
)}
@@ -89,13 +85,11 @@ export function BountySubmissionsTable({
minSize: 120,
size: 160,
cell: ({ row: { original } }) => {
- const config = BountySubmissionStatusBadges[original.status];
+ const config = getPartnerSubmissionStatusBadge(original.status);
if (!config) return null;
- const label =
- original.status === "submitted" ? "Pending review" : config.label;
return (
<StatusBadge variant={config.variant} icon={config.icon}>
- {label}
+ {config.label}
</StatusBadge>
);
},
diff --git a/apps/web/lib/bounty/bounty-submission-status-badges.ts b/apps/web/lib/bounty/bounty-submission-status-badges.ts
index 3f01215cbc..dc0cb29416 100644
--- a/apps/web/lib/bounty/bounty-submission-status-badges.ts
+++ b/apps/web/lib/bounty/bounty-submission-status-badges.ts
@@ -6,6 +6,7 @@ import {
CircleXmark,
Lock,
} from "@dub/ui/icons";
+import { BountySubmissionStatus } from "@prisma/client";
export const BountySubmissionStatusBadges = {
notSubmitted: {
@@ -51,3 +52,20 @@ export const BountySubmissionStatusBadges = {
iconClassName: "text-red-600",
},
} as const;
+
+// Partners see partially approved submissions the same as submitted ones, as "Pending review"
+export function getPartnerSubmissionStatusBadge(
+ status: keyof typeof BountySubmissionStatusBadges,
+) {
+ if (
+ status === BountySubmissionStatus.submitted ||
+ status === BountySubmissionStatus.partiallyApproved
+ ) {
+ return {
+ ...BountySubmissionStatusBadges.submitted,
+ label: "Pending review",
+ };
+ }
+
+ return BountySubmissionStatusBadges[status];
+}
diff --git a/apps/web/ui/partners/bounties/bounty-submission-details-sheet.tsx b/apps/web/ui/partners/bounties/bounty-submission-details-sheet.tsx
index f8029a2bde..4788a9c99d 100644
--- a/apps/web/ui/partners/bounties/bounty-submission-details-sheet.tsx
+++ b/apps/web/ui/partners/bounties/bounty-submission-details-sheet.tsx
@@ -1,6 +1,6 @@
"use client";
-import { BountySubmissionStatusBadges } from "@/lib/bounty/bounty-submission-status-badges";
+import { getPartnerSubmissionStatusBadge } from "@/lib/bounty/bounty-submission-status-badges";
import { REJECT_BOUNTY_SUBMISSION_REASONS } from "@/lib/bounty/constants";
import { getPeriodLabel } from "@/lib/bounty/periods";
import { resolveBountyDetails } from "@/lib/bounty/utils";
@@ -125,7 +125,7 @@ function SubmissionDetailsView({
submission: PartnerBountySubmission;
}) {
const bountyInfo = resolveBountyDetails(bounty);
- const statusBadge = BountySubmissionStatusBadges[submission.status];
+ const statusBadge = getPartnerSubmissionStatusBadge(submission.status);
const submittedDate = submission.completedAt ?? submission.createdAt;
const textValue = (text: string) => (
@@ -143,9 +143,7 @@ function SubmissionDetailsView({
icon={statusBadge.icon}
className="w-fit rounded-lg py-1"
>
- {submission.status === "submitted"
- ? "Pending review"
- : statusBadge.label}
+ {statusBadge.label}
</StatusBadge>
),
});