The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
Fix `partnerCrossProgramBan` UX (#3700)
Steven Teyfdc108e6122c
diff --git a/apps/web/app/(ee)/api/cron/partners/ban/route.ts b/apps/web/app/(ee)/api/cron/partners/ban/route.tsindex 5f6b1ed4cd..b550c15894 100644--- a/apps/web/app/(ee)/api/cron/partners/ban/route.ts+++ b/apps/web/app/(ee)/api/cron/partners/ban/route.ts@@ -1,5 +1,4 @@import { deleteDiscountCodes } from "@/lib/api/discounts/delete-discount-code";-import { reportCrossProgramBanToNetwork } from "@/lib/api/fraud/report-cross-program-ban-to-network";import { linkCache } from "@/lib/api/links/cache";import { includeTags } from "@/lib/api/links/include-tags";import { syncTotalCommissions } from "@/lib/api/partners/sync-total-commissions";@@ -136,13 +135,6 @@ export const POST = withCron(async ({ rawBody }) => {deleteDiscountCodes(links.map((link) => link.discountCode)),]);- await reportCrossProgramBanToNetwork({- partnerId,- programId,- bannedReason: programEnrollment.bannedReason,- bannedAt: programEnrollment.bannedAt,- });-// Send emailif (partner.email) {const program = await prisma.program.findUniqueOrThrow({diff --git a/apps/web/lib/api/fraud/detect-record-fraud-application.ts b/apps/web/lib/api/fraud/detect-record-fraud-application.tsindex e73715bf7e..3b73376b5a 100644--- a/apps/web/lib/api/fraud/detect-record-fraud-application.ts+++ b/apps/web/lib/api/fraud/detect-record-fraud-application.ts@@ -28,46 +28,6 @@ export async function detectAndRecordFraudApplication({},});- // Check if partner has been banned in other programs- // indicates cross-program fraud risk- if (- isFraudRuleEnabled({- fraudRules,- ruleType: FraudRuleType.partnerCrossProgramBan,- })- ) {- const bannedProgramEnrollments = await prisma.programEnrollment.findMany({- where: {- partnerId: partner.id,- programId: {- not: program.id,- },- status: "banned",- },- select: {- programId: true,- bannedReason: true,- bannedAt: true,- },- });-- // Create a fraud event for each program that banned the partner- if (bannedProgramEnrollments.length > 0) {- for (const bannedEnrollment of bannedProgramEnrollments) {- fraudEvents.push({- programId: program.id,- partnerId: partner.id,- type: FraudRuleType.partnerCrossProgramBan,- sourceProgramId: bannedEnrollment.programId,- metadata: {- bannedReason: bannedEnrollment.bannedReason,- bannedAt: bannedEnrollment.bannedAt,- },- });- }- }- }-// Check if partner shares the same payoutMethodHash or cryptoWalletAddress with other partners// indicates potential duplicate account fraudif (diff --git a/apps/web/scripts/misc/remove-fraud-events.ts b/apps/web/scripts/misc/remove-paid-traffic-fraud-events.tssimilarity index 100%rename from apps/web/scripts/misc/remove-fraud-events.tsrename to apps/web/scripts/misc/remove-paid-traffic-fraud-events.tsdiff --git a/apps/web/scripts/misc/remove-program-ban-fraud-events.ts b/apps/web/scripts/misc/remove-program-ban-fraud-events.tsnew file mode 100644index 0000000000..814dea3fb7--- /dev/null+++ b/apps/web/scripts/misc/remove-program-ban-fraud-events.ts@@ -0,0 +1,52 @@+import { prisma } from "@dub/prisma";+import "dotenv-flow/config";++// script to remove fraud events for certain campaign ids+async function main() {+ const fraudEventsToRemove = await prisma.fraudEvent.findMany({+ where: {+ fraudEventGroup: {+ type: "partnerCrossProgramBan",+ status: "pending",+ },+ },+ });++ console.log(`Found ${fraudEventsToRemove.length} fraud events to remove`);++ const deleted = await prisma.fraudEvent.deleteMany({+ where: {+ id: {+ in: fraudEventsToRemove.map((event) => event.id),+ },+ },+ });++ console.log(`Removed ${deleted.count} fraud events`);++ const fraudEventGroupsWithNoEvents = await prisma.fraudEventGroup.findMany({+ where: {+ type: "partnerCrossProgramBan",+ status: "pending",+ fraudEvents: {+ none: {},+ },+ },+ });++ console.log(+ `Found ${fraudEventGroupsWithNoEvents.length} fraud event groups with no events`,+ );++ const deletedGroups = await prisma.fraudEventGroup.deleteMany({+ where: {+ id: {+ in: fraudEventGroupsWithNoEvents.map((group) => group.id),+ },+ },+ });++ console.log(`Removed ${deletedGroups.count} fraud event groups`);+}++main();