Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Handle workspace errors in network activity summary and fix stale platforms test

Kiran Kfe705d22d5d1
diff --git a/apps/web/playwright/api/program-applications/program-applications.spec.ts b/apps/web/playwright/api/program-applications/program-applications.spec.ts
index 5e572e2f95..7f9c90e670 100644
--- a/apps/web/playwright/api/program-applications/program-applications.spec.ts
+++ b/apps/web/playwright/api/program-applications/program-applications.spec.ts
@@ -160,8 +160,8 @@ test.describe("program applications", () => {
approvedUs,
] = seeded;
- // Application-level socials take precedence over the partner's platforms;
- // verifiedAt is only kept when both identifiers match.
+ // Application-level socials are ignored; platforms come from the partner's
+ // saved platforms as-is.
await prisma.programApplication.update({
where: { id: pendingUsWithPlatforms.id },
data: {
@@ -303,14 +303,14 @@ test.describe("program applications", () => {
},
{
type: "twitter",
- identifier: "application_handle",
- verifiedAt: null,
+ identifier: "partner_handle",
+ verifiedAt: VERIFIED_AT.toISOString(),
},
]);
expect(data[0].partner).toMatchObject({
website: VERIFIED_WEBSITE,
youtube: "partner_channel",
- twitter: "application_handle",
+ twitter: "partner_handle",
linkedin: null,
instagram: null,
tiktok: null,
diff --git a/apps/web/ui/partners/fraud-risks/partner-network-activity-summary.tsx b/apps/web/ui/partners/fraud-risks/partner-network-activity-summary.tsx
index 8bb2dcbda6..57ef45232b 100644
--- a/apps/web/ui/partners/fraud-risks/partner-network-activity-summary.tsx
+++ b/apps/web/ui/partners/fraud-risks/partner-network-activity-summary.tsx
@@ -20,7 +20,7 @@ type PartnerNetworkActivitySummaryState =
function usePartnerNetworkActivitySummary(
partnerId: string,
): PartnerNetworkActivitySummaryState {
- const { id: workspaceId } = useWorkspace();
+ const { id: workspaceId, error: workspaceError } = useWorkspace();
const { data, error, isLoading } = useSWR<
NetworkActivitySummary,
@@ -45,7 +45,7 @@ function usePartnerNetworkActivitySummary(
};
}
- if (error) {
+ if (error || (workspaceError && !workspaceId)) {
return {
status: "error",
};