The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
Bug: Single link pages with extra height (#3463)
Marcus Farrellfee2b9613dfb
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/links/[...link]/page-client.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/links/[...link]/page-client.tsxindex 286b7ce440..cdedbd3854 100644--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/links/[...link]/page-client.tsx+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/links/[...link]/page-client.tsx@@ -139,7 +139,7 @@ function LinkBuilder({ link }: { link: ExpandedLinkProps }) {const [isChangingLink, setIsChangingLink] = useState(false);return (- <div className="flex min-h-[calc(100vh-8px)] flex-col rounded-t-[inherit] bg-white">+ <div className="flex min-h-[calc(100dvh-var(--page-top-margin)-var(--page-bottom-margin)-1px)] flex-col rounded-t-[inherit] bg-white"><div className="py-2 pl-4 pr-5"><LinkBuilderHeaderonSelectLink={(selectedLink) => {@@ -308,7 +308,7 @@ const Controls = memo(({ link }: { link: ExpandedLinkProps }) => {function LoadingSkeleton() {return (- <div className="flex min-h-[calc(100vh-8px)] flex-col rounded-t-[inherit] bg-white">+ <div className="flex min-h-[calc(100dvh-var(--page-top-margin)-var(--page-bottom-margin)-1px)] flex-col rounded-t-[inherit] bg-white"><div className="flex items-center justify-between gap-4 py-2.5 pl-4 pr-5"><div className="h-8 w-64 max-w-full animate-pulse rounded-md bg-neutral-100" /><div className="h-7 w-32 max-w-full animate-pulse rounded-md bg-neutral-100" />diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/links/[...link]/page.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/links/[...link]/page.tsxindex b5bf9ccac3..ea512633c4 100644--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/links/[...link]/page.tsx+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/links/[...link]/page.tsx@@ -4,8 +4,8 @@ import { LinkPageClient } from "./page-client";export default function LinkPage() {return (<PageContentOld- className="md:mt-0 md:bg-transparent md:py-0"- contentWrapperClassName="pt-0 md:rounded-tl-2xl"+ className="h-full min-h-full md:mt-0 md:flex md:flex-col md:bg-transparent md:py-0"+ contentWrapperClassName="h-full grow pt-0 md:rounded-tl-2xl"><LinkPageClient /></PageContentOld>diff --git a/apps/web/ui/links/link-builder/link-action-bar.tsx b/apps/web/ui/links/link-builder/link-action-bar.tsxindex fa119e981a..195cccbcb8 100644--- a/apps/web/ui/links/link-builder/link-action-bar.tsx+++ b/apps/web/ui/links/link-builder/link-action-bar.tsx@@ -23,7 +23,7 @@ export function LinkActionBar({ children }: PropsWithChildren) {return (<divclassName={cn(- "sticky bottom-0 w-full overflow-hidden lg:bottom-4 lg:[filter:drop-shadow(0_5px_8px_#222A351d)]",+ "sticky bottom-0 z-10 w-full overflow-hidden lg:bottom-4 lg:[filter:drop-shadow(0_5px_8px_#222A351d)]",)}><div