The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
Fix partners ban cron crash when link has no discount code
Kiran Kff7173e25983
diff --git a/apps/web/app/(ee)/api/cron/partners/ban/route.ts b/apps/web/app/(ee)/api/cron/partners/ban/route.tsindex 247aaffb5c..3bffcc2840 100644--- a/apps/web/app/(ee)/api/cron/partners/ban/route.ts+++ b/apps/web/app/(ee)/api/cron/partners/ban/route.ts@@ -131,14 +131,7 @@ export const POST = withCron(async ({ rawBody }) => {recordLink(links, { deleted: true }),// Queue discount code deletions- deleteDiscountCodes(- links- .map((link) => link.discountCode)- .filter(- (discountCode): discountCode is NonNullable<typeof discountCode> =>- discountCode !== null,- ),- ),+ deleteDiscountCodes(links.map((link) => link.discountCode)),]);const affectedProgramEnrollments = await prisma.programEnrollment.findMany({diff --git a/apps/web/lib/api/discounts/delete-discount-code.ts b/apps/web/lib/api/discounts/delete-discount-code.tsindex f5b8ff966d..17cb791912 100644--- a/apps/web/lib/api/discounts/delete-discount-code.ts+++ b/apps/web/lib/api/discounts/delete-discount-code.ts@@ -7,9 +7,11 @@ const queue = qstash.queue({queueName: "delete-discount-code",});+type DiscountCodePayload = Pick<DiscountCode, "id" | "code" | "programId">;+type DeleteDiscountCodesParams =- | Pick<DiscountCode, "id" | "code" | "programId">- | Pick<DiscountCode, "id" | "code" | "programId">[];+ | DiscountCodePayload+ | (DiscountCodePayload | null | undefined)[];// Triggered in the following cases:// 1. When a discount is deleted@@ -17,7 +19,10 @@ type DeleteDiscountCodesParams =// 3. When partners are banned / deactivated// 4. When a partner is moved to a different groupexport async function deleteDiscountCodes(input: DeleteDiscountCodesParams) {- const discountCodes = Array.isArray(input) ? input : [input];+ const raw = Array.isArray(input) ? input : [input];+ const discountCodes = raw.filter(+ (dc): dc is NonNullable<typeof dc> => dc != null,+ );if (discountCodes.length === 0) {return;