Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Drop queueName when using flow control and skip sync link reward clears for move-group workflows.

Kiran Kfffb8ed99634
diff --git a/apps/web/lib/api/groups/move-partners-to-group.ts b/apps/web/lib/api/groups/move-partners-to-group.ts
index fcb9ff2c9c..8e21975770 100644
--- a/apps/web/lib/api/groups/move-partners-to-group.ts
+++ b/apps/web/lib/api/groups/move-partners-to-group.ts
@@ -24,6 +24,11 @@ interface MovePartnersToGroupParams {
| "discountId"
>;
groupMoveDisabledAt?: Date | null;
+ // Partner page moves one partner and refetches as soon as this request
+ // returns. Defaults to true for single-partner moves so the refetch sees
+ // cleared link overrides. Workflows / bulk moves leave this to
+ // processPartnerGroupChangeJob.
+ clearLinkRewardsSync?: boolean;
}
export async function movePartnersToGroup({
@@ -33,9 +38,13 @@ export async function movePartnersToGroup({
userId,
group,
groupMoveDisabledAt,
+ clearLinkRewardsSync,
}: MovePartnersToGroupParams): Promise<number> {
partnerIds = [...new Set(partnerIds)];
+ const shouldClearLinkRewardsSync =
+ clearLinkRewardsSync ?? partnerIds.length === 1;
+
if (partnerIds.length === 0) {
throw new DubApiError({
code: "bad_request",
@@ -168,11 +177,7 @@ export async function movePartnersToGroup({
logs,
});
- // The partner page moves one partner and refetches as soon as this request
- // returns. Clear link-level reward and discount overrides here so that
- // refetch sees the updated state. Bulk moves leave this to
- // processPartnerGroupChangeJob.
- if (partnerIds.length === 1) {
+ if (shouldClearLinkRewardsSync) {
const partnerLinks = await tx.link.findMany({
where: {
programId,
diff --git a/apps/web/lib/api/workflows/move-group/execute.ts b/apps/web/lib/api/workflows/move-group/execute.ts
index 1460b7a40d..6db8dfe6f1 100644
--- a/apps/web/lib/api/workflows/move-group/execute.ts
+++ b/apps/web/lib/api/workflows/move-group/execute.ts
@@ -127,6 +127,7 @@ export const executeMoveGroupWorkflow = async ({
partnerIds: [partnerId],
userId: null,
group: newGroup,
+ clearLinkRewardsSync: false,
});
} finally {
await redis.del(lockKey);
diff --git a/apps/web/lib/discounts/sync-discount-codes.ts b/apps/web/lib/discounts/sync-discount-codes.ts
index 11b05d0e47..3975a7f070 100644
--- a/apps/web/lib/discounts/sync-discount-codes.ts
+++ b/apps/web/lib/discounts/sync-discount-codes.ts
@@ -141,7 +141,6 @@ export async function enqueueMissingDiscountCodes({
await enqueueBatchJobs(
linksToProvision.map((link) => ({
- queueName: "create-discount-code",
url: `${APP_DOMAIN_WITH_NGROK}/api/cron/discount-codes/create`,
flowControl: {
key: "create-discount-code",
diff --git a/apps/web/lib/jobs/handlers/publish-discount-codes-creation-job.ts b/apps/web/lib/jobs/handlers/publish-discount-codes-creation-job.ts
index c0b80ca997..2d5ddba100 100644
--- a/apps/web/lib/jobs/handlers/publish-discount-codes-creation-job.ts
+++ b/apps/web/lib/jobs/handlers/publish-discount-codes-creation-job.ts
@@ -125,7 +125,6 @@ export const publishDiscountCodesCreationJob = defineJob({
await enqueueBatchJobs(
partnerLinks.map((link) => ({
- queueName: "create-discount-code",
url: `${APP_DOMAIN_WITH_NGROK}/api/cron/discount-codes/create`,
deduplicationId: `${discountId}-${link.id}`,
flowControl: {