Skip to content

AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.

fix: create mobile PWA memos before editing

tianma-if08d1aacb97f6
diff --git a/apps/web/src/components/WorkspaceApp.tsx b/apps/web/src/components/WorkspaceApp.tsx
index bbd1fe28..9bb72ff2 100644
--- a/apps/web/src/components/WorkspaceApp.tsx
+++ b/apps/web/src/components/WorkspaceApp.tsx
@@ -34,6 +34,7 @@ import {
getStandaloneMobileEditorReturningMemoId,
openStandaloneMobileEditor,
readMobileEditorReturnPreview,
+ requiresRemoteMemoForStandaloneMobileEditor,
type MobileEditorReturnPreview,
} from "@/lib/mobile-editor";
import { cn } from "@/lib/utils";
@@ -1624,9 +1625,16 @@ export const WorkspaceApp = ({
});
const createMemoMutation = useMutation({
- mutationFn: repository.createMemo,
+ mutationFn: async (input: Parameters<typeof repository.createMemo>[0]) => {
+ const requiresRemoteMemo = requiresRemoteMemoForStandaloneMobileEditor({
+ mobileViewport: !isDesktopViewport(),
+ desktopRuntime: Boolean(window.edgeeverDesktop?.isAvailable),
+ });
+ const data = requiresRemoteMemo ? await api.createMemo(input) : await repository.createMemo(input);
+ await putLocalMemo(localDataScope, data.memo);
+ return data;
+ },
onSuccess: (data) => {
- void putLocalMemo(localDataScope, data.memo);
const targetNotebookId = data.memo.notebookId;
setMemoView("notebook");
@@ -1680,7 +1688,17 @@ export const WorkspaceApp = ({
});
const useTemplateMutation = useMutation({
- mutationFn: (input: { templateId: string; notebookId: string }) => repository.useTemplate(input.templateId, input.notebookId),
+ mutationFn: async (input: { templateId: string; notebookId: string }) => {
+ const requiresRemoteMemo = requiresRemoteMemoForStandaloneMobileEditor({
+ mobileViewport: !isDesktopViewport(),
+ desktopRuntime: Boolean(window.edgeeverDesktop?.isAvailable),
+ });
+ const data = requiresRemoteMemo
+ ? await api.useTemplate(input.templateId, input.notebookId)
+ : await repository.useTemplate(input.templateId, input.notebookId);
+ await putLocalMemo(localDataScope, data.memo);
+ return data;
+ },
onSuccess: (data) => {
const targetNotebookId = data.memo.notebookId;
setTemplatesOpen(false);
diff --git a/apps/web/src/lib/mobile-editor.test.mjs b/apps/web/src/lib/mobile-editor.test.mjs
new file mode 100644
index 00000000..210a31bd
--- /dev/null
+++ b/apps/web/src/lib/mobile-editor.test.mjs
@@ -0,0 +1,23 @@
+import { describe, expect, test } from "bun:test";
+
+const { requiresRemoteMemoForStandaloneMobileEditor } = await import("./mobile-editor.ts");
+
+describe("standalone mobile editor handoff", () => {
+ test("requires a server memo before opening the web mobile editor", () => {
+ expect(requiresRemoteMemoForStandaloneMobileEditor({
+ mobileViewport: true,
+ desktopRuntime: false,
+ })).toBe(true);
+ });
+
+ test("keeps desktop and wide web creation on their repositories", () => {
+ expect(requiresRemoteMemoForStandaloneMobileEditor({
+ mobileViewport: false,
+ desktopRuntime: false,
+ })).toBe(false);
+ expect(requiresRemoteMemoForStandaloneMobileEditor({
+ mobileViewport: true,
+ desktopRuntime: true,
+ })).toBe(false);
+ });
+});
diff --git a/apps/web/src/lib/mobile-editor.ts b/apps/web/src/lib/mobile-editor.ts
index 0aead849..e50c83a2 100644
--- a/apps/web/src/lib/mobile-editor.ts
+++ b/apps/web/src/lib/mobile-editor.ts
@@ -15,6 +15,16 @@ export type MobileEditorReturnPreview = {
updatedAt: string;
};
+// The standalone web editor opens in a separate document and creates a server
+// edit session immediately, so it must never receive a local-first temporary ID.
+export const requiresRemoteMemoForStandaloneMobileEditor = ({
+ mobileViewport,
+ desktopRuntime,
+}: {
+ mobileViewport: boolean;
+ desktopRuntime: boolean;
+}) => mobileViewport && !desktopRuntime;
+
export const getStandaloneMobileEditorReturnPath = (memoId: string) => {
const params = new URLSearchParams({
[MOBILE_EDITOR_RETURN_PARAM]: memoId,