Skip to content

AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.

fix(mobile): settle reader scroll before toggling title

tianma-if120074b3c3f5
diff --git a/apps/mobile/src/components/LocalTiptapEditor.tsx b/apps/mobile/src/components/LocalTiptapEditor.tsx
index 468ee2c0..20d79b10 100644
--- a/apps/mobile/src/components/LocalTiptapEditor.tsx
+++ b/apps/mobile/src/components/LocalTiptapEditor.tsx
@@ -1,6 +1,7 @@
'use dom';
import "katex/dist/katex.min.css";
+import { attachMobileReaderScroll } from "../lib/mobile-reader-scroll";
import { Graph } from "@antv/x6";
import Image from "@tiptap/extension-image";
import CodeBlock from "@tiptap/extension-code-block";
@@ -142,7 +143,7 @@ type LocalTiptapEditorSharedProps = {
onResourcePress?: (targetJson: string) => Promise<void>;
onReady?: (startupMs: number) => Promise<void>;
onSearchResult?: (count: number, index: number, query: string) => Promise<void>;
- onReaderScroll?: (scrollTop: number) => Promise<void>;
+ onReaderScroll?: (collapsed: boolean) => Promise<void>;
onImageExportEvent?: (payloadJson: string) => Promise<void>;
ref: Ref<LocalTiptapEditorRef>;
locale: "zh-CN" | "en-US" | "ja" | "pl";
@@ -1616,18 +1617,9 @@ function LocalTiptapEditorImpl(props: LocalTiptapEditorProps) {
const scrollContainer = document.querySelector<HTMLElement>(".edgeever-editor-scroll");
if (!scrollContainer) return;
- let titleCollapsed = false;
- const reportScroll = () => {
- const nextCollapsed = titleCollapsed
- ? scrollContainer.scrollTop > 4
- : scrollContainer.scrollTop > 24;
- if (nextCollapsed === titleCollapsed) return;
- titleCollapsed = nextCollapsed;
- void onReaderScrollRef.current?.(scrollContainer.scrollTop);
- };
- scrollContainer.addEventListener("scroll", reportScroll, { passive: true });
- reportScroll();
- return () => scrollContainer.removeEventListener("scroll", reportScroll);
+ return attachMobileReaderScroll(scrollContainer, (collapsed) => {
+ void onReaderScrollRef.current?.(collapsed);
+ });
}, [editor, isViewer, visualDiagram]);
const toolbarState = useEditorState({
diff --git a/apps/mobile/src/lib/mobile-reader-scroll.test.ts b/apps/mobile/src/lib/mobile-reader-scroll.test.ts
new file mode 100644
index 00000000..2b1e2605
--- /dev/null
+++ b/apps/mobile/src/lib/mobile-reader-scroll.test.ts
@@ -0,0 +1,88 @@
+import { describe, expect, test } from "bun:test";
+import { attachMobileReaderScroll } from "./mobile-reader-scroll";
+
+const setup = () => {
+ const container = Object.assign(new EventTarget(), { scrollTop: 0 });
+ const reports: boolean[] = [];
+ let pending: (() => void) | undefined;
+ const dispose = attachMobileReaderScroll(container, (value) => reports.push(value), {
+ setTimeout: ((callback: () => void) => {
+ pending = callback;
+ return 1;
+ }) as typeof setTimeout,
+ clearTimeout: (() => { pending = undefined; }) as typeof clearTimeout,
+ });
+ const send = (name: string, top = container.scrollTop) => {
+ container.scrollTop = top;
+ container.dispatchEvent(new Event(name));
+ };
+ const idle = () => {
+ const callback = pending;
+ pending = undefined;
+ callback?.();
+ };
+ return { reports, send, idle, dispose };
+};
+
+describe("mobile reader header layout", () => {
+ test("holds layout during a slow drag and the following momentum", () => {
+ const reader = setup();
+ reader.send("touchstart");
+ reader.send("scroll", 60);
+ reader.idle();
+ reader.send("scrollend");
+ expect(reader.reports).toEqual([]);
+ reader.send("touchend");
+ reader.send("scroll", 100);
+ expect(reader.reports).toEqual([]);
+ reader.send("scrollend");
+ reader.idle();
+ expect(reader.reports).toEqual([true]);
+ reader.dispose();
+ });
+
+ test("expands once at the top and ignores scroll caused by native resizing", () => {
+ const reader = setup();
+ reader.send("wheel");
+ reader.send("scroll", 100);
+ reader.idle();
+ reader.send("touchstart");
+ reader.send("scroll", 0);
+ expect(reader.reports).toEqual([true]);
+ reader.send("touchend");
+ reader.idle();
+ reader.send("scroll", 80);
+ reader.idle();
+ reader.send("touchstart");
+ reader.send("touchend");
+ reader.idle();
+ expect(reader.reports).toEqual([true, false]);
+ reader.dispose();
+ });
+
+ test("keeps the collapsed state in the 4–24px hysteresis band", () => {
+ const reader = setup();
+ reader.send("wheel");
+ reader.send("scroll", 25);
+ reader.idle();
+ reader.send("wheel");
+ reader.send("scroll", 10);
+ reader.idle();
+ expect(reader.reports).toEqual([true]);
+ reader.send("wheel");
+ reader.send("scroll", 4);
+ reader.idle();
+ expect(reader.reports).toEqual([true, false]);
+ reader.dispose();
+ });
+
+ test("cancels pending reports when the reader unmounts", () => {
+ const reader = setup();
+ reader.send("wheel");
+ reader.send("scroll", 100);
+ reader.dispose();
+ reader.idle();
+ reader.send("scrollend");
+ expect(reader.reports).toEqual([]);
+ });
+});
diff --git a/apps/mobile/src/lib/mobile-reader-scroll.ts b/apps/mobile/src/lib/mobile-reader-scroll.ts
new file mode 100644
index 00000000..236e45a9
--- /dev/null
+++ b/apps/mobile/src/lib/mobile-reader-scroll.ts
@@ -0,0 +1,64 @@
+/** Native metadata changes the WebView's size. Only switch it after a user
+ * scroll settles; resize-generated scroll events must not start another switch. */
+export const attachMobileReaderScroll = (
+ container: Pick<HTMLElement, "scrollTop" | "addEventListener" | "removeEventListener">,
+ reportCollapsed: (collapsed: boolean) => void,
+ timers = { setTimeout, clearTimeout }
+) => {
+ let collapsed = false;
+ let touching = false;
+ let userScroll = false;
+ let timer: ReturnType<typeof setTimeout> | undefined;
+
+ const cancel = () => {
+ if (timer !== undefined) timers.clearTimeout(timer);
+ timer = undefined;
+ };
+ const settle = () => {
+ cancel();
+ if (touching || !userScroll) return;
+ userScroll = false;
+ const next = container.scrollTop > (collapsed ? 4 : 24);
+ if (next === collapsed) return;
+ collapsed = next;
+ reportCollapsed(next);
+ };
+ const schedule = () => {
+ cancel();
+ if (!touching && userScroll) timer = timers.setTimeout(settle, 150);
+ };
+ const startTouch = () => {
+ touching = true;
+ userScroll = false;
+ cancel();
+ };
+ const endTouch = () => {
+ touching = false;
+ schedule();
+ };
+ const startScroll = () => {
+ userScroll = true;
+ schedule();
+ };
+ const onScroll = () => {
+ if (touching) userScroll = true;
+ schedule();
+ };
+ const onKey = (event: Event) => {
+ if (["ArrowUp", "ArrowDown", "PageUp", "PageDown", "Home", "End", " "].includes((event as KeyboardEvent).key)) startScroll();
+ };
+ const listeners: Array<[string, EventListener]> = [
+ ["touchstart", startTouch],
+ ["touchend", endTouch],
+ ["touchcancel", endTouch],
+ ["wheel", startScroll],
+ ["keydown", onKey],
+ ["scroll", onScroll],
+ ["scrollend", settle],
+ ];
+ for (const [name, listener] of listeners) container.addEventListener(name, listener, { passive: true });
+ return () => {
+ cancel();
+ for (const [name, listener] of listeners) container.removeEventListener(name, listener);
+ };
+};
diff --git a/apps/mobile/src/screens/WorkspaceMemoDetail.tsx b/apps/mobile/src/screens/WorkspaceMemoDetail.tsx
index 75594e21..2f114759 100644
--- a/apps/mobile/src/screens/WorkspaceMemoDetail.tsx
+++ b/apps/mobile/src/screens/WorkspaceMemoDetail.tsx
@@ -700,8 +700,8 @@ export const MemoDetailModal = ({
Platform.OS === "android" ? ANDROID_SYSTEM_NAVIGATION_FALLBACK : 0
) + 16;
- const handleReaderScroll = useCallback(async (scrollTop: number) => {
- setTitleCollapsed(scrollTop > 24);
+ const handleReaderScroll = useCallback(async (collapsed: boolean) => {
+ setTitleCollapsed(collapsed);
}, []);
useEffect(() => {