AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.
HTML ai-agentcloudflarecloudflare-d1cloudflare-r2cloudflare-workersdockerelectronevernoteevernote-alternativeknowledge-basemcpnote-takingobsidian-alternativeoffline-firstpersonal-knowledge-basepwaself-hostedsqlitetiptapweb-clipper
fix(web): preserve position across editor modes
tianma-if156acf301da9
diff --git a/apps/web/src/components/EditorPane.tsx b/apps/web/src/components/EditorPane.tsxindex a3c511cb..912f9340 100644--- a/apps/web/src/components/EditorPane.tsx+++ b/apps/web/src/components/EditorPane.tsx@@ -181,6 +181,7 @@ import {NOTE_SEARCH_HIGHLIGHT_PLUGIN_KEY,type NoteSearchMatch,} from "./editor/note-search";+import { getEditorScrollProgress, restoreEditorScrollProgress } from "./editor/editor-mode-scroll";import { useEditorSaveStatus } from "./editor/useEditorSaveStatus";import { resolveEditorDraftState } from "./editor/editor-draft-state";import type { EdgeEverPluginHost, PluginEditorAdapter } from "@/lib/plugins/plugin-host";@@ -884,6 +885,22 @@ const RichEditorPane = ({const imageCompressionEnabledRef = useRef(imageCompressionEnabled);const resourceMenuHideTimerRef = useRef<number | null>(null);+ const restoreScrollAfterModeChange = useCallback((targetMode: "markdown" | "rich", progress: number) => {+ const restore = (attempt: number) => {+ const target = targetMode === "markdown"+ ? markdownTextAreaRef.current+ : editorScrollContainerRef.current;++ if (restoreEditorScrollProgress(target, progress) || attempt >= 2) {+ return;+ }++ window.requestAnimationFrame(() => restore(attempt + 1));+ };++ window.requestAnimationFrame(() => restore(0));+ }, []);+useEffect(() => {const handleMemoIdRemapped = (event: Event) => {const mappings = (event as CustomEvent<ReadonlyMap<string, string>>).detail;@@ -2364,10 +2381,15 @@ const RichEditorPane = ({return;}+ const scrollProgress = getEditorScrollProgress(+ isMarkdownMode ? markdownTextAreaRef.current : editorScrollContainerRef.current,+ );+if (isMarkdownMode) {hydratingRef.current = true;editor.commands.setContent(markdownToDoc(markdownSource));setIsMarkdownMode(false);+ restoreScrollAfterModeChange("rich", scrollProgress);window.setTimeout(() => {hydratingRef.current = false;}, 0);@@ -2376,7 +2398,8 @@ const RichEditorPane = ({setMarkdownSource(docToMarkdown(editor.getJSON() as TiptapDoc));setIsMarkdownMode(true);- }, [editor, effectiveReadOnly, isMarkdownMode, markdownSource]);+ restoreScrollAfterModeChange("markdown", scrollProgress);+ }, [editor, effectiveReadOnly, isMarkdownMode, markdownSource, restoreScrollAfterModeChange]);const handleMarkdownSourceChange = useCallback((value: string) => {setMarkdownSource(value);diff --git a/apps/web/src/components/editor/editor-mode-scroll.test.mjs b/apps/web/src/components/editor/editor-mode-scroll.test.mjsnew file mode 100644index 00000000..cfea1d63--- /dev/null+++ b/apps/web/src/components/editor/editor-mode-scroll.test.mjs@@ -0,0 +1,28 @@+import { describe, expect, test } from "bun:test";+import {+ getEditorScrollProgress,+ restoreEditorScrollProgress,+} from "./editor-mode-scroll.ts";++describe("editor mode scroll anchoring", () => {+ test("transfers relative position between differently sized editors", () => {+ const richEditor = { clientHeight: 600, scrollHeight: 3000, scrollTop: 1200 };+ const markdownEditor = { clientHeight: 700, scrollHeight: 4700, scrollTop: 0 };++ const progress = getEditorScrollProgress(richEditor);+ expect(progress).toBe(0.5);+ expect(restoreEditorScrollProgress(markdownEditor, progress)).toBe(true);+ expect(markdownEditor.scrollTop).toBe(2000);+ });++ test("clamps stale positions and tolerates missing scroll elements", () => {+ const editor = { clientHeight: 500, scrollHeight: 1500, scrollTop: 0 };++ expect(getEditorScrollProgress(null)).toBe(0);+ expect(restoreEditorScrollProgress(null, 0.5)).toBe(false);+ restoreEditorScrollProgress(editor, 2);+ expect(editor.scrollTop).toBe(1000);+ restoreEditorScrollProgress(editor, -1);+ expect(editor.scrollTop).toBe(0);+ });+});diff --git a/apps/web/src/components/editor/editor-mode-scroll.ts b/apps/web/src/components/editor/editor-mode-scroll.tsnew file mode 100644index 00000000..3cea04b9--- /dev/null+++ b/apps/web/src/components/editor/editor-mode-scroll.ts@@ -0,0 +1,16 @@+type ScrollMetrics = Pick<HTMLElement, "clientHeight" | "scrollHeight" | "scrollTop">;++const clampUnit = (value: number) => Math.min(1, Math.max(0, value));++export const getEditorScrollProgress = (element: ScrollMetrics | null) => {+ if (!element) return 0;+ const maxScrollTop = Math.max(0, element.scrollHeight - element.clientHeight);+ return maxScrollTop > 0 ? clampUnit(element.scrollTop / maxScrollTop) : 0;+};++export const restoreEditorScrollProgress = (element: ScrollMetrics | null, progress: number) => {+ if (!element) return false;+ const maxScrollTop = Math.max(0, element.scrollHeight - element.clientHeight);+ element.scrollTop = maxScrollTop * clampUnit(progress);+ return true;+};