Skip to content

AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.

fix(editor): unify image formatting and resource actions

tianma-if1d360fb060c5
diff --git a/apps/web/src/components/EditorPane.tsx b/apps/web/src/components/EditorPane.tsx
index 78dfd942..357d97a0 100644
--- a/apps/web/src/components/EditorPane.tsx
+++ b/apps/web/src/components/EditorPane.tsx
@@ -255,6 +255,7 @@ import {
type ImagePreviewRequestDetail,
} from "./editor/ResizableImage";
import { EditableImageGallery } from "./editor/ImageGallery";
+import { imageSelectionKey } from "./editor/image-selection";
import { ImageViewer } from "./editor/ImageViewer";
import { PdfAttachment } from "./editor/PdfAttachment";
import { FileAttachment } from "./editor/FileAttachment";
@@ -1764,9 +1765,9 @@ const RichEditorPane = ({
useEffect(() => {
const showImageMenu = (event: Event) => {
- if (isMobileViewport) return;
const detail = (event as CustomEvent<ImageMenuRequestDetail>).detail;
if (!detail?.element) return;
+ if (isMobileViewport && !detail.actionsElement) return;
cancelResourceMenuHide();
const rect = detail.element.getBoundingClientRect();
showResourceMenu({
@@ -1933,6 +1934,7 @@ const RichEditorPane = ({
useEffect(() => {
if (!resourceMenuTarget) return;
+ if (resourceMenuTarget.kind === "image" && resourceMenuTarget.actionsElement) return;
const hideMenu = () => hideResourceMenu();
window.addEventListener("resize", hideMenu);
window.addEventListener("scroll", hideMenu, true);
@@ -3301,7 +3303,7 @@ const RichEditorPane = ({
}, []);
const handleResourceDownload = useCallback(async (target: ResourceMenuTarget) => {
- hideResourceMenu();
+ if (target.kind !== "image" || !target.actionsElement) hideResourceMenu();
clearResourceActionError();
downloadResourceDirectly(target);
}, [clearResourceActionError, downloadResourceDirectly, hideResourceMenu]);
@@ -3403,7 +3405,7 @@ const RichEditorPane = ({
}, []);
const handleResourceCopy = useCallback((target: ResourceMenuTarget) => {
- hideResourceMenu();
+ if (target.kind !== "image" || !target.actionsElement) hideResourceMenu();
clearResourceActionError();
// Start the clipboard write in this turn so Safari still has the click gesture.
void copyResourceToClipboard({
@@ -3417,7 +3419,10 @@ const RichEditorPane = ({
const openResourceDialog = useCallback((action: ResourceDialogState["action"], target: ResourceMenuTarget) => {
openResourceActionDialog(action, target);
- }, [openResourceActionDialog]);
+ if (target.kind === "image" && isEditorReady(editor)) {
+ editor.view.dispatch(editor.state.tr.setMeta(imageSelectionKey, null));
+ }
+ }, [editor, openResourceActionDialog]);
const handleResourceRename = useCallback(async () => {
const target = resourceDialog?.action === "rename" ? resourceDialog.target : null;
diff --git a/apps/web/src/components/editor/EditorPaneChrome.tsx b/apps/web/src/components/editor/EditorPaneChrome.tsx
index 016df18c..b7c25033 100644
--- a/apps/web/src/components/editor/EditorPaneChrome.tsx
+++ b/apps/web/src/components/editor/EditorPaneChrome.tsx
@@ -108,21 +108,26 @@ export const ResourceActionMenu = ({
onMouseLeave: () => void;
}) => {
const referenceElement = target.element ?? null;
+ // Keep a closing image menu in its detached panel until cleanup runs; never
+ // briefly turn it back into a floating menu on the document body.
+ const actionsElement = target.kind === "image" ? target.actionsElement ?? null : null;
const { refs, floatingStyles, isPositioned } = useFloating({
...(target.kind === "image" ? imageResourceMenuPosition : attachmentResourceMenuPosition),
- elements: { reference: referenceElement },
- whileElementsMounted: autoUpdate,
+ elements: { reference: actionsElement ? null : referenceElement },
+ whileElementsMounted: actionsElement ? undefined : autoUpdate,
});
return createPortal(
<TooltipProvider delayDuration={0} skipDelayDuration={0}>
<div
- ref={refs.setFloating}
+ ref={actionsElement ? undefined : refs.setFloating}
data-edgeever-resource-menu
role="toolbar"
aria-label={labels.download}
- className="fixed z-[110] flex items-center gap-1 overflow-hidden rounded-lg border border-slate-200 bg-card p-1 shadow-lg"
- style={referenceElement ? {
+ className={actionsElement
+ ? "flex flex-wrap items-center gap-1"
+ : "fixed z-[110] flex items-center gap-1 overflow-hidden rounded-lg border border-slate-200 bg-card p-1 shadow-lg"}
+ style={actionsElement ? undefined : referenceElement ? {
...floatingStyles,
visibility: isPositioned ? "visible" : "hidden",
} : {
@@ -135,10 +140,11 @@ export const ResourceActionMenu = ({
: "translateX(-50%)",
}}
onMouseEnter={onMouseEnter}
- onMouseLeave={onMouseLeave}
+ onMouseLeave={actionsElement ? undefined : onMouseLeave}
+ onMouseDown={actionsElement ? (event) => event.preventDefault() : undefined}
onFocusCapture={onMouseEnter}
onBlurCapture={(event) => {
- if (!event.currentTarget.contains(event.relatedTarget as Node | null)) onMouseLeave();
+ if (!actionsElement && !event.currentTarget.contains(event.relatedTarget as Node | null)) onMouseLeave();
}}
>
<IconTooltip label={labels.download}>
@@ -161,13 +167,13 @@ export const ResourceActionMenu = ({
</Button>
</IconTooltip>
) : null}
- <IconTooltip label={canRename ? labels.rename : labels.unavailable}>
+ {(!actionsElement || canRename) && <IconTooltip label={canRename ? labels.rename : labels.unavailable}>
<Button type="button" size="sm" variant="ghost" aria-label={labels.rename} disabled={!canRename} onClick={onRename}>
<Pencil className="h-3.5 w-3.5" />
{labels.rename}
</Button>
- </IconTooltip>
- <IconTooltip label={canDelete ? labels.delete : labels.unavailable}>
+ </IconTooltip>}
+ {(!actionsElement || canDelete) && <IconTooltip label={canDelete ? labels.delete : labels.unavailable}>
<Button
type="button"
size="sm"
@@ -180,10 +186,10 @@ export const ResourceActionMenu = ({
<Trash2 className="h-3.5 w-3.5" />
{labels.delete}
</Button>
- </IconTooltip>
+ </IconTooltip>}
</div>
</TooltipProvider>,
- document.body,
+ actionsElement ?? document.body,
);
};
diff --git a/apps/web/src/components/editor/ResizableImage.tsx b/apps/web/src/components/editor/ResizableImage.tsx
index d975e843..d42529e7 100644
--- a/apps/web/src/components/editor/ResizableImage.tsx
+++ b/apps/web/src/components/editor/ResizableImage.tsx
@@ -20,6 +20,7 @@ import { createImageSelectionPlugin, imageSelectionKey } from "./image-selection
export type ImageMenuRequestDetail = {
element: HTMLElement;
+ actionsElement: HTMLElement | null;
url: string;
filename: string;
resourceId: string | null;
@@ -47,6 +48,7 @@ const ResizableImageNodeView = ({
const { t } = useTranslation();
const wrapperRef = useRef<HTMLDivElement | null>(null);
const imageRef = useRef<HTMLImageElement | null>(null);
+ const actionsRef = useRef<HTMLDivElement | null>(null);
const [previewWidth, setPreviewWidth] = useState<number | null>(null);
const nodeWidth = parseImageWidth(node.attrs.width) ?? NEW_IMAGE_WIDTH_PERCENT;
const width = previewWidth ?? nodeWidth;
@@ -60,7 +62,8 @@ const ResizableImageNodeView = ({
explicitlySelected: imageSelectionKey.getState(activeEditor.state) === getPos(),
}),
});
- const showSizeControls = editable && selected && explicitlySelected && !inGallery;
+ const showImageControls = selected && explicitlySelected && !inGallery;
+ const showSizeControls = editable && showImageControls;
const alt = typeof node.attrs.alt === "string" ? node.attrs.alt : "";
const title = typeof node.attrs.title === "string" ? node.attrs.title : "";
const src = typeof node.attrs.src === "string" ? node.attrs.src : "";
@@ -135,6 +138,7 @@ const ResizableImageNodeView = ({
window.dispatchEvent(new CustomEvent<ImageMenuRequestDetail>(IMAGE_MENU_SHOW_EVENT, {
detail: {
element,
+ actionsElement: actionsRef.current,
url: src,
filename: title || alt || getAttachmentResourceId(src) || "image",
resourceId: getAttachmentResourceId(src),
@@ -149,19 +153,55 @@ const ResizableImageNodeView = ({
}, []);
useEffect(() => {
- if (showSizeControls) hideImageMenu();
- }, [hideImageMenu, showSizeControls]);
+ if (!showImageControls) return;
+ requestImageMenu();
+ return hideImageMenu;
+ }, [hideImageMenu, requestImageMenu, showImageControls]);
+
+ useEffect(() => {
+ if (!showImageControls) return;
+ const dismiss = () => {
+ if (!editor.isDestroyed) editor.view.dispatch(editor.state.tr.setMeta(imageSelectionKey, null));
+ };
+ const onPointerDown = (event: PointerEvent) => {
+ if (event.target instanceof Node && !wrapperRef.current?.contains(event.target)) dismiss();
+ };
+ const onKeyDown = (event: KeyboardEvent) => {
+ if (event.key === "Escape") {
+ event.preventDefault();
+ dismiss();
+ editor.view.focus();
+ }
+ };
+ document.addEventListener("pointerdown", onPointerDown);
+ document.addEventListener("keydown", onKeyDown);
+ return () => {
+ document.removeEventListener("pointerdown", onPointerDown);
+ document.removeEventListener("keydown", onKeyDown);
+ };
+ }, [editor, showImageControls]);
+
+ const selectImage = () => {
+ if (inGallery) return;
+ const position = getPos();
+ if (typeof position !== "number") return;
+ editor.chain().focus().setNodeSelection(position).command(({ tr }) => {
+ tr.setMeta(imageSelectionKey, position);
+ return true;
+ }).run();
+ };
const requestImagePreview = useCallback(() => {
if (!src) return;
hideImageMenu();
+ editor.view.dispatch(editor.state.tr.setMeta(imageSelectionKey, null));
window.dispatchEvent(new CustomEvent<ImagePreviewRequestDetail>(IMAGE_PREVIEW_SHOW_EVENT, {
detail: {
url: src,
alt: title || alt,
},
}));
- }, [alt, hideImageMenu, src, title]);
+ }, [alt, editor, hideImageMenu, src, title]);
const updateWidth = useCallback((nextWidth: number) => {
if (!editor.isEditable || isImageInGallery(editor.state.doc, getPos())) return;
@@ -237,34 +277,28 @@ const ResizableImageNodeView = ({
<NodeViewWrapper
ref={wrapperRef}
as="figure"
- className={cn("edgeever-image-node", showSizeControls && "is-selected")}
+ className={cn("edgeever-image-node", showImageControls && "is-selected")}
style={{ width: `${width}%`, ...(explicitAlignment ? imageAlignmentMargins(explicitAlignment) : {}) }}
data-width={width}
data-image-align={alignment}
- onMouseLeave={hideImageMenu}
+ onMouseLeave={inGallery ? hideImageMenu : undefined}
onContextMenu={(event: MouseEvent<HTMLElement>) => {
event.preventDefault();
- requestImageMenu();
+ if (inGallery || showImageControls) requestImageMenu();
+ else selectImage();
}}
>
<img
ref={imageRef}
src={src}
alt={alt}
- title={title || undefined}
draggable={false}
referrerPolicy={getImageReferrerPolicy(src)}
onClick={(event) => {
- if (!editor.isEditable || isImageInGallery(editor.state.doc, getPos())) return;
- const position = getPos();
- if (typeof position !== "number") return;
// A positioned figure does not occupy the full block wrapper. Select
// its node explicitly instead of relying on coordinate hit testing.
event.preventDefault();
- editor.chain().focus().setNodeSelection(position).command(({ tr }) => {
- tr.setMeta(imageSelectionKey, position);
- return true;
- }).run();
+ selectImage();
}}
onDoubleClick={(event) => {
event.preventDefault();
@@ -272,76 +306,81 @@ const ResizableImageNodeView = ({
requestImagePreview();
}}
/>
- {showSizeControls && (
- <div className="edgeever-image-controls" contentEditable={false} onMouseEnter={hideImageMenu}>
- {previewButton}
- <div className="edgeever-image-presets" aria-label={t("editor.imageScale")}>
- {IMAGE_WIDTH_PRESETS.map((preset) => (
- <button
- key={preset.width}
- type="button"
- className={cn("edgeever-image-preset", width === preset.width && "is-active")}
- aria-label={t(preset.labelKey)}
- aria-pressed={width === preset.width}
- onMouseDown={(event) => event.preventDefault()}
- onClick={() => updateWidth(preset.width)}
- >
- <span>{t(preset.labelKey)}</span>
- </button>
- ))}
- </div>
- <TooltipProvider delayDuration={0} skipDelayDuration={0}>
- <div className="edgeever-image-alignments" role="group" aria-label={t("editor.imageAlignment")}>
- {([
- { value: "left", Icon: AlignLeft },
- { value: "center", Icon: AlignCenter },
- { value: "right", Icon: AlignRight },
- ] as const).map(({ value, Icon }) => (
- <Tooltip key={value}>
+ {showImageControls && (
+ <div className="edgeever-image-panel" contentEditable={false} onMouseDown={(event) => event.preventDefault()}>
+ <div className="edgeever-image-controls">
+ {previewButton}
+ {showSizeControls && (<>
+ <div className="edgeever-image-presets" aria-label={t("editor.imageScale")}>
+ {IMAGE_WIDTH_PRESETS.map((preset) => (
+ <button
+ key={preset.width}
+ type="button"
+ className={cn("edgeever-image-preset", width === preset.width && "is-active")}
+ aria-label={t(preset.labelKey)}
+ aria-pressed={width === preset.width}
+ onMouseDown={(event) => event.preventDefault()}
+ onClick={() => updateWidth(preset.width)}
+ >
+ <span>{t(preset.labelKey)}</span>
+ </button>
+ ))}
+ </div>
+ <TooltipProvider delayDuration={0} skipDelayDuration={0}>
+ <div className="edgeever-image-alignments" role="group" aria-label={t("editor.imageAlignment")}>
+ {([
+ { value: "left", Icon: AlignLeft },
+ { value: "center", Icon: AlignCenter },
+ { value: "right", Icon: AlignRight },
+ ] as const).map(({ value, Icon }) => (
+ <Tooltip key={value}>
+ <TooltipTrigger asChild>
+ <button
+ type="button"
+ className={cn("edgeever-image-alignment", alignment === value && "is-active")}
+ aria-label={t(`editor.imageAlignments.${value}`)}
+ aria-pressed={alignment === value}
+ onMouseDown={(event) => event.preventDefault()}
+ onClick={() => updateAlignment(value)}
+ >
+ <Icon aria-hidden="true" className="h-4 w-4" />
+ </button>
+ </TooltipTrigger>
+ <TooltipContent side="top">{t(`editor.imageAlignments.${value}`)}</TooltipContent>
+ </Tooltip>
+ ))}
+ </div>
+ </TooltipProvider>
+ {canGroupAdjacentImages ? (
+ <button
+ type="button"
+ className="edgeever-image-preset"
+ aria-label={t("editor.imageGallery.group")}
+ onMouseDown={(event) => event.preventDefault()}
+ onClick={groupAdjacentImages}
+ >
+ <span>{t("editor.imageGallery.group")}</span>
+ </button>
+ ) : null}
+ <TooltipProvider delayDuration={0} skipDelayDuration={0}>
+ <Tooltip>
<TooltipTrigger asChild>
<button
type="button"
- className={cn("edgeever-image-alignment", alignment === value && "is-active")}
- aria-label={t(`editor.imageAlignments.${value}`)}
- aria-pressed={alignment === value}
- onMouseDown={(event) => event.preventDefault()}
- onClick={() => updateAlignment(value)}
- >
- <Icon aria-hidden="true" className="h-4 w-4" />
- </button>
+ className="edgeever-image-resize-handle"
+ aria-label={t("editor.resizeImage")}
+ onPointerDown={startResize}
+ />
</TooltipTrigger>
- <TooltipContent side="top">{t(`editor.imageAlignments.${value}`)}</TooltipContent>
+ <TooltipContent side="top">{t("editor.resizeImage")}</TooltipContent>
</Tooltip>
- ))}
- </div>
- </TooltipProvider>
- {canGroupAdjacentImages ? (
- <button
- type="button"
- className="edgeever-image-preset"
- aria-label={t("editor.imageGallery.group")}
- onMouseDown={(event) => event.preventDefault()}
- onClick={groupAdjacentImages}
- >
- <span>{t("editor.imageGallery.group")}</span>
- </button>
- ) : null}
- <TooltipProvider delayDuration={0} skipDelayDuration={0}>
- <Tooltip>
- <TooltipTrigger asChild>
- <button
- type="button"
- className="edgeever-image-resize-handle"
- aria-label={t("editor.resizeImage")}
- onPointerDown={startResize}
- />
- </TooltipTrigger>
- <TooltipContent side="top">{t("editor.resizeImage")}</TooltipContent>
- </Tooltip>
- </TooltipProvider>
+ </TooltipProvider>
+ </>)}
+ </div>
+ <div ref={actionsRef} className="edgeever-image-resource-actions" />
</div>
)}
- {!showSizeControls && (
+ {!showImageControls && (
<div className="edgeever-image-preview-control" contentEditable={false}>
{previewButton}
</div>
diff --git a/apps/web/src/components/editor/image-selection.test.mjs b/apps/web/src/components/editor/image-selection.test.mjs
index 432189e7..21f92298 100644
--- a/apps/web/src/components/editor/image-selection.test.mjs
+++ b/apps/web/src/components/editor/image-selection.test.mjs
@@ -16,6 +16,14 @@ const clickImage = (state, position = 0) => state.apply(state.tr
.setMeta(imageSelectionKey, position));
describe("explicit image selection", () => {
+ test("dismisses controls without changing the note or the required node selection", () => {
+ const selected = clickImage(createState());
+ const dismissed = selected.apply(selected.tr.setMeta(imageSelectionKey, null));
+ expect(imageSelectionKey.getState(dismissed)).toBeNull();
+ expect(dismissed.doc).toBe(selected.doc);
+ expect(dismissed.selection).toBeInstanceOf(NodeSelection);
+ expect(imageSelectionKey.getState(clickImage(dismissed))).toBe(0);
+ });
test("opening an image-only or image-first note does not activate image controls", () => {
for (const content of [[image()], [image(), schema.nodes.paragraph.create()]]) {
const state = createState(content);
diff --git a/apps/web/src/components/editor/image-selection.ts b/apps/web/src/components/editor/image-selection.ts
index e0d03aea..bb5335ee 100644
--- a/apps/web/src/components/editor/image-selection.ts
+++ b/apps/web/src/components/editor/image-selection.ts
@@ -9,8 +9,8 @@ export const createImageSelectionPlugin = () => new Plugin<number | null>({
state: {
init: () => null,
apply(transaction, previous) {
- const requested = transaction.getMeta(imageSelectionKey) as number | undefined;
- const position = requested ?? (previous === null ? null : transaction.mapping.map(previous));
+ const requested = transaction.getMeta(imageSelectionKey) as number | null | undefined;
+ const position = requested !== undefined ? requested : (previous === null ? null : transaction.mapping.map(previous));
const selection = transaction.selection;
return position !== null && selection instanceof NodeSelection &&
selection.node.type.name === "image" && selection.from === position
diff --git a/apps/web/src/components/editor/useEditorResourceActions.ts b/apps/web/src/components/editor/useEditorResourceActions.ts
index 48fca14e..5e7234f8 100644
--- a/apps/web/src/components/editor/useEditorResourceActions.ts
+++ b/apps/web/src/components/editor/useEditorResourceActions.ts
@@ -17,6 +17,7 @@ export type AttachmentMenuTarget = {
export type ImageMenuTarget = {
kind: "image";
+ actionsElement?: HTMLElement | null;
element?: HTMLElement;
url: string;
filename: string;
diff --git a/apps/web/src/styles/globals.css b/apps/web/src/styles/globals.css
index 03b5b99f..9602c382 100644
--- a/apps/web/src/styles/globals.css
+++ b/apps/web/src/styles/globals.css
@@ -2132,7 +2132,7 @@ html[data-edgeever-extension-theme] .edgeever-memo-divider {
outline-offset: 3px;
}
-.ProseMirror .edgeever-image-controls {
+.ProseMirror .edgeever-image-panel {
position: relative;
z-index: 2;
display: flex;
@@ -2144,10 +2144,30 @@ html[data-edgeever-extension-theme] .edgeever-memo-divider {
gap: 0.35rem;
border: 1px solid rgba(var(--brand-green-200-rgb), 0.95);
border-radius: 8px;
- background: rgba(255, 255, 255, 0.94);
+ background: hsl(var(--card));
padding: 0.3rem;
box-shadow: 0 10px 28px rgba(15, 23, 42, 0.16);
line-height: 1;
+ color: hsl(var(--foreground));
+ font-family: var(--ui-font-family, Inter, ui-sans-serif, system-ui, sans-serif);
+}
+
+.ProseMirror .edgeever-image-controls {
+ display: flex;
+ flex-wrap: wrap;
+ align-items: center;
+ gap: 0.35rem;
+ width: 100%;
+}
+
+.ProseMirror .edgeever-image-panel :is(.edgeever-image-preview-button, .edgeever-image-preset, .edgeever-image-alignment) {
+ color: hsl(var(--foreground));
+}
+
+.ProseMirror .edgeever-image-resource-actions:not(:empty) {
+ width: 100%;
+ border-top: 1px solid rgba(var(--brand-green-200-rgb), 0.95);
+ padding-top: 0.3rem;
}
.ProseMirror .edgeever-image-preview-control {
@@ -2348,11 +2368,7 @@ html[data-edgeever-extension-theme] .edgeever-memo-divider {
}
.ProseMirror .edgeever-image-presets {
- display: flex;
- max-width: 100%;
- flex-wrap: wrap;
- align-items: center;
- gap: 0.2rem;
+ display: contents;
}
.ProseMirror .edgeever-image-alignments {
diff --git a/packages/shared/src/note-image-card.ts b/packages/shared/src/note-image-card.ts
index 19fc513e..f4ede6aa 100644
--- a/packages/shared/src/note-image-card.ts
+++ b/packages/shared/src/note-image-card.ts
@@ -378,7 +378,7 @@ export const generateCardCss = ({ theme = "glass", fontStyle = "auto", fontSize
.edgeever-card-body .edgeever-table-label { color: var(--ee-meta); font-weight: 600; }
.edgeever-card-body .edgeever-table-value { min-width: 0; }
.edgeever-card-body [data-edgeever-theme-block] { border-left: ${px(2)} solid var(--ee-accent); background: ${cfg.metaBg}; padding: 0.8em; margin: 1em 0; }
-.edgeever-card-body .edgeever-image-controls, .edgeever-card-body .edgeever-code-copy-button,
+.edgeever-card-body .edgeever-image-panel, .edgeever-card-body .edgeever-image-controls, .edgeever-card-body .edgeever-code-copy-button,
.edgeever-card-body .edgeever-theme-block__toolbar, .edgeever-card-body .edgeever-mermaid-source { display: none !important; }
.edgeever-card-footer { display: flex; flex-direction: column; gap: ${px(12)}; margin-top: ${px(24)}; color: var(--ee-meta); font-size: var(--ee-meta-size); }
.edgeever-footer-author { display: flex; align-items: center; gap: ${px(8)}; min-width: 0; overflow-wrap: anywhere; }
diff --git a/packages/shared/src/note-image-content.test.mjs b/packages/shared/src/note-image-content.test.mjs
index 5a37824c..c7b81ec0 100644
--- a/packages/shared/src/note-image-content.test.mjs
+++ b/packages/shared/src/note-image-content.test.mjs
@@ -2,6 +2,17 @@ import { expect, test } from "bun:test";
import { parseHTML } from "linkedom";
import { prepareNoteImageContent } from "./note-image-content";
+test("removes the whole unified image panel from exports without removing the image", () => {
+ const { document } = parseHTML('<div id="source"><figure class="edgeever-image-node"><img src="photo.png"><div class="edgeever-image-panel"><div class="edgeever-image-controls"><button>Small</button></div><div class="edgeever-image-resource-actions"><div data-edgeever-resource-menu><button>Download</button></div></div></div></figure></div>');
+ const source = document.querySelector("#source");
+ const clone = source.cloneNode(true);
+ prepareNoteImageContent(clone);
+ expect(clone.querySelector(".edgeever-image-panel")).toBeNull();
+ expect(clone.querySelector("[data-edgeever-resource-menu]")).toBeNull();
+ expect(clone.querySelector("img").getAttribute("src")).toBe("photo.png");
+ expect(source.querySelector(".edgeever-image-panel")).not.toBeNull();
+});
+
test("reflows wide labelled tables without dropping values or changing the source", () => {
const { document } = parseHTML(`<div id="source"><div class="tableWrapper" style="width:1800px;overflow:auto"><table style="min-width:1800px"><colgroup><col width="300"></colgroup><tbody><tr>${[1,2,3,4,5,6].map(n => `<th>Field ${n}</th>`).join("")}</tr><tr>${[1,2,3,4,5,6].map(n => `<td style="width:300px"><p><strong>Value ${n}</strong></p></td>`).join("")}</tr></tbody></table></div></div>`);
const source = document.querySelector("#source");
diff --git a/packages/shared/src/note-image-content.ts b/packages/shared/src/note-image-content.ts
index b3353f44..45af78df 100644
--- a/packages/shared/src/note-image-content.ts
+++ b/packages/shared/src/note-image-content.ts
@@ -2,7 +2,7 @@ import { parseImageWidth } from "./image-display";
/** Prepare an export-only clone; never pass the live editor DOM here. */
export const prepareNoteImageContent = (root: HTMLElement): void => {
- root.querySelectorAll("button, .edgeever-image-controls, .edgeever-code-copy-button, .edgeever-image-size-controls, .edgeever-native-gallery-toolbar, .column-resize-handle").forEach(element => element.remove());
+ root.querySelectorAll("button, .edgeever-image-panel, .edgeever-image-controls, .edgeever-code-copy-button, .edgeever-image-size-controls, .edgeever-native-gallery-toolbar, .column-resize-handle").forEach(element => element.remove());
root.querySelectorAll(".edgeever-native-gallery-content").forEach(content => content.replaceWith(...Array.from(content.childNodes)));
const releaseDimensions = (element: HTMLElement) => {
for (const property of ["width", "min-width", "max-width", "height", "min-height", "max-height", "overflow", "overflow-x", "overflow-y"]) element.style.removeProperty(property);
diff --git a/tests/e2e/image-alignment.spec.ts b/tests/e2e/image-alignment.spec.ts
index 8ff89498..bb311d4e 100644
--- a/tests/e2e/image-alignment.spec.ts
+++ b/tests/e2e/image-alignment.spec.ts
@@ -52,10 +52,20 @@ test("positions individual images and preserves alignment through resize, undo,
await expect(rich.locator(".edgeever-image-controls")).toHaveCount(0);
await expectPosition(first, "left");
await selectImage(first);
+ const panel = first.locator(".edgeever-image-panel");
+ await expect(panel.locator("[data-edgeever-resource-menu]")).toHaveCount(1);
+ await expect(panel.getByRole("button", { name: "Download", exact: true })).toBeVisible();
+ await expect(panel.getByRole("button", { name: "Copy", exact: true })).toBeVisible();
+ await expect(panel.getByRole("button", { name: "Delete", exact: true })).toBeVisible();
+ await rich.press("Escape");
+ await expect(panel).toHaveCount(0);
+ await first.locator("img").click({ button: "right" });
+ await expect(panel).toBeVisible();
await first.getByRole("button", { name: "Center image", exact: true }).click();
await expectPosition(first, "center");
await first.getByRole("button", { name: "Small", exact: true }).click();
await expect(first).toHaveAttribute("data-width", "35");
+ await expect(panel.getByRole("button", { name: "Download", exact: true })).toBeVisible();
await expectPosition(first, "center");
// Starting a drag must not resize the image; moving the handle changes its