Skip to content

AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.

fix: render WeChat images without referrer

tianma-if3a6b3e2a675b
diff --git a/apps/mobile/src/components/LocalTiptapEditor.tsx b/apps/mobile/src/components/LocalTiptapEditor.tsx
index d533938a..aea2ff77 100644
--- a/apps/mobile/src/components/LocalTiptapEditor.tsx
+++ b/apps/mobile/src/components/LocalTiptapEditor.tsx
@@ -9,7 +9,7 @@ import { TableKit } from "@tiptap/extension-table";
import { EditorContent, useEditor, useEditorState } from "@tiptap/react";
import StarterKit from "@tiptap/starter-kit";
import * as Clipboard from "expo-clipboard";
-import type { TiptapDoc } from "@edgeever/shared";
+import { getImageReferrerPolicy, type TiptapDoc } from "@edgeever/shared";
import {
DEFAULT_IMAGE_WIDTH_PERCENT,
IMAGE_WIDTH_PRESETS,
@@ -974,6 +974,10 @@ const createProtectedImageExtension = (
preview.alt = "";
const previewSource = String(node.attrs.title ?? "");
if (previewSource) {
+ const previewReferrerPolicy = getImageReferrerPolicy(previewSource);
+ if (previewReferrerPolicy) {
+ preview.referrerPolicy = previewReferrerPolicy;
+ }
preview.src = previewSource;
}
@@ -1010,6 +1014,10 @@ const createProtectedImageExtension = (
activeRequestId: number
) => {
const preload = document.createElement("img");
+ const preloadReferrerPolicy = getImageReferrerPolicy(displaySource);
+ if (preloadReferrerPolicy) {
+ preload.referrerPolicy = preloadReferrerPolicy;
+ }
preload.onload = () => {
if (activeRequestId !== requestId) {
return;
@@ -1109,6 +1117,12 @@ const createProtectedImageExtension = (
const alt = String(attributes.alt ?? "");
const title = String(attributes.title ?? "");
image.alt = alt;
+ const referrerPolicy = getImageReferrerPolicy(source);
+ if (referrerPolicy) {
+ image.referrerPolicy = referrerPolicy;
+ } else {
+ image.removeAttribute("referrerpolicy");
+ }
if (title) {
image.title = title;
} else {
diff --git a/apps/web/src/components/EditorPane.tsx b/apps/web/src/components/EditorPane.tsx
index e3e7b59a..efef4619 100644
--- a/apps/web/src/components/EditorPane.tsx
+++ b/apps/web/src/components/EditorPane.tsx
@@ -5,6 +5,7 @@ import { Plugin, PluginKey } from "@tiptap/pm/state";
import { Decoration, DecorationSet } from "@tiptap/pm/view";
import StarterKit from "@tiptap/starter-kit";
import Image from "@tiptap/extension-image";
+import { mergeAttributes } from "@tiptap/core";
import Placeholder from "@tiptap/extension-placeholder";
import { TableKit } from "@tiptap/extension-table";
import { useTranslation } from "react-i18next";
@@ -86,6 +87,7 @@ import {
type MemoEditSession,
type TiptapDoc,
createMemoLinkHref,
+ getImageReferrerPolicy,
parseMemoLinkHref,
} from "@edgeever/shared";
import {
@@ -375,7 +377,13 @@ const ResizableImageNodeView = ({ editor, node, selected, updateAttributes }: No
style={{ width: `${width}%` }}
data-width={width}
>
- <img src={src} alt={alt} title={title || undefined} draggable={false} />
+ <img
+ src={src}
+ alt={alt}
+ title={title || undefined}
+ draggable={false}
+ referrerPolicy={getImageReferrerPolicy(src)}
+ />
{editable && selected && (
<div className="edgeever-image-controls" contentEditable={false}>
<div className="edgeever-image-presets" aria-label={t("editor.imageScale")}>
@@ -424,6 +432,17 @@ const ResizableImage = Image.extend({
addNodeView() {
return ReactNodeViewRenderer(ResizableImageNodeView);
},
+ renderHTML({ HTMLAttributes }) {
+ const referrerPolicy = getImageReferrerPolicy(HTMLAttributes.src);
+ return [
+ "img",
+ mergeAttributes(
+ this.options.HTMLAttributes,
+ HTMLAttributes,
+ referrerPolicy ? { referrerpolicy: referrerPolicy } : {},
+ ),
+ ];
+ },
});
const syncStatusToSaveState = (status: "pending" | "syncing" | "conflict" | "error") => {
diff --git a/apps/web/src/components/MobileStandaloneTiptapEditor.tsx b/apps/web/src/components/MobileStandaloneTiptapEditor.tsx
index 903f261b..c04c2d30 100644
--- a/apps/web/src/components/MobileStandaloneTiptapEditor.tsx
+++ b/apps/web/src/components/MobileStandaloneTiptapEditor.tsx
@@ -3,9 +3,10 @@ import { useTranslation } from "react-i18next";
import { EditorContent, useEditor } from "@tiptap/react";
import StarterKit from "@tiptap/starter-kit";
import Image from "@tiptap/extension-image";
+import { mergeAttributes } from "@tiptap/core";
import Placeholder from "@tiptap/extension-placeholder";
import { TableKit } from "@tiptap/extension-table";
-import { createExcerpt, docToMarkdown, docToText, emptyDoc, type MemoDetail, type MemoEditSession, type Notebook, type TiptapDoc } from "@edgeever/shared";
+import { createExcerpt, docToMarkdown, docToText, emptyDoc, getImageReferrerPolicy, type MemoDetail, type MemoEditSession, type Notebook, type TiptapDoc } from "@edgeever/shared";
import { getMobileEditorInputAttributes, getMobileEditorPlaceholder } from "@edgeever/shared/mobile-editor";
import {
MobileEditorFallback,
@@ -41,6 +42,20 @@ import { getMemoUpdateQueueId, isMemoUpdateAlreadyApplied, queueMemoUpdate, shou
import { EdgeEverCodeBlock, codeBlockLowlight } from "@/lib/code-block";
import { ThemeBlock } from "./ThemeBlock";
+const ProtectedExternalImage = Image.extend({
+ renderHTML({ HTMLAttributes }) {
+ const referrerPolicy = getImageReferrerPolicy(HTMLAttributes.src);
+ return [
+ "img",
+ mergeAttributes(
+ this.options.HTMLAttributes,
+ HTMLAttributes,
+ referrerPolicy ? { referrerpolicy: referrerPolicy } : {},
+ ),
+ ];
+ },
+});
+
type ListNotebooksResponse = {
notebooks: Notebook[];
};
@@ -173,7 +188,7 @@ export const MobileStandaloneTiptapEditor = ({
StarterKit.configure({ codeBlock: false }),
EdgeEverCodeBlock.configure({ lowlight: codeBlockLowlight, defaultLanguage: "plaintext" }),
ThemeBlock,
- Image.configure({
+ ProtectedExternalImage.configure({
allowBase64: false,
inline: false,
}),
diff --git a/apps/web/src/components/PublicSharePage.tsx b/apps/web/src/components/PublicSharePage.tsx
index 78f44be9..0fbdd48c 100644
--- a/apps/web/src/components/PublicSharePage.tsx
+++ b/apps/web/src/components/PublicSharePage.tsx
@@ -12,6 +12,7 @@ import { api } from "@/lib/api";
import { EdgeEverCodeBlock, codeBlockLowlight } from "@/lib/code-block";
import {
parseImageWidth,
+ getImageReferrerPolicy,
resolveMemoContentDoc,
rewriteMemoResourcesForShare,
type PublicMemoShare,
@@ -31,6 +32,17 @@ const SharedImage = Image.extend({
},
};
},
+ renderHTML({ HTMLAttributes }) {
+ const referrerPolicy = getImageReferrerPolicy(HTMLAttributes.src);
+ return [
+ "img",
+ mergeAttributes(
+ this.options.HTMLAttributes,
+ HTMLAttributes,
+ referrerPolicy ? { referrerpolicy: referrerPolicy } : {},
+ ),
+ ];
+ },
});
const SharedThemeBlock = Node.create({
diff --git a/packages/shared/src/image-referrer.test.mjs b/packages/shared/src/image-referrer.test.mjs
new file mode 100644
index 00000000..7bacb39b
--- /dev/null
+++ b/packages/shared/src/image-referrer.test.mjs
@@ -0,0 +1,19 @@
+import { describe, expect, test } from "bun:test";
+import { getImageReferrerPolicy } from "./image-referrer.ts";
+
+describe("getImageReferrerPolicy", () => {
+ test("suppresses the referrer only for exact WeChat image hosts", () => {
+ expect(getImageReferrerPolicy("https://mmbiz.qpic.cn/sz_mmbiz_jpg/example/640")).toBe("no-referrer");
+ expect(getImageReferrerPolicy("https://mmbiz.qlogo.cn/example/0")).toBe("no-referrer");
+ expect(getImageReferrerPolicy("https://MMBIZ.QPIC.CN/example.jpg")).toBe("no-referrer");
+ });
+
+ test("keeps the default policy for unrelated and deceptive hosts", () => {
+ expect(getImageReferrerPolicy("https://images.example.com/photo.jpg")).toBeUndefined();
+ expect(getImageReferrerPolicy("https://mmbiz.qpic.cn.evil.example/photo.jpg")).toBeUndefined();
+ expect(getImageReferrerPolicy("https://evil-mmbiz.qpic.cn/photo.jpg")).toBeUndefined();
+ expect(getImageReferrerPolicy("/api/v1/resources/example/blob")).toBeUndefined();
+ expect(getImageReferrerPolicy("data:image/png;base64,AAAA")).toBeUndefined();
+ expect(getImageReferrerPolicy("not a URL")).toBeUndefined();
+ });
+});
diff --git a/packages/shared/src/image-referrer.ts b/packages/shared/src/image-referrer.ts
new file mode 100644
index 00000000..45d6c305
--- /dev/null
+++ b/packages/shared/src/image-referrer.ts
@@ -0,0 +1,21 @@
+const WECHAT_IMAGE_HOSTS = new Set([
+ "mmbiz.qpic.cn",
+ "mmbiz.qlogo.cn",
+]);
+
+export const getImageReferrerPolicy = (source: unknown): "no-referrer" | undefined => {
+ if (typeof source !== "string" || !source.trim()) {
+ return undefined;
+ }
+
+ try {
+ const url = new URL(source);
+ if ((url.protocol === "http:" || url.protocol === "https:") && WECHAT_IMAGE_HOSTS.has(url.hostname.toLowerCase())) {
+ return "no-referrer";
+ }
+ } catch {
+ // Relative, data, and malformed sources keep the browser's default policy.
+ }
+
+ return undefined;
+};
diff --git a/packages/shared/src/index.ts b/packages/shared/src/index.ts
index c73a8d0f..f2c2d54f 100644
--- a/packages/shared/src/index.ts
+++ b/packages/shared/src/index.ts
@@ -2,6 +2,7 @@ export * from "./content";
export * from "./backup";
export * from "./github-feedback";
export * from "./image-display";
+export * from "./image-referrer";
export * from "./memo-safety";
export * from "./memo-content-style";
export * from "./note-links";