AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.
HTML ai-agentcloudflarecloudflare-d1cloudflare-r2cloudflare-workersdockerelectronevernoteevernote-alternativeknowledge-basemcpnote-takingobsidian-alternativeoffline-firstpersonal-knowledge-basepwaself-hostedsqlitetiptapweb-clipper
refactor(diagram): remove redundant fit action
tianma-if3d101f9072a8
diff --git a/apps/web/src/components/DiagramEditorPane.test.mjs b/apps/web/src/components/DiagramEditorPane.test.mjsindex bf694f3f..7a5a7032 100644--- a/apps/web/src/components/DiagramEditorPane.test.mjs+++ b/apps/web/src/components/DiagramEditorPane.test.mjs@@ -90,6 +90,13 @@ describe("diagram editor canvas surface", () => {expect(toolbarSource).not.toContain('<Button size="icon" variant="ghost" aria-label={t("diagram.autoLayout")}');});+ test("keeps viewport fitting internal instead of exposing a redundant toolbar action", () => {+ expect(toolbarSource).not.toContain("onFit");+ expect(toolbarSource).not.toContain('t("diagram.fit")');+ expect(source).not.toContain("onFit={() =>");+ expect(source).toContain("fitDiagramContent(graph, document, containerRef.current, 40, layout.viewport);");+ });+test("delegates every diagram kind to one shared toolbar shell", () => {expect(source).toContain("<DiagramToolbar");expect(source).toContain("leading={!readOnly ? (");diff --git a/apps/web/src/components/DiagramEditorPane.tsx b/apps/web/src/components/DiagramEditorPane.tsxindex eec985f3..c6f81064 100644--- a/apps/web/src/components/DiagramEditorPane.tsx+++ b/apps/web/src/components/DiagramEditorPane.tsx@@ -2264,10 +2264,6 @@ export const DiagramEditorPane = ({onAutoLayout={applyAutoLayout}onDeleteSelection={removeSelected}onExport={exportDiagram}- onFit={() => {- const graph = graphRef.current;- if (graph) fitDiagramContent(graph, document, containerRef.current);- }}onRedo={() => runHistoryAction("redo")}onThemeChange={applyTheme}onUndo={() => runHistoryAction("undo")}diff --git a/apps/web/src/components/DiagramToolbar.tsx b/apps/web/src/components/DiagramToolbar.tsxindex 58a071f1..edf8fee8 100644--- a/apps/web/src/components/DiagramToolbar.tsx+++ b/apps/web/src/components/DiagramToolbar.tsx@@ -5,7 +5,6 @@ import {Download,FileCode2,FileImage,- Maximize2,Redo2,Trash2,Undo2,@@ -35,7 +34,6 @@ type DiagramToolbarProps = {onAutoLayout: () => void;onDeleteSelection: () => void;onExport: (format: "png" | "svg") => void;- onFit: () => void;onRedo: () => void;onThemeChange: (theme: DiagramTheme) => void;onUndo: () => void;@@ -74,7 +72,6 @@ export const DiagramToolbar = ({onAutoLayout,onDeleteSelection,onExport,- onFit,onRedo,onThemeChange,onUndo,@@ -105,7 +102,6 @@ export const DiagramToolbar = ({<ToolbarDivider /><Tooltip><TooltipTrigger asChild><Button size="icon" variant="ghost" aria-label={t("diagram.zoomOut")} onClick={onZoomOut}><ZoomOut className="h-4 w-4" /></Button></TooltipTrigger><TooltipContent>{t("diagram.zoomOut")}</TooltipContent></Tooltip><Tooltip><TooltipTrigger asChild><Button size="icon" variant="ghost" aria-label={t("diagram.zoomIn")} onClick={onZoomIn}><ZoomIn className="h-4 w-4" /></Button></TooltipTrigger><TooltipContent>{t("diagram.zoomIn")}</TooltipContent></Tooltip>- <Tooltip><TooltipTrigger asChild><Button size="icon" variant="ghost" aria-label={t("diagram.fit")} onClick={onFit}><Maximize2 className="h-4 w-4" /></Button></TooltipTrigger><TooltipContent>{t("diagram.fit")}</TooltipContent></Tooltip><Select value={theme} disabled={readOnly} onValueChange={(value) => onThemeChange(value as DiagramTheme)}><SelectTrigger className="h-8 w-[8.5rem] gap-2" aria-label={t("diagram.theme")}><SelectValue />