Skip to content

AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.

test: keep a window object when test globals had none

tianma-if6189a3ec5631
diff --git a/apps/web/src/lib/ai-selection-menu-preference.test.mjs b/apps/web/src/lib/ai-selection-menu-preference.test.mjs
index 6ab769ee..78fdb151 100644
--- a/apps/web/src/lib/ai-selection-menu-preference.test.mjs
+++ b/apps/web/src/lib/ai-selection-menu-preference.test.mjs
@@ -9,8 +9,7 @@ import {
const originalWindow = globalThis.window;
afterEach(() => {
- if (originalWindow === undefined) delete globalThis.window;
- else globalThis.window = originalWindow;
+ if (originalWindow !== undefined) globalThis.window = originalWindow;
});
const installWindow = () => {
diff --git a/apps/web/src/lib/ai-space-shortcut-preference.test.mjs b/apps/web/src/lib/ai-space-shortcut-preference.test.mjs
index f0555510..656ecd5f 100644
--- a/apps/web/src/lib/ai-space-shortcut-preference.test.mjs
+++ b/apps/web/src/lib/ai-space-shortcut-preference.test.mjs
@@ -9,8 +9,7 @@ import {
const originalWindow = globalThis.window;
afterEach(() => {
- if (originalWindow === undefined) delete globalThis.window;
- else globalThis.window = originalWindow;
+ if (originalWindow !== undefined) globalThis.window = originalWindow;
});
const installWindow = () => {
diff --git a/apps/web/src/lib/app-helpers.test.mjs b/apps/web/src/lib/app-helpers.test.mjs
index 35a072bd..3bc0b3a6 100644
--- a/apps/web/src/lib/app-helpers.test.mjs
+++ b/apps/web/src/lib/app-helpers.test.mjs
@@ -61,8 +61,7 @@ const installLocalStorage = (initialValue = null) => {
};
afterEach(() => {
- if (originalWindow === undefined) delete globalThis.window;
- else globalThis.window = originalWindow;
+ if (originalWindow !== undefined) globalThis.window = originalWindow;
});
describe("search shortcut scope", () => {
diff --git a/apps/web/src/lib/desktop-renderer-ready.test.mjs b/apps/web/src/lib/desktop-renderer-ready.test.mjs
index f46672d3..1e4b999d 100644
--- a/apps/web/src/lib/desktop-renderer-ready.test.mjs
+++ b/apps/web/src/lib/desktop-renderer-ready.test.mjs
@@ -5,8 +5,7 @@ const originalWindow = globalThis.window;
const originalDocument = globalThis.document;
afterEach(() => {
- if (originalWindow === undefined) delete globalThis.window;
- else globalThis.window = originalWindow;
+ if (originalWindow !== undefined) globalThis.window = originalWindow;
if (originalDocument === undefined) delete globalThis.document;
else globalThis.document = originalDocument;
});
diff --git a/apps/web/src/lib/desktop-sync.test.mjs b/apps/web/src/lib/desktop-sync.test.mjs
index 78f04139..5fb9b342 100644
--- a/apps/web/src/lib/desktop-sync.test.mjs
+++ b/apps/web/src/lib/desktop-sync.test.mjs
@@ -38,8 +38,7 @@ describe("desktop staged resource sync", () => {
release();
expect(events.filter((event) => event === "edgeever:sync-queue-changed")).toHaveLength(1);
} finally {
- if (originalWindow === undefined) delete globalThis.window;
- else globalThis.window = originalWindow;
+ if (originalWindow !== undefined) globalThis.window = originalWindow;
}
});
diff --git a/apps/web/src/lib/desktop-workspace-restore.test.mjs b/apps/web/src/lib/desktop-workspace-restore.test.mjs
index 721a884a..eed59cab 100644
--- a/apps/web/src/lib/desktop-workspace-restore.test.mjs
+++ b/apps/web/src/lib/desktop-workspace-restore.test.mjs
@@ -46,8 +46,7 @@ describe("desktop workspace restore", () => {
try {
expect(shouldRestoreDesktopWorkspace()).toBe(true);
} finally {
- if (previous === undefined) delete globalThis.window;
- else globalThis.window = previous;
+ if (previous !== undefined) globalThis.window = previous;
}
});
});
diff --git a/apps/web/src/lib/repository.test.mjs b/apps/web/src/lib/repository.test.mjs
index 59d46eaa..0bee6cb4 100644
--- a/apps/web/src/lib/repository.test.mjs
+++ b/apps/web/src/lib/repository.test.mjs
@@ -16,8 +16,7 @@ const installTestWindow = ({ hostname = "localhost" } = {}) => {
location: { hostname, href: `http://${hostname}/` },
});
return () => {
- if (previousWindow === undefined) delete globalThis.window;
- else globalThis.window = previousWindow;
+ if (previousWindow !== undefined) globalThis.window = previousWindow;
};
};
diff --git a/apps/web/src/lib/restore-test-global.mjs b/apps/web/src/lib/restore-test-global.mjs
index 78d75f4b..53b5416f 100644
--- a/apps/web/src/lib/restore-test-global.mjs
+++ b/apps/web/src/lib/restore-test-global.mjs
@@ -2,6 +2,14 @@ const restoreUnconditionally = Symbol("restore-unconditionally");
export const restoreTestGlobal = (key, original, installed = restoreUnconditionally) => {
if (installed !== restoreUnconditionally && globalThis[key] !== installed) return;
- if (original === undefined) delete globalThis[key];
- else globalThis[key] = original;
+ if (original !== undefined) {
+ globalThis[key] = original;
+ return;
+ }
+ // Linux Bun provides document without a window binding. Assigning
+ // undefined shadows it, and deleting it makes ProseMirror throw
+ // `window is not defined` while reading MutationObserver. Keep the
+ // stub object when there was no previous window.
+ if (key === "window") return;
+ delete globalThis[key];
};
diff --git a/apps/web/src/lib/restore-test-global.test.mjs b/apps/web/src/lib/restore-test-global.test.mjs
index f383ac6e..97cfb39f 100644
--- a/apps/web/src/lib/restore-test-global.test.mjs
+++ b/apps/web/src/lib/restore-test-global.test.mjs
@@ -1,13 +1,15 @@
import { expect, test } from "bun:test";
import { restoreTestGlobal } from "./restore-test-global.mjs";
-test("restoreTestGlobal deletes a missing global instead of shadowing it with undefined", () => {
+test("restoreTestGlobal keeps a window object when nothing was there before", () => {
const descriptor = Object.getOwnPropertyDescriptor(globalThis, "window");
delete globalThis.window;
- globalThis.window = { localStorage: {} };
- restoreTestGlobal("window", undefined, globalThis.window);
- expect(Object.hasOwn(globalThis, "window")).toBe(false);
+ const stub = { localStorage: {} };
+ globalThis.window = stub;
+ restoreTestGlobal("window", undefined, stub);
+ expect(globalThis.window).toBe(stub);
if (descriptor) Object.defineProperty(globalThis, "window", descriptor);
+ else delete globalThis.window;
});
test("restoreTestGlobal leaves a global that another file replaced", () => {
diff --git a/packages/shared/src/ai-assistant.test.mjs b/packages/shared/src/ai-assistant.test.mjs
index 06e0ea25..05f7ab67 100644
--- a/packages/shared/src/ai-assistant.test.mjs
+++ b/packages/shared/src/ai-assistant.test.mjs
@@ -21,8 +21,7 @@ const originalWindow = globalThis.window;
const originalLocalStorage = Object.getOwnPropertyDescriptor(globalThis, "localStorage");
afterEach(() => {
- if (originalWindow === undefined) delete globalThis.window;
- else globalThis.window = originalWindow;
+ if (originalWindow !== undefined) globalThis.window = originalWindow;
if (originalLocalStorage) {
Object.defineProperty(globalThis, "localStorage", originalLocalStorage);
} else {