AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.
HTML ai-agentcloudflarecloudflare-d1cloudflare-r2cloudflare-workersdockerelectronevernoteevernote-alternativeknowledge-basemcpnote-takingobsidian-alternativeoffline-firstpersonal-knowledge-basepwaself-hostedsqlitetiptapweb-clipper
fix(web): stabilize flowchart quick creation
tianma-if664b6e4c0106
diff --git a/apps/web/src/components/DiagramEditorPane.test.mjs b/apps/web/src/components/DiagramEditorPane.test.mjsindex d5bb92b7..e813993c 100644--- a/apps/web/src/components/DiagramEditorPane.test.mjs+++ b/apps/web/src/components/DiagramEditorPane.test.mjs@@ -54,7 +54,8 @@ describe("diagram editor canvas surface", () => {test("autosaves diagram changes without a persistent save button", () => {expect(source).toContain("EDITOR_LOCAL_SAVE_DELAY_MS");expect(source).toContain("window.setTimeout(() => saveRef.current(), EDITOR_LOCAL_SAVE_DELAY_MS)");- expect(source).toContain("[dirty, dirtyVersion, editSessionReady, readOnly, saveFailed, saving]");+ expect(source).toContain("nodeEditor !== null");+ expect(source).toContain("[dirty, dirtyVersion, editSessionReady, nodeEditor, readOnly, saveFailed, saving]");expect(source).toContain("!readOnly && saveFailed");expect(source).toContain('t("diagram.retrySave")');expect(source).not.toContain('<Save className="h-4 w-4" />');@@ -77,6 +78,15 @@ describe("diagram editor canvas surface", () => {test("exposes flowchart-only connection handles with safe connection rules", () => {expect(source).toContain('kind === "flowchart" ? { ports:');+ expect(source).toContain("const FLOW_PORT_HIT_RADIUS = 14");+ expect(source).toContain("const FLOW_PORT_DOT_RADIUS = 7");+ expect(source).toContain('selector: "hitArea"');+ expect(source).toContain('className: "edgeever-flow-port-hit-area"');+ expect(source).toContain('className: "edgeever-flow-port-dot"');+ expect(source).toContain('pointerEvents: "all"');+ expect(source).toContain('pointerEvents: "none"');+ expect(globalStyles).toContain('[data-diagram-kind="flowchart"] .x6-widget-selection-box-node');+ expect(globalStyles).toContain("pointer-events: none !important");expect(source).toContain('allowPort: document.kind === "flowchart"');expect(source).toContain('allowBlank: document.kind === "flowchart"');expect(source).toContain("allowNode: false");@@ -87,7 +97,8 @@ describe("diagram editor canvas surface", () => {});test("shows connection handles only on selected flowchart nodes", () => {- expect(globalStyles).toContain('.x6-node.edgeever-flow-node-active .x6-port-body');+ expect(globalStyles).toContain('.x6-node.edgeever-flow-node-active .edgeever-flow-port-dot');+ expect(globalStyles).toContain('.x6-port-body:hover .edgeever-flow-port-dot');expect(globalStyles).not.toContain('.x6-node.x6-node-selected .x6-port-body');expect(source).toContain('graph.on("node:selected"');expect(source).toContain('setFlowNodePortsActive(graph, node, true)');@@ -95,6 +106,7 @@ describe("diagram editor canvas surface", () => {expect(source).toContain('setFlowNodePortsActive(graph, node, false)');expect(source).toContain('port.style.setProperty("opacity", active ? "1" : "0", "important")');expect(source).toContain('port.style.setProperty("pointer-events", active ? "auto" : "none", "important")');+ expect(source).toContain('port.querySelector<SVGElement>(".edgeever-flow-port-dot") ?? port');expect(source).toContain('setOnlyFlowNodePortsActive(graph, node)');expect(source).toContain('graph.on("blank:click"');expect(source).toContain('setOnlyFlowNodePortsActive(graph);');@@ -107,6 +119,9 @@ describe("diagram editor canvas surface", () => {test("turns a connection dropped on blank canvas into a connected-node picker", () => {expect(source).toContain('graph.on("edge:connected"');expect(source).toContain('role="dialog"');+ expect(source).toContain("const FLOW_QUICK_CREATE_WIDTH = 330");+ expect(source).toContain('w-[330px] max-w-[calc(100%-24px)]');+ expect(source).toContain('min-w-0 flex-col gap-1 whitespace-nowrap px-2 text-xs');expect(source).toContain('t("diagram.quickCreateTitle")');expect(source).toContain('createConnectedFlowNode("process")');expect(source).toContain('createConnectedFlowNode("decision")');diff --git a/apps/web/src/components/DiagramEditorPane.tsx b/apps/web/src/components/DiagramEditorPane.tsxindex 740449f9..80a7c478 100644--- a/apps/web/src/components/DiagramEditorPane.tsx+++ b/apps/web/src/components/DiagramEditorPane.tsx@@ -116,6 +116,10 @@ type NodeEditorState = {};const FLOW_ACTIVE_NODE_CLASS = "edgeever-flow-node-active";+const FLOW_PORT_HIT_RADIUS = 14;+const FLOW_PORT_DOT_RADIUS = 7;+const FLOW_QUICK_CREATE_WIDTH = 330;+const FLOW_QUICK_CREATE_HEIGHT = 132;const createId = (prefix: string) => `${prefix}-${crypto.randomUUID()}`;const oppositeFlowPort = (port?: FlowPort): FlowPort | undefined => port ? ({top: "bottom",@@ -139,16 +143,17 @@ const setFlowNodePortsActive = (graph: Graph, node: Node, active: boolean) => {view.container.querySelectorAll<SVGElement>(".x6-port-body").forEach((port) => {port.style.setProperty("opacity", active ? "1" : "0", "important");port.style.setProperty("pointer-events", active ? "auto" : "none", "important");+ const dot = port.querySelector<SVGElement>(".edgeever-flow-port-dot") ?? port;if (active) {- port.style.setProperty("fill", "var(--brand-green)", "important");- port.style.setProperty("stroke", "var(--workspace-editor)", "important");- port.style.setProperty("stroke-width", "2px", "important");- port.style.setProperty("filter", "drop-shadow(0 1px 3px rgb(var(--brand-green-rgb) / 0.3))");+ dot.style.setProperty("fill", "var(--brand-green)", "important");+ dot.style.setProperty("stroke", "var(--workspace-editor)", "important");+ dot.style.setProperty("stroke-width", "2px", "important");+ dot.style.setProperty("filter", "drop-shadow(0 1px 3px rgb(var(--brand-green-rgb) / 0.3))");} else {- port.style.removeProperty("fill");- port.style.removeProperty("stroke");- port.style.removeProperty("stroke-width");- port.style.removeProperty("filter");+ dot.style.removeProperty("fill");+ dot.style.removeProperty("stroke");+ dot.style.removeProperty("stroke-width");+ dot.style.removeProperty("filter");}});return true;@@ -241,6 +246,33 @@ const nodeAttrs = (};};+const flowPortGroup = (+ position: FlowPort,+ palette: ReturnType<typeof resolveDiagramPalette>,+) => ({+ position,+ markup: [+ { tagName: "circle", selector: "hitArea", className: "edgeever-flow-port-hit-area" },+ { tagName: "circle", selector: "circle", className: "edgeever-flow-port-dot" },+ ],+ attrs: {+ hitArea: {+ r: FLOW_PORT_HIT_RADIUS,+ magnet: true,+ fill: "transparent",+ stroke: "transparent",+ pointerEvents: "all",+ },+ circle: {+ r: FLOW_PORT_DOT_RADIUS,+ stroke: palette.topicStroke,+ fill: palette.canvas,+ strokeWidth: 2,+ pointerEvents: "none",+ },+ },+});+const nodeMetadata = (node: DiagramDocument["nodes"][number],theme: DiagramTheme,@@ -268,10 +300,10 @@ const nodeMetadata = (},...(kind === "flowchart" ? { ports: {groups: {- top: { position: "top", attrs: { circle: { r: 7, magnet: true, stroke: palette.topicStroke, fill: palette.canvas, strokeWidth: 2 } } },- right: { position: "right", attrs: { circle: { r: 7, magnet: true, stroke: palette.topicStroke, fill: palette.canvas, strokeWidth: 2 } } },- bottom: { position: "bottom", attrs: { circle: { r: 7, magnet: true, stroke: palette.topicStroke, fill: palette.canvas, strokeWidth: 2 } } },- left: { position: "left", attrs: { circle: { r: 7, magnet: true, stroke: palette.topicStroke, fill: palette.canvas, strokeWidth: 2 } } },+ top: flowPortGroup("top", palette),+ right: flowPortGroup("right", palette),+ bottom: flowPortGroup("bottom", palette),+ left: flowPortGroup("left", palette),},items: ["top", "right", "bottom", "left"].map((group) => ({ id: group, group })),} } : {}),@@ -706,8 +738,6 @@ export const DiagramEditorPane = ({) => {if (!containerRef.current) return;const overlayPoint = graph.localToGraph(point);- const popupWidth = 246;- const popupHeight = 132;const nextQuickCreate: FlowQuickCreateState = {draftEdgeId: edge.id,restoreHistory,@@ -715,8 +745,8 @@ export const DiagramEditorPane = ({sourcePort,x: point.x,y: point.y,- left: Math.max(12, Math.min(overlayPoint.x + 12, containerRef.current.clientWidth - popupWidth - 12)),- top: Math.max(12, Math.min(overlayPoint.y + 12, containerRef.current.clientHeight - popupHeight - 12)),+ left: Math.max(12, Math.min(overlayPoint.x + 12, containerRef.current.clientWidth - FLOW_QUICK_CREATE_WIDTH - 12)),+ top: Math.max(12, Math.min(overlayPoint.y + 12, containerRef.current.clientHeight - FLOW_QUICK_CREATE_HEIGHT - 12)),};flowQuickCreateRef.current = nextQuickCreate;setFlowQuickCreate(nextQuickCreate);@@ -1279,10 +1309,10 @@ export const DiagramEditorPane = ({saveRef.current = () => { void save(); };useEffect(() => {- if (readOnly || !dirty || saving || !editSessionReady || saveFailed) return;+ if (readOnly || !dirty || nodeEditor !== null || saving || !editSessionReady || saveFailed) return;const timer = window.setTimeout(() => saveRef.current(), EDITOR_LOCAL_SAVE_DELAY_MS);return () => window.clearTimeout(timer);- }, [dirty, dirtyVersion, editSessionReady, readOnly, saveFailed, saving]);+ }, [dirty, dirtyVersion, editSessionReady, nodeEditor, readOnly, saveFailed, saving]);const handleCopyMemoId = async () => {if (isLocalMemoId(memo.id)) return;@@ -1548,7 +1578,7 @@ export const DiagramEditorPane = ({<div ref={containerRef} className="edgeever-diagram-canvas absolute inset-0 touch-none outline-none" data-diagram-appearance={resolvedTheme} data-diagram-kind={document.kind} data-diagram-theme={theme} tabIndex={0} aria-label={t("diagram.canvas", { type: kindLabel })} />{flowQuickCreate ? (<div- className="absolute z-30 w-[246px] rounded-xl border border-slate-200 bg-white p-2 shadow-xl"+ className="absolute z-30 w-[330px] max-w-[calc(100%-24px)] rounded-xl border border-slate-200 bg-white p-2 shadow-xl"style={{ left: flowQuickCreate.left, top: flowQuickCreate.top }}role="dialog"aria-label={t("diagram.quickCreateTitle")}@@ -1566,25 +1596,25 @@ export const DiagramEditorPane = ({}}}>- <div className="px-1.5 pb-1.5 text-xs font-medium text-slate-500">{t("diagram.quickCreateTitle")}</div>+ <div className="whitespace-nowrap px-1.5 pb-1.5 text-xs font-medium text-slate-500">{t("diagram.quickCreateTitle")}</div><div className="grid grid-cols-3 gap-1">- <Button autoFocus className="relative h-16 flex-col gap-1 text-xs" variant="ghost" aria-label={t("diagram.addStep")} onClick={() => createConnectedFlowNode("process")}>+ <Button autoFocus className="relative h-16 min-w-0 flex-col gap-1 whitespace-nowrap px-2 text-xs" variant="ghost" aria-label={t("diagram.addStep")} onClick={() => createConnectedFlowNode("process")}><kbd className="absolute right-1.5 top-1 text-[10px] font-normal text-slate-400">1</kbd><Box className="h-6 w-6" />{t("diagram.addStep")}</Button>- <Button className="relative h-16 flex-col gap-1 text-xs" variant="ghost" aria-label={t("diagram.addDecision")} onClick={() => createConnectedFlowNode("decision")}>+ <Button className="relative h-16 min-w-0 flex-col gap-1 whitespace-nowrap px-2 text-xs" variant="ghost" aria-label={t("diagram.addDecision")} onClick={() => createConnectedFlowNode("decision")}><kbd className="absolute right-1.5 top-1 text-[10px] font-normal text-slate-400">2</kbd><Diamond className="h-6 w-6" />{t("diagram.addDecision")}</Button>- <Button className="relative h-16 flex-col gap-1 text-xs" variant="ghost" aria-label={t("diagram.addTerminator")} onClick={() => createConnectedFlowNode("terminator")}>+ <Button className="relative h-16 min-w-0 flex-col gap-1 whitespace-nowrap px-2 text-xs" variant="ghost" aria-label={t("diagram.addTerminator")} onClick={() => createConnectedFlowNode("terminator")}><kbd className="absolute right-1.5 top-1 text-[10px] font-normal text-slate-400">3</kbd><Circle className="h-6 w-6" />{t("diagram.addTerminator")}</Button></div>- <div className="px-1.5 pt-1 text-[11px] text-slate-400">{t("diagram.quickCreateShortcuts")}</div>+ <div className="whitespace-nowrap px-1.5 pt-1 text-[11px] text-slate-400">{t("diagram.quickCreateShortcuts")}</div></div>) : null}{nodeEditor ? (diff --git a/apps/web/src/styles/globals.css b/apps/web/src/styles/globals.cssindex f7b21314..b5951f6f 100644--- a/apps/web/src/styles/globals.css+++ b/apps/web/src/styles/globals.css@@ -499,6 +499,10 @@ html[data-edgeever-extension-theme] .edgeever-memo-divider {box-shadow: 0 2px 10px rgb(104 214 176 / 0.22) !important;}+.edgeever-diagram-canvas[data-diagram-kind="flowchart"] .x6-widget-selection-box-node {+ pointer-events: none !important;+}+.edgeever-diagram-canvas .x6-port-body {opacity: 0;transition: opacity 120ms ease, filter 120ms ease;@@ -509,19 +513,30 @@ html[data-edgeever-extension-theme] .edgeever-memo-divider {pointer-events: none;}-.edgeever-diagram-canvas[data-diagram-kind="flowchart"] .x6-node.edgeever-flow-node-active .x6-port-body {+.edgeever-diagram-canvas[data-diagram-kind="flowchart"] .edgeever-flow-port-hit-area {+ fill: transparent;+ stroke: transparent;+ pointer-events: all;+}++.edgeever-diagram-canvas[data-diagram-kind="flowchart"] .edgeever-flow-port-dot {+ pointer-events: none;+ transform-box: fill-box;+ transform-origin: center;+ transition: filter 120ms ease, transform 120ms ease;+}++.edgeever-diagram-canvas[data-diagram-kind="flowchart"] .x6-node.edgeever-flow-node-active .edgeever-flow-port-dot {fill: var(--brand-green) !important;stroke: var(--workspace-editor) !important;stroke-width: 2px !important;filter: drop-shadow(0 1px 3px rgb(var(--brand-green-rgb) / 0.3));- opacity: 1;- pointer-events: auto;}-.edgeever-diagram-canvas[data-diagram-kind="flowchart"] .x6-port-body:hover,-.edgeever-diagram-canvas[data-diagram-kind="flowchart"] .x6-available-magnet {+.edgeever-diagram-canvas[data-diagram-kind="flowchart"] .x6-port-body:hover .edgeever-flow-port-dot,+.edgeever-diagram-canvas[data-diagram-kind="flowchart"] .x6-available-magnet + .edgeever-flow-port-dot {filter: drop-shadow(0 1px 3px rgb(var(--brand-green-rgb) / 0.28));- opacity: 1;+ transform: scale(1.12);}/* Curated reading themes should feel like part of the note canvas in dark