Skip to content

AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.

fix(web): keep table geometry stable across editor themes

tianma-if727430a7479e
diff --git a/apps/web/src/styles/editor-themes/base.css b/apps/web/src/styles/editor-themes/base.css
index 8d88a311..d668f170 100644
--- a/apps/web/src/styles/editor-themes/base.css
+++ b/apps/web/src/styles/editor-themes/base.css
@@ -85,6 +85,7 @@
color: var(--editor-theme-code-text);
}
+/* Table geometry (padding, line-height, column widths) lives in globals.css. */
.edgeever-editor[data-editor-theme]:not([data-editor-theme="default"]) .ProseMirror th {
background: var(--editor-theme-soft);
diff --git a/apps/web/src/styles/editor-themes/modern-mint.css b/apps/web/src/styles/editor-themes/modern-mint.css
index d6315f1f..f7d171ca 100644
--- a/apps/web/src/styles/editor-themes/modern-mint.css
+++ b/apps/web/src/styles/editor-themes/modern-mint.css
@@ -124,13 +124,6 @@
background: var(--editor-theme-soft);
color: var(--editor-theme-heading);
font-weight: 600;
- border: 1px solid var(--editor-theme-border);
- padding: 12px 16px;
-}
-
-.edgeever-editor[data-editor-theme="modern-mint"]:not([data-editor-theme="default"]) .ProseMirror td {
- border: 1px solid var(--editor-theme-border);
- padding: 12px 16px;
}
.edgeever-editor[data-editor-theme="modern-mint"]:not([data-editor-theme="default"]) .ProseMirror .edgeever-theme-block {
diff --git a/apps/web/src/styles/editor-themes/wechat-green.css b/apps/web/src/styles/editor-themes/wechat-green.css
index 1910eb06..8029e43a 100644
--- a/apps/web/src/styles/editor-themes/wechat-green.css
+++ b/apps/web/src/styles/editor-themes/wechat-green.css
@@ -132,13 +132,6 @@
background: var(--editor-theme-soft);
color: var(--editor-theme-heading);
font-weight: 600;
- border: 1px solid var(--editor-theme-border);
- padding: 12px 16px;
-}
-
-.edgeever-editor[data-editor-theme="wechat-green"]:not([data-editor-theme="default"]) .ProseMirror td {
- border: 1px solid var(--editor-theme-border);
- padding: 12px 16px;
}
.edgeever-editor[data-editor-theme="wechat-green"]:not([data-editor-theme="default"]) .ProseMirror .edgeever-theme-block {
diff --git a/apps/web/src/styles/editor-typography.test.mjs b/apps/web/src/styles/editor-typography.test.mjs
index 0b844130..144231d0 100644
--- a/apps/web/src/styles/editor-typography.test.mjs
+++ b/apps/web/src/styles/editor-typography.test.mjs
@@ -106,4 +106,27 @@ describe("editor typography contract", () => {
}
});
+ test("does not let preset themes override table geometry", () => {
+ const geometryPattern =
+ /(?<![\w-])(?:padding|min-width|max-width|min-height|max-height|line-height|table-layout|width|height)(?:-[a-z]+)?\s*:/;
+
+ for (const filename of ["base.css", ...PRESET_THEME_FILES]) {
+ const source = readStyle(`./editor-themes/${filename}`);
+ const tableRules = [
+ declarationsForSelector(source, ".ProseMirror table"),
+ declarationsForSelector(source, ".ProseMirror .tableWrapper"),
+ declarationsForSelector(source, ".ProseMirror th"),
+ declarationsForSelector(source, ".ProseMirror td"),
+ declarationsForSelector(source, ".ProseMirror th p"),
+ declarationsForSelector(source, ".ProseMirror td p"),
+ declarationsForSelector(source, ".ProseMirror col"),
+ declarationsForSelector(source, ".ProseMirror tr"),
+ ].join("\n");
+
+ expect(tableRules).not.toMatch(geometryPattern);
+ expect(tableRules).not.toMatch(/--mobile-table-column-width\s*:/);
+ expect(tableRules).not.toMatch(/\bborder\s*:/);
+ }
+ });
+
});
diff --git a/apps/web/src/styles/globals.css b/apps/web/src/styles/globals.css
index 922e644e..4c9ccc4f 100644
--- a/apps/web/src/styles/globals.css
+++ b/apps/web/src/styles/globals.css
@@ -2031,6 +2031,7 @@ textarea {
white-space: normal;
overflow-wrap: anywhere;
word-break: break-word;
+ letter-spacing: normal;
line-height: 1.45;
transition: background-color 120ms ease;
}
@@ -2092,8 +2093,12 @@ textarea {
.ProseMirror th p,
.ProseMirror td p,
.markdown-content th p,
-.markdown-content td p {
+.markdown-content td p,
+.edgeever-editor[data-editor-theme]:not([data-editor-theme="default"]) .ProseMirror :is(th, td) p,
+.edgeever-editor[data-paper-theme]:not([data-editor-theme="default"]) .ProseMirror :is(th, td) p {
margin: 0;
+ letter-spacing: inherit;
+ line-height: inherit;
}
.ProseMirror .selectedCell::after {
diff --git a/apps/web/src/styles/mobile-markdown-editor.css b/apps/web/src/styles/mobile-markdown-editor.css
index c660814d..51ba9928 100644
--- a/apps/web/src/styles/mobile-markdown-editor.css
+++ b/apps/web/src/styles/mobile-markdown-editor.css
@@ -910,6 +910,8 @@ html.dark .edgeever-mobile-tiptap-content a:hover {
.edgeever-mobile-tiptap-content th p,
.edgeever-mobile-tiptap-content td p {
margin: 0;
+ letter-spacing: inherit;
+ line-height: inherit;
}
.edgeever-mobile-tiptap-content .selectedCell::after {