Skip to content

AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.

fix(web): hide link hint in click mode

tianma-if8422cd0751e3
diff --git a/apps/web/src/components/EditorPane.tsx b/apps/web/src/components/EditorPane.tsx
index 047629af..b1013347 100644
--- a/apps/web/src/components/EditorPane.tsx
+++ b/apps/web/src/components/EditorPane.tsx
@@ -4161,9 +4161,7 @@ const RichEditorPane = ({
{noteLinkHintPosition && (
<NoteLinkInteractionHint
- label={editorLinkOpenMode === "modifier"
- ? t("noteLinkPicker.openHint", { modifier: noteLinkModifier })
- : t("noteLinkPicker.clickOpenHint", { modifier: noteLinkModifier })}
+ label={t("noteLinkPicker.openHint", { modifier: noteLinkModifier })}
position={noteLinkHintPosition}
/>
)}
diff --git a/apps/web/src/lib/editor-link-click.test.mjs b/apps/web/src/lib/editor-link-click.test.mjs
index bed01baf..1a213fd8 100644
--- a/apps/web/src/lib/editor-link-click.test.mjs
+++ b/apps/web/src/lib/editor-link-click.test.mjs
@@ -22,10 +22,10 @@ describe("editor link click policy", () => {
expect(resolveStoredEditorLinkOpenMode("modifier")).toBe("modifier");
});
- test("shows a hover hint for both desktop link opening modes", () => {
- expect(shouldShowEditorLinkOpenHint(true, false, "click")).toBe(true);
+ test("shows a hover hint only when desktop editing requires a modifier", () => {
+ expect(shouldShowEditorLinkOpenHint(true, false, "click")).toBe(false);
expect(shouldShowEditorLinkOpenHint(true, false, "modifier")).toBe(true);
- expect(shouldShowEditorLinkOpenHint(true, true, "click")).toBe(false);
+ expect(shouldShowEditorLinkOpenHint(true, true, "modifier")).toBe(false);
expect(shouldShowEditorLinkOpenHint(false, false, "modifier")).toBe(false);
});
diff --git a/apps/web/src/lib/editor-link-click.ts b/apps/web/src/lib/editor-link-click.ts
index 90af7af1..e96ee304 100644
--- a/apps/web/src/lib/editor-link-click.ts
+++ b/apps/web/src/lib/editor-link-click.ts
@@ -21,7 +21,7 @@ export const shouldShowEditorLinkOpenHint = (
editable: boolean,
isMobileViewport: boolean,
mode: EditorLinkOpenMode
-): boolean => editable && !isMobileViewport && (mode === "click" || mode === "modifier");
+): boolean => editable && !isMobileViewport && mode === "modifier";
export const EDITOR_LINK_OPEN_MODE_STORAGE_KEY = "edgeever.editor.linkOpenMode";
diff --git a/packages/shared/src/i18n/en-US.ts b/packages/shared/src/i18n/en-US.ts
index 97e3f302..4b2fe7b9 100644
--- a/packages/shared/src/i18n/en-US.ts
+++ b/packages/shared/src/i18n/en-US.ts
@@ -1036,7 +1036,6 @@ export const enUS = {
loading: "Searching notes...",
close: "Close note picker",
openHint: "Hold {{modifier}} and click to open the link. To open links with a single click, turn this option off in Profile → General",
- clickOpenHint: "Click to open the link. To require {{modifier}} + click instead, turn this option on in Profile → General",
},
mobileNotebookPicker: {
title: "Switch notebook",
diff --git a/packages/shared/src/i18n/zh-CN.ts b/packages/shared/src/i18n/zh-CN.ts
index 49ed3e6e..f3a176fd 100644
--- a/packages/shared/src/i18n/zh-CN.ts
+++ b/packages/shared/src/i18n/zh-CN.ts
@@ -1036,7 +1036,6 @@ export const zhCN = {
loading: "正在搜索笔记...",
close: "关闭引用笔记",
openHint: "按住 {{modifier}} 点击链接即可打开。如需改为单击打开,请前往个人中心 → 常规设置关闭此选项",
- clickOpenHint: "单击即可打开链接。如需改为按住 {{modifier}} 再点击,请前往个人中心 → 常规设置开启此选项",
},
mobileNotebookPicker: {
title: "切换笔记本",