Skip to content

AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.

fix(ios): request review item relationship for cancellation guard

tianma-ifa9ca323392c9
diff --git a/scripts/xcode-cloud-control.py b/scripts/xcode-cloud-control.py
index 029075b4..969efb39 100644
--- a/scripts/xcode-cloud-control.py
+++ b/scripts/xcode-cloud-control.py
@@ -595,7 +595,10 @@ def command_cancel_review(args: argparse.Namespace, client: AppStoreConnect) ->
if len(matching) != 1:
raise SystemExit(f"Expected one waiting review submission for {args.version}; found {len(matching)}")
submission_id = matching[0]["id"]
- items = client.request("GET", f"/v1/reviewSubmissions/{submission_id}/items?limit=50").get("data") or []
+ items_query = urllib.parse.urlencode(
+ {"fields[reviewSubmissionItems]": "state,appStoreVersion", "include": "appStoreVersion", "limit": 50}
+ )
+ items = client.request("GET", f"/v1/reviewSubmissions/{submission_id}/items?{items_query}").get("data") or []
item_summary = [
{
"id": item.get("id"),
diff --git a/scripts/xcode-cloud-control.test.mjs b/scripts/xcode-cloud-control.test.mjs
index 267a98e5..103e96f4 100644
--- a/scripts/xcode-cloud-control.test.mjs
+++ b/scripts/xcode-cloud-control.test.mjs
@@ -89,6 +89,8 @@ class Client:
return {"data": [{"id": "submission", "relationships": {
"appStoreVersionForReview": {"data": {"id": "version"}}}}]}
if "/reviewSubmissions/submission/items" in path:
+ assert "fields%5BreviewSubmissionItems%5D=state%2CappStoreVersion" in path
+ assert "include=appStoreVersion" in path
return {"data": [{"relationships": {"appStoreVersion": {"data": {"id": "version"}}}}] * self.items}
raise AssertionError(path)
args = argparse.Namespace(version="1.98.0", current_build_id="old", replacement_build_id="new")