Skip to content

AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.

refactor(web): remove sequential note controls

tianma-ifaf9d3cfc5f55
diff --git a/apps/web/src/components/DiagramEditorPane.test.mjs b/apps/web/src/components/DiagramEditorPane.test.mjs
index 83447103..add64e3c 100644
--- a/apps/web/src/components/DiagramEditorPane.test.mjs
+++ b/apps/web/src/components/DiagramEditorPane.test.mjs
@@ -42,8 +42,8 @@ describe("diagram editor canvas surface", () => {
expect(source).toContain('<span className="hidden truncate text-xs text-slate-400 sm:inline">{updatedLabel}</span>');
expect(source).not.toContain('t("editor.updatedAt", { time: updatedLabel })');
expect(source).toContain("onToggleDesktopFocusMode");
- expect(source).toContain("onOpenPreviousMemo");
- expect(source).toContain("onOpenNextMemo");
+ expect(source).not.toContain("onOpenPreviousMemo");
+ expect(source).not.toContain("onOpenNextMemo");
expect(source).toContain("<MemoEditorHeaderActions");
expect(source).toContain("onSearch={openSearch}");
expect(source).toContain("<EditorNoteSearchBar");
diff --git a/apps/web/src/components/DiagramEditorPane.tsx b/apps/web/src/components/DiagramEditorPane.tsx
index 6c840046..af9bc494 100644
--- a/apps/web/src/components/DiagramEditorPane.tsx
+++ b/apps/web/src/components/DiagramEditorPane.tsx
@@ -14,7 +14,6 @@ import {
ChartNoAxesCombined,
ChevronDown,
ChevronLeft,
- ChevronRight,
Circle,
CircleAlert,
Cloud,
@@ -124,12 +123,8 @@ type DiagramEditorPaneProps = {
repository: EdgeEverRepository;
readOnly: boolean;
desktopFocusMode: boolean;
- hasNextMemo: boolean;
- hasPreviousMemo: boolean;
onBackToList: () => void;
onDeleted: (memoId: string) => Promise<void>;
- onOpenNextMemo: () => void;
- onOpenPreviousMemo: () => void;
onPermanentDeleted: (memoId: string) => Promise<void>;
onRestored: (memoId: string) => Promise<void>;
onSaved: (memo: MemoDetail) => Promise<void>;
@@ -1017,12 +1012,8 @@ export const DiagramEditorPane = ({
repository,
readOnly,
desktopFocusMode,
- hasNextMemo,
- hasPreviousMemo,
onBackToList,
onDeleted,
- onOpenNextMemo,
- onOpenPreviousMemo,
onPermanentDeleted,
onRestored,
onSaved,
@@ -2194,24 +2185,6 @@ export const DiagramEditorPane = ({
</TooltipTrigger>
<TooltipContent>{t("diagram.back")}</TooltipContent>
</Tooltip>
- <div className="hidden items-center gap-1 sm:flex lg:hidden">
- <Tooltip>
- <TooltipTrigger asChild>
- <Button size="icon" variant="ghost" aria-label={t("editor.previousMemo")} onClick={onOpenPreviousMemo} disabled={!hasPreviousMemo}>
- <ChevronLeft className="h-3.5 w-3.5" />
- </Button>
- </TooltipTrigger>
- <TooltipContent>{t("editor.previousMemo")}</TooltipContent>
- </Tooltip>
- <Tooltip>
- <TooltipTrigger asChild>
- <Button size="icon" variant="ghost" aria-label={t("editor.nextMemo")} onClick={onOpenNextMemo} disabled={!hasNextMemo}>
- <ChevronRight className="h-3.5 w-3.5" />
- </Button>
- </TooltipTrigger>
- <TooltipContent>{t("editor.nextMemo")}</TooltipContent>
- </Tooltip>
- </div>
<div className="hidden items-center gap-1 lg:flex">
<Tooltip>
<TooltipTrigger asChild>
@@ -2222,22 +2195,6 @@ export const DiagramEditorPane = ({
</TooltipTrigger>
<TooltipContent>{t(desktopFocusMode ? "editor.exitFocusMode" : "editor.focusMode")}</TooltipContent>
</Tooltip>
- <Tooltip>
- <TooltipTrigger asChild>
- <Button size="icon" variant="ghost" aria-label={t("editor.previousMemo")} onClick={onOpenPreviousMemo} disabled={!hasPreviousMemo}>
- <ChevronLeft className="h-4 w-4" />
- </Button>
- </TooltipTrigger>
- <TooltipContent>{t("editor.previousMemo")}</TooltipContent>
- </Tooltip>
- <Tooltip>
- <TooltipTrigger asChild>
- <Button size="icon" variant="ghost" aria-label={t("editor.nextMemo")} onClick={onOpenNextMemo} disabled={!hasNextMemo}>
- <ChevronRight className="h-4 w-4" />
- </Button>
- </TooltipTrigger>
- <TooltipContent>{t("editor.nextMemo")}</TooltipContent>
- </Tooltip>
</div>
<span className="hidden truncate text-xs text-slate-400 sm:inline">{updatedLabel}</span>
</div>
diff --git a/apps/web/src/components/EditorPane.tsx b/apps/web/src/components/EditorPane.tsx
index 7cb0cbe7..5a356c08 100644
--- a/apps/web/src/components/EditorPane.tsx
+++ b/apps/web/src/components/EditorPane.tsx
@@ -12,7 +12,6 @@ import * as m from "motion/react-m";
import "katex/dist/katex.min.css";
import {
ChevronLeft,
- ChevronRight,
ChevronDown,
History,
RotateCcw,
@@ -446,11 +445,7 @@ type EditorPaneProps = {
isLoading: boolean;
contentSearchQuery?: string;
imageCompressionEnabled: boolean;
- hasNextMemo: boolean;
- hasPreviousMemo: boolean;
onBackToList: () => void;
- onOpenNextMemo: () => void;
- onOpenPreviousMemo: () => void;
onSaved: (memo: MemoDetail) => Promise<void>;
onDeleted: (memoId: string) => Promise<void>;
onPermanentDeleted: (memoId: string) => Promise<void>;
@@ -522,11 +517,7 @@ const RichEditorPane = ({
isLoading,
contentSearchQuery = "",
imageCompressionEnabled,
- hasNextMemo,
- hasPreviousMemo,
onBackToList,
- onOpenNextMemo,
- onOpenPreviousMemo,
onSaved,
onDeleted,
onPermanentDeleted,
@@ -3824,40 +3815,6 @@ const RichEditorPane = ({
>
<ChevronLeft className="h-4 w-4" />
</Button>
- <div className="hidden items-center gap-1 sm:flex lg:hidden">
- <button
- className="flex h-8 w-8 items-center justify-center rounded-md text-slate-500 transition hover:bg-slate-50 hover:text-slate-900 disabled:opacity-30"
- type="button"
- title={t("editor.previousMemo")}
- aria-label={t("editor.previousMemo")}
- disabled={!hasPreviousMemo}
- onClick={onOpenPreviousMemo}
- >
- <ChevronLeft className="h-3.5 w-3.5" />
- </button>
- <button
- className="flex h-8 w-8 items-center justify-center rounded-md text-slate-500 transition hover:bg-slate-50 hover:text-slate-900 disabled:opacity-30"
- type="button"
- title={t("editor.nextMemo")}
- aria-label={t("editor.nextMemo")}
- disabled={!hasNextMemo}
- onClick={onOpenNextMemo}
- >
- <ChevronRight className="h-3.5 w-3.5" />
- </button>
- </div>
- <div className="hidden items-center gap-1 lg:flex">
- <IconTooltip label={t("editor.previousMemo")}>
- <Button size="icon" variant="ghost" aria-label={t("editor.previousMemo")} onClick={onOpenPreviousMemo} disabled={!hasPreviousMemo}>
- <ChevronLeft className="h-4 w-4" />
- </Button>
- </IconTooltip>
- <IconTooltip label={t("editor.nextMemo")}>
- <Button size="icon" variant="ghost" aria-label={t("editor.nextMemo")} onClick={onOpenNextMemo} disabled={!hasNextMemo}>
- <ChevronRight className="h-4 w-4" />
- </Button>
- </IconTooltip>
- </div>
<span className="hidden truncate text-xs text-slate-400 sm:inline">
{updatedLabel}
</span>
diff --git a/apps/web/src/components/MemoEditorHeaderActions.test.mjs b/apps/web/src/components/MemoEditorHeaderActions.test.mjs
index f8a26ebb..81582535 100644
--- a/apps/web/src/components/MemoEditorHeaderActions.test.mjs
+++ b/apps/web/src/components/MemoEditorHeaderActions.test.mjs
@@ -29,6 +29,13 @@ describe("shared memo editor header actions", () => {
expect(diagramSource).not.toContain("<WeChatIcon");
});
+ test("leaves sequential note navigation to the memo list", () => {
+ expect(editorSource).not.toContain("onOpenPreviousMemo");
+ expect(editorSource).not.toContain("onOpenNextMemo");
+ expect(diagramSource).not.toContain("onOpenPreviousMemo");
+ expect(diagramSource).not.toContain("onOpenNextMemo");
+ });
+
test("applies one shared compact density standard to both editors", () => {
expect(editorSource).toContain("MEMO_EDITOR_TOP_ROW_CLASS_NAME");
expect(diagramSource).toContain("MEMO_EDITOR_TOP_ROW_CLASS_NAME");
diff --git a/apps/web/src/components/WorkspaceApp.tsx b/apps/web/src/components/WorkspaceApp.tsx
index 2bdc649d..8cd283bc 100644
--- a/apps/web/src/components/WorkspaceApp.tsx
+++ b/apps/web/src/components/WorkspaceApp.tsx
@@ -3432,8 +3432,6 @@ export const WorkspaceApp = ({
repository={repository}
readOnly={memoView === "trash" || selectedMemo.isDeleted}
desktopFocusMode={desktopFocusModeActive}
- hasNextMemo={Boolean(nextMemoId)}
- hasPreviousMemo={Boolean(previousMemoId)}
onBackToList={() => {
clearPendingCreatedMemo();
setActivePane("memos");
@@ -3441,20 +3439,6 @@ export const WorkspaceApp = ({
onDeleted={async (memoId) => {
deleteMemoMutation.mutate({ memoId, permanent: false });
}}
- onOpenNextMemo={() => {
- if (nextMemoId) {
- clearPendingCreatedMemo();
- setCreatedMemoEditId(null);
- setSelectedMemoId(nextMemoId);
- }
- }}
- onOpenPreviousMemo={() => {
- if (previousMemoId) {
- clearPendingCreatedMemo();
- setCreatedMemoEditId(null);
- setSelectedMemoId(previousMemoId);
- }
- }}
onPermanentDeleted={async (memoId) => {
setMemoDeleteConfirmation({ kind: "single", memoIds: [memoId], permanent: true });
}}
@@ -3513,27 +3497,11 @@ export const WorkspaceApp = ({
}}
imageCompressionEnabled={imageCompressionEnabled}
selectionActionBar={memoSelectionActionBar}
- hasNextMemo={Boolean(nextMemoId)}
- hasPreviousMemo={Boolean(previousMemoId)}
onBackToList={() => {
applyMobileEditorReturnPreview(selectedMemo?.id ?? selectedMemoId);
clearPendingCreatedMemo();
setActivePane("memos");
}}
- onOpenNextMemo={() => {
- if (nextMemoId) {
- clearPendingCreatedMemo();
- setCreatedMemoEditId(null);
- setSelectedMemoId(nextMemoId);
- }
- }}
- onOpenPreviousMemo={() => {
- if (previousMemoId) {
- clearPendingCreatedMemo();
- setCreatedMemoEditId(null);
- setSelectedMemoId(previousMemoId);
- }
- }}
onSaved={async (memo) => {
await putLocalMemo(localDataScope, memo);
cacheMemoDetail(queryClient, memo, memoView);