AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.
HTML ai-agentcloudflarecloudflare-d1cloudflare-r2cloudflare-workersdockerelectronevernoteevernote-alternativeknowledge-basemcpnote-takingobsidian-alternativeoffline-firstpersonal-knowledge-basepwaself-hostedsqlitetiptapweb-clipper
fix(web): close tooltips when the pointer leaves the trigger (#674)
Thorsten Rufb2085e583eaa
diff --git a/apps/web/src/components/ui/tooltip.tsx b/apps/web/src/components/ui/tooltip.tsxindex d11cdcef..23bfdc8e 100644--- a/apps/web/src/components/ui/tooltip.tsx+++ b/apps/web/src/components/ui/tooltip.tsx@@ -2,8 +2,8 @@ import * as React from "react";import * as TooltipPrimitive from "@radix-ui/react-tooltip";import { cn } from "@/lib/utils";-const TooltipProvider = ({ delayDuration = 0, skipDelayDuration = 0, ...props }: React.ComponentProps<typeof TooltipPrimitive.Provider>) => (- <TooltipPrimitive.Provider delayDuration={delayDuration} skipDelayDuration={skipDelayDuration} {...props} />+const TooltipProvider = ({ delayDuration = 0, skipDelayDuration = 0, disableHoverableContent = true, ...props }: React.ComponentProps<typeof TooltipPrimitive.Provider>) => (+ <TooltipPrimitive.Provider delayDuration={delayDuration} skipDelayDuration={skipDelayDuration} disableHoverableContent={disableHoverableContent} {...props} />);const Tooltip = TooltipPrimitive.Root;const TooltipTrigger = TooltipPrimitive.Trigger;@@ -17,7 +17,7 @@ const TooltipContent = React.forwardRef<ref={ref}sideOffset={sideOffset}className={cn(- "z-50 overflow-hidden rounded-lg border border-[var(--tooltip-border)] bg-[var(--tooltip-bg)] px-2.5 py-1.5 text-xs leading-4 text-[var(--tooltip-fg)] shadow-[var(--tooltip-shadow)] animate-in fade-in-0 zoom-in-95 data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=closed]:zoom-out-95",+ "pointer-events-none z-50 overflow-hidden rounded-lg border border-[var(--tooltip-border)] bg-[var(--tooltip-bg)] px-2.5 py-1.5 text-xs leading-4 text-[var(--tooltip-fg)] shadow-[var(--tooltip-shadow)] animate-in fade-in-0 zoom-in-95 data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=closed]:zoom-out-95",className)}{...props}diff --git a/tests/e2e/tooltip-dismissal.spec.ts b/tests/e2e/tooltip-dismissal.spec.tsnew file mode 100644index 00000000..b9cd1d9e--- /dev/null+++ b/tests/e2e/tooltip-dismissal.spec.ts@@ -0,0 +1,35 @@+import { expect, test } from "@playwright/test";++test.beforeEach(async ({ page }) => {+ await page.addInitScript(() => localStorage.setItem("edgeever.locale.preference", "en-US"));+ await page.setViewportSize({ width: 1280, height: 900 });+ await page.goto("/");+});++test("dismisses a tooltip when the pointer moves from its trigger onto the hint", async ({ page }) => {+ const trigger = page.getByRole("button", { name: "Collapse notebook pane", exact: true });+ const hint = page.locator("[data-radix-popper-content-wrapper]").filter({+ has: page.getByRole("tooltip", { name: /Collapse notebook pane/ }),+ });+ await trigger.hover();+ await expect(hint).toBeVisible();+ const box = await hint.boundingBox();+ expect(box).not.toBeNull();+ await page.mouse.move(box!.x + box!.width / 2, box!.y + box!.height / 2, { steps: 8 });+ await expect(hint).toBeHidden({ timeout: 1500 });+});++test("keeps keyboard hints available and dismisses them on Escape or blur", async ({ page }) => {+ const trigger = page.getByRole("button", { name: "Collapse notebook pane", exact: true });+ const hint = page.getByRole("tooltip", { name: /Collapse notebook pane/ });+ await trigger.focus();+ await expect(hint).toBeAttached();+ await expect(trigger).toHaveAttribute("aria-describedby", await hint.getAttribute("id"));+ await page.keyboard.press("Escape");+ await expect(hint).not.toBeAttached();+ await page.keyboard.press("Tab");+ await trigger.focus();+ await expect(hint).toBeAttached();+ await page.keyboard.press("Tab");+ await expect(hint).not.toBeAttached();+});