Skip to content

AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.

fix web connectivity false negatives

tianma-ifb90583208408
diff --git a/apps/web/src/components/WorkspaceApp.tsx b/apps/web/src/components/WorkspaceApp.tsx
index 8a164572..a876008b 100644
--- a/apps/web/src/components/WorkspaceApp.tsx
+++ b/apps/web/src/components/WorkspaceApp.tsx
@@ -37,7 +37,7 @@ import {
type MobileEditorReturnPreview,
} from "@/lib/mobile-editor";
import { cn } from "@/lib/utils";
-import { isBrowserOffline, isBrowserOnline } from "@/lib/network-status";
+import { isBrowserOffline, isBrowserOnline, verifyBrowserConnectivity } from "@/lib/network-status";
import { createExcerpt, docToText, getNotebookDescendantIds, type Notebook, type AuthUser, type MemoSummary, type MemoDetail, type Resource, type MemoTemplate as SavedMemoTemplate } from "@edgeever/shared";
import { toggleMobileMemoSelection } from "@edgeever/shared/mobile-ui";
import type {
@@ -1363,8 +1363,10 @@ export const WorkspaceApp = ({
}, [isStandaloneRuntime, mobilePullToRefreshActive, refreshLatestMemos]);
useEffect(() => {
- const updateOnlineState = () => {
- const online = isBrowserOnline();
+ let active = true;
+ const updateOnlineState = async () => {
+ const online = await verifyBrowserConnectivity();
+ if (!active) return;
setIsOnline(online);
if (online) {
void runQueuedSync();
@@ -1373,9 +1375,10 @@ export const WorkspaceApp = ({
window.addEventListener("online", updateOnlineState);
window.addEventListener("offline", updateOnlineState);
- updateOnlineState();
+ void updateOnlineState();
return () => {
+ active = false;
window.removeEventListener("online", updateOnlineState);
window.removeEventListener("offline", updateOnlineState);
};
diff --git a/apps/web/src/lib/network-status.ts b/apps/web/src/lib/network-status.ts
index 0ec9ee61..6274ecc2 100644
--- a/apps/web/src/lib/network-status.ts
+++ b/apps/web/src/lib/network-status.ts
@@ -1,9 +1,36 @@
const LOOPBACK_HOSTNAMES = new Set(["localhost", "127.0.0.1", "::1"]);
+let browserConnectivityConfirmed = false;
const isLoopbackOrigin = () =>
typeof window !== "undefined" && LOOPBACK_HOSTNAMES.has(window.location.hostname);
export const isBrowserOffline = () =>
- typeof navigator !== "undefined" && navigator.onLine === false && !isLoopbackOrigin();
+ typeof navigator !== "undefined" &&
+ navigator.onLine === false &&
+ !isLoopbackOrigin() &&
+ !browserConnectivityConfirmed;
export const isBrowserOnline = () => !isBrowserOffline();
+
+export const verifyBrowserConnectivity = async () => {
+ if (typeof window === "undefined" || typeof navigator === "undefined") {
+ return true;
+ }
+
+ if (navigator.onLine || isLoopbackOrigin()) {
+ browserConnectivityConfirmed = true;
+ return true;
+ }
+
+ try {
+ await fetch(new URL("/api/v1/auth/session", window.location.origin), {
+ cache: "no-store",
+ credentials: "include",
+ });
+ browserConnectivityConfirmed = true;
+ return true;
+ } catch {
+ browserConnectivityConfirmed = false;
+ return false;
+ }
+};
diff --git a/apps/web/src/lib/repository.test.mjs b/apps/web/src/lib/repository.test.mjs
index 605266b6..62daa56a 100644
--- a/apps/web/src/lib/repository.test.mjs
+++ b/apps/web/src/lib/repository.test.mjs
@@ -22,9 +22,9 @@ afterEach(async () => {
});
describe("web repository offline boundaries", () => {
- test("falls back to the remote detail when the local database read is blocked", async () => {
+ test("uses the remote detail when the local database is blocked and navigator falsely reports offline", async () => {
const previousOnline = globalThis.navigator?.onLine;
- if (globalThis.navigator) Object.defineProperty(globalThis.navigator, "onLine", { configurable: true, value: true });
+ if (globalThis.navigator) Object.defineProperty(globalThis.navigator, "onLine", { configurable: true, value: false });
const scope = "https://demo.edgeever.org|user-1";
const remoteMemo = {
id: "memo-blocked",
diff --git a/apps/web/src/lib/repository.ts b/apps/web/src/lib/repository.ts
index 32dde9b8..bc289014 100644
--- a/apps/web/src/lib/repository.ts
+++ b/apps/web/src/lib/repository.ts
@@ -301,13 +301,6 @@ export const createWebRepository = (scope: string): EdgeEverRepository => {
async getMemo(memoId, includeDeleted = false) {
const localPromise = getLocalMemoWithoutBlocking(scope, memoId);
- if (isOffline()) {
- const local = await localPromise;
- const usableLocal = local && (includeDeleted || !local.isDeleted) ? local : null;
- if (usableLocal) return { memo: usableLocal };
- throw new Error("Memo is not available in the local mirror");
- }
-
const remotePromise = api.getMemo(memoId, { includeDeleted });
const firstResult = await Promise.race([
localPromise.then((local) => ({ source: "local" as const, local })),
diff --git a/apps/web/src/lib/sync-queue.ts b/apps/web/src/lib/sync-queue.ts
index 03ee971a..627f44eb 100644
--- a/apps/web/src/lib/sync-queue.ts
+++ b/apps/web/src/lib/sync-queue.ts
@@ -12,6 +12,7 @@ import {
type SyncQueueItem,
} from "@/lib/local-db";
import { getCachedLocalResourceBytes, removeCachedLocalResourceBytes } from "@/lib/local-resource-cache";
+import { isBrowserOffline } from "@/lib/network-status";
export type SyncQueueSummary = {
total: number;
@@ -253,7 +254,7 @@ const runQueuedChanges = async (options: {
conflicted: 0,
};
- if (typeof navigator !== "undefined" && !navigator.onLine) {
+ if (isBrowserOffline()) {
return result;
}
@@ -371,7 +372,7 @@ const updateClaimedQueueItem = (item: SyncQueueItem, patch: Partial<SyncQueueIte
});
export const shouldQueueMemoSaveError = (error: unknown) => {
- if (typeof navigator !== "undefined" && !navigator.onLine) {
+ if (isBrowserOffline()) {
return true;
}