Skip to content

AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.

fix(web): enter browser fullscreen with editor focus mode

tianma-ifc2d208cf6926
diff --git a/apps/web/src/components/WorkspaceApp.tsx b/apps/web/src/components/WorkspaceApp.tsx
index 7b7c3760..987907a8 100644
--- a/apps/web/src/components/WorkspaceApp.tsx
+++ b/apps/web/src/components/WorkspaceApp.tsx
@@ -87,6 +87,7 @@ import {
writeMemoSortPreference,
} from "@/lib/app-helpers";
import { useBrowserBackLayer } from "@/lib/app-hooks";
+import { createFocusFullscreen } from "@/lib/focus-fullscreen";
import { sortDesktopTitleMemoSummaries, updateMemoSummaryInLists } from "@/lib/memo-list-cache";
import {
cacheMemoDetail,
@@ -2792,11 +2793,29 @@ export const WorkspaceApp = ({
}
};
+ const focusFullscreenRef = useRef<ReturnType<typeof createFocusFullscreen> | null>(null);
+ useEffect(() => {
+ if (window.edgeeverDesktop?.isAvailable) return;
+ const fullscreen = createFocusFullscreen(document, () => {
+ runWorkspaceViewTransition(() => setDesktopFocusMode(false));
+ });
+ focusFullscreenRef.current = fullscreen;
+ return () => {
+ focusFullscreenRef.current = null;
+ fullscreen.dispose();
+ };
+ }, [setDesktopFocusMode]);
+
+ useEffect(() => {
+ if (!desktopFocusModeActive) focusFullscreenRef.current?.setEnabled(false);
+ }, [desktopFocusModeActive]);
+
const updateDesktopFocusMode = useCallback((enabled: boolean) => {
+ focusFullscreenRef.current?.setEnabled(enabled);
runWorkspaceViewTransition(() => {
setDesktopFocusMode(enabled);
});
- }, []);
+ }, [setDesktopFocusMode]);
const toggleDesktopFocusMode = useCallback(() => {
updateDesktopFocusMode(!desktopFocusModeActive);
diff --git a/apps/web/src/lib/focus-fullscreen.test.mjs b/apps/web/src/lib/focus-fullscreen.test.mjs
new file mode 100644
index 00000000..3ed94e79
--- /dev/null
+++ b/apps/web/src/lib/focus-fullscreen.test.mjs
@@ -0,0 +1,88 @@
+import { expect, test, mock } from "bun:test";
+import { createFocusFullscreen } from "./focus-fullscreen";
+
+const setup = () => {
+ const events = new EventTarget();
+ const doc = Object.assign(events, {
+ fullscreenEnabled: true,
+ fullscreenElement: null,
+ documentElement: {},
+ exitFullscreen: mock(async () => {
+ doc.fullscreenElement = null;
+ events.dispatchEvent(new Event("fullscreenchange"));
+ }),
+ });
+ doc.documentElement.requestFullscreen = mock(async () => {
+ doc.fullscreenElement = doc.documentElement;
+ events.dispatchEvent(new Event("fullscreenchange"));
+ });
+ const onExit = mock();
+ return { doc, onExit, control: createFocusFullscreen(doc, onExit) };
+};
+
+test("requests fullscreen during the gesture and exits with the focus control", async () => {
+ const { doc, control, onExit } = setup();
+ control.setEnabled(true);
+ expect(doc.documentElement.requestFullscreen).toHaveBeenCalledTimes(1);
+ await Promise.resolve();
+ control.setEnabled(false);
+ expect(doc.exitFullscreen).toHaveBeenCalledTimes(1);
+ expect(onExit).not.toHaveBeenCalled();
+ control.dispose();
+});
+
+test("browser Escape exits focus mode and repeated sessions remain usable", async () => {
+ const { doc, control, onExit } = setup();
+ control.setEnabled(true);
+ await Promise.resolve();
+ await doc.exitFullscreen();
+ expect(onExit).toHaveBeenCalledTimes(1);
+ control.setEnabled(true);
+ await Promise.resolve();
+ control.dispose();
+ expect(doc.fullscreenElement).toBeNull();
+});
+
+test("unsupported, rejected and synchronously failed requests retain focus fallback", async () => {
+ for (const failure of ["unsupported", "rejected", "thrown"]) {
+ const { doc, control, onExit } = setup();
+ if (failure === "unsupported") doc.fullscreenEnabled = false;
+ else doc.documentElement.requestFullscreen = mock(() => {
+ if (failure === "thrown") throw new Error("Denied");
+ return Promise.reject(new Error("Denied"));
+ });
+ control.setEnabled(true);
+ await Promise.resolve();
+ control.setEnabled(false);
+ expect(onExit).not.toHaveBeenCalled();
+ expect(doc.exitFullscreen).not.toHaveBeenCalled();
+ control.dispose();
+ }
+});
+
+test("leaves fullscreen opened by other controls alone", () => {
+ const { doc, control } = setup();
+ doc.fullscreenElement = doc.documentElement;
+ control.setEnabled(true);
+ control.setEnabled(false);
+ control.dispose();
+ expect(doc.documentElement.requestFullscreen).not.toHaveBeenCalled();
+ expect(doc.exitFullscreen).not.toHaveBeenCalled();
+});
+
+test("exits a pending request after focus mode closes or unmounts", async () => {
+ for (const dispose of [false, true]) {
+ const { doc, control, onExit } = setup();
+ let resolve;
+ doc.documentElement.requestFullscreen = () => new Promise((done) => { resolve = done; });
+ control.setEnabled(true);
+ if (dispose) control.dispose();
+ else control.setEnabled(false);
+ doc.fullscreenElement = doc.documentElement;
+ resolve();
+ await Promise.resolve();
+ expect(doc.exitFullscreen).toHaveBeenCalledTimes(1);
+ expect(onExit).not.toHaveBeenCalled();
+ control.dispose();
+ }
+});
diff --git a/apps/web/src/lib/focus-fullscreen.ts b/apps/web/src/lib/focus-fullscreen.ts
new file mode 100644
index 00000000..a1933f88
--- /dev/null
+++ b/apps/web/src/lib/focus-fullscreen.ts
@@ -0,0 +1,59 @@
+/** Own only the fullscreen session started by the focus-mode control. */
+export const createFocusFullscreen = (doc: Document, onExit: () => void) => {
+ let enabled = false;
+ let owned = false;
+ let pending = false;
+
+ const exit = () => {
+ if (!owned || pending) return;
+ owned = false;
+ if (doc.fullscreenElement === doc.documentElement) {
+ void doc.exitFullscreen().catch(() => undefined);
+ }
+ };
+ const onChange = () => {
+ if (owned && !doc.fullscreenElement && !pending) {
+ owned = false;
+ if (enabled) {
+ enabled = false;
+ onExit();
+ }
+ }
+ };
+ doc.addEventListener("fullscreenchange", onChange);
+
+ const setEnabled = (next: boolean) => {
+ enabled = next;
+ if (!next) {
+ exit();
+ return;
+ }
+ if (pending || doc.fullscreenElement || !doc.fullscreenEnabled || !doc.documentElement.requestFullscreen) return;
+ // Invoke synchronously in the click/shortcut event to retain user activation.
+ pending = true;
+ owned = true;
+ try {
+ void doc.documentElement.requestFullscreen().then(() => {
+ pending = false;
+ if (!enabled) exit();
+ else onChange();
+ }, (error: unknown) => {
+ pending = false;
+ owned = false;
+ console.warn("Browser fullscreen unavailable; keeping focus mode.", error);
+ });
+ } catch (error) {
+ pending = false;
+ owned = false;
+ console.warn("Browser fullscreen unavailable; keeping focus mode.", error);
+ }
+ };
+
+ return {
+ setEnabled,
+ dispose: () => {
+ doc.removeEventListener("fullscreenchange", onChange);
+ setEnabled(false);
+ },
+ };
+};