AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.
HTML ai-agentcloudflarecloudflare-d1cloudflare-r2cloudflare-workersdockerelectronevernoteevernote-alternativeknowledge-basemcpnote-takingobsidian-alternativeoffline-firstpersonal-knowledge-basepwaself-hostedsqlitetiptapweb-clipper
feat(android): support zooming fullscreen note images (#520)
tianma-ifc380268da8b0
diff --git a/apps/mobile/src/components/ZoomableImagePreview.tsx b/apps/mobile/src/components/ZoomableImagePreview.tsxnew file mode 100644index 00000000..b5793afc--- /dev/null+++ b/apps/mobile/src/components/ZoomableImagePreview.tsx@@ -0,0 +1,124 @@+import { useCallback, useEffect, useState, type ReactNode } from "react";+import { PixelRatio, StyleSheet, View } from "react-native";+import { Gesture, GestureDetector, GestureHandlerRootView } from "react-native-gesture-handler";+import Animated, { useAnimatedStyle, useSharedValue } from "react-native-reanimated";+import { clampImageTranslation, fitPreviewImage, previewResizeMultiplier, zoomImageTranslation, type ImageSize } from "../lib/mobile-image-zoom";++type Props = {+ accessibilityHint: string;+ accessibilityLabel: string;+ onLongPress: () => void;+ renderImage: (onDimensions: (size: ImageSize) => void, resizeMultiplier: number) => ReactNode;+};++export const ZoomableImagePreview = ({ accessibilityHint, accessibilityLabel, onLongPress, renderImage }: Props) => {+ const [viewport, setViewport] = useState<ImageSize>({ width: 0, height: 0 });+ const [image, setImage] = useState<ImageSize>({ width: 0, height: 0 });+ const onDimensions = useCallback((size: ImageSize) => {+ // Android reports decoded dimensions, which can change after requesting more detail.+ // Capture the aspect once so that this reload never resets an ongoing gesture.+ if (size.width > 0 && size.height > 0) {+ setImage((previous) => previous.width > 0 ? previous : size);+ }+ }, []);+ const fitted = fitPreviewImage(image, viewport);+ const scale = useSharedValue(1);+ const x = useSharedValue(0);+ const y = useSharedValue(0);+ const startScale = useSharedValue(1);+ const startX = useSharedValue(0);+ const startY = useSharedValue(0);+ const anchorX = useSharedValue(0);+ const anchorY = useSharedValue(0);+ const pinching = useSharedValue(false);+ const maxScale = 32;++ useEffect(() => {+ scale.value = 1;+ x.value = 0;+ y.value = 0;+ pinching.value = false;+ }, [viewport.width, viewport.height, image.width, image.height, scale, x, y, pinching]);++ const pinch = Gesture.Pinch()+ .onStart((event) => {+ pinching.value = true;+ startScale.value = scale.value;+ startX.value = x.value;+ startY.value = y.value;+ anchorX.value = event.focalX - viewport.width / 2;+ anchorY.value = event.focalY - viewport.height / 2;+ })+ .onUpdate((event) => {+ const next = Math.max(1, Math.min(maxScale, startScale.value * event.scale));+ x.value = clampImageTranslation(+ zoomImageTranslation(startX.value, anchorX.value, startScale.value, next) + event.focalX - viewport.width / 2 - anchorX.value,+ fitted.width, viewport.width, next,+ );+ y.value = clampImageTranslation(+ zoomImageTranslation(startY.value, anchorY.value, startScale.value, next) + event.focalY - viewport.height / 2 - anchorY.value,+ fitted.height, viewport.height, next,+ );+ scale.value = next;+ })+ .onFinalize(() => { pinching.value = false; });+ const pan = Gesture.Pan().minDistance(8)+ .onChange((event) => {+ if (pinching.value || event.numberOfPointers !== 1 || scale.value <= 1) return;+ x.value = clampImageTranslation(x.value + event.changeX, fitted.width, viewport.width, scale.value);+ y.value = clampImageTranslation(y.value + event.changeY, fitted.height, viewport.height, scale.value);+ });+ const doubleTap = Gesture.Tap().numberOfTaps(2).maxDistance(8)+ .onEnd((event, success) => {+ if (!success) return;+ const next = scale.value > 1 ? 1 : Math.min(3, maxScale);+ x.value = clampImageTranslation(zoomImageTranslation(x.value, event.x - viewport.width / 2, scale.value, next), fitted.width, viewport.width, next);+ y.value = clampImageTranslation(zoomImageTranslation(y.value, event.y - viewport.height / 2, scale.value, next), fitted.height, viewport.height, next);+ scale.value = next;+ });+ const longPress = Gesture.LongPress().minDuration(400).maxDistance(8).numberOfPointers(1)+ .runOnJS(true).onStart(onLongPress);+ const gesture = Gesture.Race(Gesture.Simultaneous(pinch, pan), doubleTap, longPress);+ const animatedStyle = useAnimatedStyle(() => ({+ transform: [{ translateX: x.value }, { translateY: y.value }, { scale: scale.value }],+ }));++ return (+ <GestureHandlerRootView style={styles.root}>+ <GestureDetector gesture={gesture}>+ <View+ accessible+ accessibilityHint={accessibilityHint}+ accessibilityLabel={accessibilityLabel}+ accessibilityRole="image"+ accessibilityActions={[{ name: "increment" }, { name: "decrement" }, { name: "longpress" }]}+ onAccessibilityAction={({ nativeEvent }) => {+ if (nativeEvent.actionName === "longpress") {+ onLongPress();+ return;+ }+ if (nativeEvent.actionName !== "increment" && nativeEvent.actionName !== "decrement") return;+ const next = nativeEvent.actionName === "increment"+ ? Math.min(maxScale, scale.value * 2) : Math.max(1, scale.value / 2);+ x.value = clampImageTranslation(x.value * next / scale.value, fitted.width, viewport.width, next);+ y.value = clampImageTranslation(y.value * next / scale.value, fitted.height, viewport.height, next);+ scale.value = next;+ }}+ onLayout={(event) => setViewport(event.nativeEvent.layout)}+ style={styles.viewport}+ >+ {viewport.width > 0 && viewport.height > 0 ? (+ <Animated.View style={[{ width: fitted.width, height: fitted.height }, animatedStyle]}>+ {renderImage(onDimensions, previewResizeMultiplier(fitted, viewport, PixelRatio.get()))}+ </Animated.View>+ ) : null}+ </View>+ </GestureDetector>+ </GestureHandlerRootView>+ );+};++const styles = StyleSheet.create({+ root: { flex: 1, width: "100%" },+ viewport: { flex: 1, alignItems: "center", justifyContent: "center", overflow: "hidden" },+});diff --git a/apps/mobile/src/lib/mobile-image-zoom.test.ts b/apps/mobile/src/lib/mobile-image-zoom.test.tsnew file mode 100644index 00000000..cdc8f4e0--- /dev/null+++ b/apps/mobile/src/lib/mobile-image-zoom.test.ts@@ -0,0 +1,35 @@+import { describe, expect, test } from "bun:test";+import { clampImageTranslation, fitPreviewImage, previewResizeMultiplier, zoomImageTranslation } from "./mobile-image-zoom";++describe("fullscreen image geometry", () => {+ const viewport = { width: 400, height: 800 };+ test("long images remain fully visible initially and can fill the width after zoom", () => {+ const fitted = fitPreviewImage({ width: 1000, height: 20000 }, viewport);+ expect(fitted).toEqual({ width: 40, height: 800 });+ expect(clampImageTranslation(100, fitted.width, viewport.width, 10)).toBe(0);+ expect(clampImageTranslation(5000, fitted.height, viewport.height, 10)).toBe(3600);+ });+ test("pan cannot expose empty space past any image edge", () => {+ expect(clampImageTranslation(999, 400, 400, 3)).toBe(400);+ expect(clampImageTranslation(-999, 400, 400, 3)).toBe(-400);+ expect(clampImageTranslation(100, 200, 800, 3)).toBe(0);+ expect(clampImageTranslation(400, 400, 400, 1)).toBe(0);+ });+ test("zoom preserves the image point beneath the fingers", () => {+ const translated = zoomImageTranslation(25, 100, 2, 5);+ expect((100 - translated) / 5).toBe((100 - 25) / 2);+ expect(zoomImageTranslation(translated, 100, 5, 2)).toBe(25);+ });+ test("decode requests aim for screen-width detail and cap pixel count and longest edge", () => {+ for (const fitted of [{ width: 400, height: 800 }, { width: 40, height: 800 }, { width: 400, height: 200 }]) {+ const multiplier = previewResizeMultiplier(fitted, viewport, 3);+ expect(Math.max(fitted.width, fitted.height) * 3 * multiplier).toBeLessThanOrEqual(8192);+ expect(fitted.width * fitted.height * 9 * multiplier ** 2).toBeLessThanOrEqual(8_000_001);+ expect(multiplier).toBeGreaterThanOrEqual(1);+ }+ });+ test("unknown dimensions are safe during image loading", () => {+ expect(fitPreviewImage({ width: 0, height: 0 }, viewport)).toEqual(viewport);+ expect(previewResizeMultiplier({ width: 0, height: 0 }, viewport, 3)).toBe(1);+ });+});diff --git a/apps/mobile/src/lib/mobile-image-zoom.ts b/apps/mobile/src/lib/mobile-image-zoom.tsnew file mode 100644index 00000000..56238c55--- /dev/null+++ b/apps/mobile/src/lib/mobile-image-zoom.ts@@ -0,0 +1,29 @@+export type ImageSize = { width: number; height: number };++export const fitPreviewImage = (image: ImageSize, viewport: ImageSize): ImageSize => {+ if (image.width <= 0 || image.height <= 0) return viewport;+ const ratio = Math.min(viewport.width / image.width, viewport.height / image.height);+ return { width: image.width * ratio, height: image.height * ratio };+};++export const clampImageTranslation = (value: number, imageLength: number, viewportLength: number, scale: number) => {+ "worklet";+ const limit = Math.max(0, (imageLength * scale - viewportLength) / 2);+ return Math.max(-limit, Math.min(limit, value));+};++export const zoomImageTranslation = (translation: number, focal: number, oldScale: number, newScale: number) => {+ "worklet";+ return focal - (focal - translation) * newScale / oldScale;+};++// Aim for readable screen-width detail, while limiting requested decode dimensions.+// Fresco may round sampling sizes; these are request limits, not a strict heap bound.+export const previewResizeMultiplier = (fitted: ImageSize, viewport: ImageSize, density: number) => {+ if (fitted.width <= 0 || fitted.height <= 0 || density <= 0) return 1;+ return Math.max(1, Math.min(+ viewport.width * 2 / fitted.width,+ 8192 / (Math.max(fitted.width, fitted.height) * density),+ Math.sqrt(8_000_000 / (fitted.width * fitted.height * density * density)),+ ));+};diff --git a/apps/mobile/src/screens/WorkspaceMemoDetail.tsx b/apps/mobile/src/screens/WorkspaceMemoDetail.tsxindex 8b5f25d8..2b9e129b 100644--- a/apps/mobile/src/screens/WorkspaceMemoDetail.tsx+++ b/apps/mobile/src/screens/WorkspaceMemoDetail.tsx@@ -19,6 +19,8 @@ import { Alert, Pressable, Text, TextInput } from "../components/LocalizedText";import LocalTiptapEditor, { type LocalTiptapEditorRef } from "../components/LocalTiptapEditor";import { MobileAiAssistantModal } from "../components/MobileAiAssistantModal";import { MobileResourceActions } from "../components/MobileResourceActions";+import { ZoomableImagePreview } from "../components/ZoomableImagePreview";+import type { ImageSize } from "../lib/mobile-image-zoom";import { SAFE_DOM_WEBVIEW_PROPS } from "../lib/mobile-dom";import { getNextMobileNoteSearchIndex } from "../lib/mobile-note-search";import { hasMobilePoster, hasMobileInfographic, hasMobileStructuredTable, hasMobileVisualDiagram, resolveMobileMemoViewerContent } from "../lib/mobile-diagram";@@ -238,6 +240,8 @@ const AuthenticatedResourceImage = ({href,loadResourceBlob,onLoadFailure,+ onDimensions,+ resizeMultiplier,resizeMode = "cover",session,style,@@ -247,6 +251,8 @@ const AuthenticatedResourceImage = ({href: string;loadResourceBlob?: ((resourceUrl: string) => Promise<Blob>) | null;onLoadFailure?: (failure: ProtectedResourceLoadFailure) => void;+ onDimensions?: (size: ImageSize) => void;+ resizeMultiplier?: number;resizeMode?: "center" | "contain" | "cover" | "repeat" | "stretch";session: SessionLike;style: StyleProp<ImageStyle>;@@ -306,6 +312,7 @@ const AuthenticatedResourceImage = ({}if (result.aspectRatio) {setAspectRatio(result.aspectRatio);+ onDimensions?.({ width: result.aspectRatio * 1000, height: 1000 });}setSvgXml(result.xml);});@@ -315,7 +322,7 @@ const AuthenticatedResourceImage = ({svgSourceKeyRef.current = "";}};- }, [svgSourceKey]);+ }, [svgSourceKey, onDimensions]);const loadSvgFallback = () => {if (svgRequestStartedRef.current || !displaySource) {@@ -329,6 +336,7 @@ const AuthenticatedResourceImage = ({}if (result.aspectRatio) {setAspectRatio(result.aspectRatio);+ onDimensions?.({ width: result.aspectRatio * 1000, height: 1000 });}setSvgXml(result.xml);});@@ -363,10 +371,13 @@ const AuthenticatedResourceImage = ({const { height, width } = event.nativeEvent.source;if (height > 0 && width > 0) {setAspectRatio(width / height);+ onDimensions?.({ width, height });}}}onError={loadSvgFallback}resizeMethod={Platform.OS === "android" ? "resize" : "auto"}+ // Supported by Android's native Image view; RN 0.86's TS interface omits it.+ {...(Platform.OS === "android" && resizeMultiplier ? { resizeMultiplier } : {})}resizeMode={resizeMode}source={displaySource}style={imageStyle}@@ -1763,11 +1774,10 @@ export const MemoDetailModal = ({<Modal animationType="fade" onRequestClose={() => setImagePreview(null)} transparent visible={Boolean(imagePreview)}><View style={resourceImageStyles.previewBackdrop}>{imagePreview ? (- <Pressable+ <ZoomableImagePreview+ key={imagePreview.source}accessibilityHint={resolvedLocale !== "zh-CN" ? "Long press for image actions" : "长按打开图片操作"}accessibilityLabel={imagePreview.alt || (resolvedLocale !== "zh-CN" ? "Image preview" : "图片预览")}- accessibilityRole="image"- delayLongPress={400}onLongPress={() => {// Long-press fullscreen preview → same resource sheet as ⋯ in the note.const target = getMobileImageTarget(imagePreview.source, imagePreview.alt);@@ -1775,18 +1785,20 @@ export const MemoDetailModal = ({setResourceTarget(target);}}}- style={resourceImageStyles.previewImagePressable}- >- <AuthenticatedResourceImage- alt={imagePreview.alt}- href={imagePreview.source}- loadResourceBlob={client?.getResourceBlob}- onLoadFailure={imageLoadFailureNotifier}- resizeMode="contain"- session={session}- style={resourceImageStyles.previewImage}- />- </Pressable>+ renderImage={(onDimensions, resizeMultiplier) => (+ <AuthenticatedResourceImage+ alt={imagePreview.alt}+ href={imagePreview.source}+ loadResourceBlob={client?.getResourceBlob}+ onLoadFailure={imageLoadFailureNotifier}+ onDimensions={onDimensions}+ resizeMultiplier={resizeMultiplier}+ resizeMode="contain"+ session={session}+ style={resourceImageStyles.previewImage}+ />+ )}+ />) : null}<PressableaccessibilityLabel={resolvedLocale !== "zh-CN" ? "Close image preview" : "关闭图片预览"}@@ -2220,11 +2232,6 @@ const resourceImageStyles = StyleSheet.create({height: "100%",width: "100%",},- previewImagePressable: {- flex: 1,- height: "100%",- width: "100%",- },previewPlaceholder: {alignItems: "center",justifyContent: "center",