AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.
HTML ai-agentcloudflarecloudflare-d1cloudflare-r2cloudflare-workersdockerelectronevernoteevernote-alternativeknowledge-basemcpnote-takingobsidian-alternativeoffline-firstpersonal-knowledge-basepwaself-hostedsqlitetiptapweb-clipper
feat: add AI selection menu preference
tianma-ifc72cfb419d10
diff --git a/apps/web/src/components/editor/useAiBubbleMenu.test.mjs b/apps/web/src/components/editor/useAiBubbleMenu.test.mjsnew file mode 100644index 00000000..d19e1954--- /dev/null+++ b/apps/web/src/components/editor/useAiBubbleMenu.test.mjs@@ -0,0 +1,22 @@+import { describe, expect, test } from "bun:test";+import { shouldShowAiBubbleMenu } from "./useAiBubbleMenu.ts";++const visibleState = {+ assistantOpen: false,+ editable: true,+ enabled: true,+ selectionEmpty: false,+};++describe("AI bubble menu visibility", () => {+ test("shows for a non-empty editable selection when enabled", () => {+ expect(shouldShowAiBubbleMenu(visibleState)).toBe(true);+ });++ test("stays hidden when disabled, read-only, empty, or already open", () => {+ expect(shouldShowAiBubbleMenu({ ...visibleState, enabled: false })).toBe(false);+ expect(shouldShowAiBubbleMenu({ ...visibleState, editable: false })).toBe(false);+ expect(shouldShowAiBubbleMenu({ ...visibleState, selectionEmpty: true })).toBe(false);+ expect(shouldShowAiBubbleMenu({ ...visibleState, assistantOpen: true })).toBe(false);+ });+});diff --git a/apps/web/src/components/editor/useAiBubbleMenu.ts b/apps/web/src/components/editor/useAiBubbleMenu.tsindex 494ac2a1..97d9be2a 100644--- a/apps/web/src/components/editor/useAiBubbleMenu.ts+++ b/apps/web/src/components/editor/useAiBubbleMenu.ts@@ -1,18 +1,59 @@-import { useCallback } from "react";+import { useCallback, useEffect, useState } from "react";import type { BubbleMenuProps } from "@tiptap/react/menus";+import {+ AI_SELECTION_MENU_CHANGED_EVENT,+ readAiSelectionMenuPreference,+} from "@/lib/ai-selection-menu-preference";type BubbleMenuShouldShow = NonNullable<BubbleMenuProps["shouldShow"]>;type BubbleMenuOptions = NonNullable<BubbleMenuProps["options"]>;const AI_BUBBLE_MENU_OPTIONS: BubbleMenuOptions = { placement: "top" };+export const shouldShowAiBubbleMenu = ({+ assistantOpen,+ editable,+ enabled,+ selectionEmpty,+}: {+ assistantOpen: boolean;+ editable: boolean;+ enabled: boolean;+ selectionEmpty: boolean;+}): boolean => enabled && editable && !selectionEmpty && !assistantOpen;+export const useAiBubbleMenu = (assistantOpen: boolean) => {+ const [enabled, setEnabled] = useState(readAiSelectionMenuPreference);++ useEffect(() => {+ const syncPreference = () => setEnabled(readAiSelectionMenuPreference());+ const handlePreferenceChanged = (event: Event) => {+ const detail = (event as CustomEvent<boolean>).detail;+ if (typeof detail === "boolean") {+ setEnabled(detail);+ return;+ }+ syncPreference();+ };+ window.addEventListener(AI_SELECTION_MENU_CHANGED_EVENT, handlePreferenceChanged);+ window.addEventListener("storage", syncPreference);+ return () => {+ window.removeEventListener(AI_SELECTION_MENU_CHANGED_EVENT, handlePreferenceChanged);+ window.removeEventListener("storage", syncPreference);+ };+ }, []);+// BubbleMenu dispatches an options-update transaction whenever these prop// references change. Keep them stable so the editor's transaction-driven// toolbar refresh cannot feed back into another BubbleMenu update.const shouldShow = useCallback<BubbleMenuShouldShow>(- ({ editor }) => editor.isEditable && !editor.state.selection.empty && !assistantOpen,- [assistantOpen],+ ({ editor }) => shouldShowAiBubbleMenu({+ assistantOpen,+ editable: editor.isEditable,+ enabled,+ selectionEmpty: editor.state.selection.empty,+ }),+ [assistantOpen, enabled],);return {diff --git a/apps/web/src/components/settings/PreferenceCard.tsx b/apps/web/src/components/settings/PreferenceCard.tsxindex 90260da1..1f70d351 100644--- a/apps/web/src/components/settings/PreferenceCard.tsx+++ b/apps/web/src/components/settings/PreferenceCard.tsx@@ -1,4 +1,4 @@-import { ChartNoAxesCombined, Image, Languages, MousePointerClick, Palette, RefreshCw } from "lucide-react";+import { ChartNoAxesCombined, Image, Languages, MousePointerClick, Palette, RefreshCw, Sparkles } from "lucide-react";import { useState, useEffect } from "react";import { useTranslation } from "react-i18next";import { writeSyncIntervalPreference, type ShortcutSettings, type SyncIntervalPreference } from "@/lib/app-helpers";@@ -8,6 +8,11 @@ import {writeEditorLinkOpenMode,type EditorLinkOpenMode,} from "@/lib/editor-link-click";+import {+ AI_SELECTION_MENU_CHANGED_EVENT,+ readAiSelectionMenuPreference,+ writeAiSelectionMenuPreference,+} from "@/lib/ai-selection-menu-preference";import { Button } from "@/components/ui/button";import { Card, CardContent, CardHeader, CardTitle } from "@/components/ui/card";import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from "@/components/ui/select";@@ -60,6 +65,7 @@ export const PreferenceCard = ({const [activeLocalePreference, setActiveLocalePreference] = useState<AppLocalePreference>(() => getAppLocalePreference());const [isMobile, setIsMobile] = useState(false);const [linkOpenMode, setLinkOpenMode] = useState<EditorLinkOpenMode>(() => getStoredEditorLinkOpenMode());+ const [aiSelectionMenuEnabled, setAiSelectionMenuEnabled] = useState(readAiSelectionMenuPreference);useEffect(() => {const mediaQuery = window.matchMedia("(max-width: 640px)");@@ -69,6 +75,24 @@ export const PreferenceCard = ({return () => mediaQuery.removeEventListener("change", handler);}, []);+ useEffect(() => {+ const syncPreference = () => setAiSelectionMenuEnabled(readAiSelectionMenuPreference());+ const onPreferenceChanged = (event: Event) => {+ const detail = (event as CustomEvent<boolean>).detail;+ if (typeof detail === "boolean") {+ setAiSelectionMenuEnabled(detail);+ return;+ }+ syncPreference();+ };+ window.addEventListener(AI_SELECTION_MENU_CHANGED_EVENT, onPreferenceChanged);+ window.addEventListener("storage", syncPreference);+ return () => {+ window.removeEventListener(AI_SELECTION_MENU_CHANGED_EVENT, onPreferenceChanged);+ window.removeEventListener("storage", syncPreference);+ };+ }, []);+useEffect(() => {const syncMode = () => setLinkOpenMode(getStoredEditorLinkOpenMode());const onPreferenceChanged = (event: Event) => {@@ -304,6 +328,26 @@ export const PreferenceCard = ({</div></div>+ <div className="flex min-h-16 flex-col items-start gap-3 px-4 py-3 sm:flex-row sm:items-center sm:justify-between sm:gap-4">+ <div className="flex min-w-0 items-start gap-3">+ <Sparkles className="mt-0.5 h-4 w-4 shrink-0 text-emerald-700" />+ <div className="min-w-0">+ <div className="text-sm font-semibold text-slate-900">{t("settings.aiSelectionMenuTitle")}</div>+ <div className="mt-0.5 text-xs leading-4 text-slate-500">{t("settings.aiSelectionMenuDescription")}</div>+ </div>+ </div>+ <div className="flex w-full shrink-0 justify-start sm:w-44 sm:justify-end">+ <Switch+ checked={aiSelectionMenuEnabled}+ onCheckedChange={(enabled) => {+ writeAiSelectionMenuPreference(enabled);+ setAiSelectionMenuEnabled(enabled);+ }}+ aria-label={t("settings.aiSelectionMenuAria")}+ />+ </div>+ </div>+{/* Desktop only: mobile editors always open links on a plain tap. */}<div className="hidden min-h-16 flex-col items-start gap-3 px-4 py-3 sm:flex-row sm:items-center sm:justify-between sm:gap-4 lg:flex"><div className="flex min-w-0 items-start gap-3">diff --git a/apps/web/src/lib/ai-selection-menu-preference.test.mjs b/apps/web/src/lib/ai-selection-menu-preference.test.mjsnew file mode 100644index 00000000..89d89821--- /dev/null+++ b/apps/web/src/lib/ai-selection-menu-preference.test.mjs@@ -0,0 +1,71 @@+import { afterEach, describe, expect, test } from "bun:test";+import {+ AI_SELECTION_MENU_STORAGE_KEY,+ readAiSelectionMenuPreference,+ resolveStoredAiSelectionMenuPreference,+ writeAiSelectionMenuPreference,+} from "./ai-selection-menu-preference.ts";++const originalWindow = globalThis.window;++afterEach(() => {+ globalThis.window = originalWindow;+});++const installWindow = () => {+ const values = new Map();+ const events = [];+ globalThis.window = {+ localStorage: {+ getItem: (key) => values.get(key) ?? null,+ setItem: (key, value) => values.set(key, String(value)),+ },+ dispatchEvent: (event) => {+ events.push(event);+ return true;+ },+ };+ return { events, values };+};++describe("AI selection menu preference", () => {+ test("defaults to enabled unless explicitly disabled", () => {+ expect(resolveStoredAiSelectionMenuPreference(null)).toBe(true);+ expect(resolveStoredAiSelectionMenuPreference("unsupported")).toBe(true);+ expect(resolveStoredAiSelectionMenuPreference("true")).toBe(true);+ expect(resolveStoredAiSelectionMenuPreference("false")).toBe(false);+ });++ test("persists changes and notifies the current document", () => {+ const { events, values } = installWindow();+ expect(readAiSelectionMenuPreference()).toBe(true);++ writeAiSelectionMenuPreference(false);+ expect(values.get(AI_SELECTION_MENU_STORAGE_KEY)).toBe("false");+ expect(readAiSelectionMenuPreference()).toBe(false);+ expect(events.at(-1)?.detail).toBe(false);++ writeAiSelectionMenuPreference(true);+ expect(values.get(AI_SELECTION_MENU_STORAGE_KEY)).toBe("true");+ expect(readAiSelectionMenuPreference()).toBe(true);+ expect(events.at(-1)?.detail).toBe(true);+ });++ test("falls back to enabled when local storage is unavailable", () => {+ const events = [];+ globalThis.window = {+ localStorage: {+ getItem: () => { throw new Error("blocked"); },+ setItem: () => { throw new Error("blocked"); },+ },+ dispatchEvent: (event) => {+ events.push(event);+ return true;+ },+ };++ expect(readAiSelectionMenuPreference()).toBe(true);+ expect(() => writeAiSelectionMenuPreference(false)).not.toThrow();+ expect(events.at(-1)?.detail).toBe(false);+ });+});diff --git a/apps/web/src/lib/ai-selection-menu-preference.ts b/apps/web/src/lib/ai-selection-menu-preference.tsnew file mode 100644index 00000000..ad903e31--- /dev/null+++ b/apps/web/src/lib/ai-selection-menu-preference.ts@@ -0,0 +1,29 @@+export const AI_SELECTION_MENU_STORAGE_KEY = "edgeever.editor.aiSelectionMenuEnabled";++export const AI_SELECTION_MENU_CHANGED_EVENT = "edgeever:ai-selection-menu-changed";++export const resolveStoredAiSelectionMenuPreference = (stored: string | null): boolean =>+ stored !== "false";++export const readAiSelectionMenuPreference = (): boolean => {+ if (typeof window === "undefined") return true;+ try {+ return resolveStoredAiSelectionMenuPreference(+ window.localStorage?.getItem(AI_SELECTION_MENU_STORAGE_KEY) ?? null,+ );+ } catch {+ return true;+ }+};++export const writeAiSelectionMenuPreference = (enabled: boolean) => {+ if (typeof window === "undefined") return;+ try {+ window.localStorage?.setItem(AI_SELECTION_MENU_STORAGE_KEY, enabled ? "true" : "false");+ } catch {+ // Private mode / blocked storage — preference is session-only via the event.+ }+ window.dispatchEvent(+ new CustomEvent(AI_SELECTION_MENU_CHANGED_EVENT, { detail: enabled }),+ );+};diff --git a/packages/shared/src/i18n/en-US.ts b/packages/shared/src/i18n/en-US.tsindex 0da8cbd5..4e69c8fe 100644--- a/packages/shared/src/i18n/en-US.ts+++ b/packages/shared/src/i18n/en-US.ts@@ -184,6 +184,9 @@ export const enUS = {aiStreamingTitle: "Stream AI responses",aiStreamingDescription: "Show generated content progressively for faster feedback. Streaming processes many response chunks and can make long generations fail on Cloudflare Workers Free because of its strict CPU limit. Keep this off for better reliability.",aiStreamingAria: "Stream AI responses",+ aiSelectionMenuTitle: "Show AI assistant when text is selected",+ aiSelectionMenuDescription: "Show an AI assistant action when text is selected in the rich-text editor. Turn this off to use AI manually from the editor toolbar instead.",+ aiSelectionMenuAria: "Show the AI assistant action when text is selected",linkOpenModifierTitle: "Open links with Ctrl/⌘ + click while editing",linkOpenModifierDescription: "On by default: hold Ctrl/⌘ and click to open links, preventing accidental opens while editing. Turn off to use a single click. Desktop only.",linkOpenModifierAria: "Require Ctrl or ⌘ click to open links while editing",diff --git a/packages/shared/src/i18n/zh-CN.ts b/packages/shared/src/i18n/zh-CN.tsindex 8d528027..a4db5a7f 100644--- a/packages/shared/src/i18n/zh-CN.ts+++ b/packages/shared/src/i18n/zh-CN.ts@@ -184,6 +184,9 @@ export const zhCN = {aiStreamingTitle: "流式返回 AI 结果",aiStreamingDescription: "开启后可逐步看到生成内容,反馈更及时;但流式处理会解析大量响应分片,在 CPU 限制严格的 Cloudflare Workers 免费版上,长内容更容易生成失败。建议优先保持关闭以获得更好的稳定性。",aiStreamingAria: "是否流式返回 AI 结果",+ aiSelectionMenuTitle: "选中文字时显示 AI 助手",+ aiSelectionMenuDescription: "开启后,在富文本编辑器中选中文字会显示 AI 助手入口;关闭后仍可通过编辑器工具栏手动使用 AI。",+ aiSelectionMenuAria: "选中文字时是否显示 AI 助手入口",linkOpenModifierTitle: "编辑时用 Ctrl/⌘ + 点击打开链接",linkOpenModifierDescription: "默认开启:需按住 Ctrl/⌘ 再点击链接,避免编辑时误触;关闭后可单击打开(仅桌面)。",linkOpenModifierAria: "编辑时是否需要 Ctrl 或 ⌘ 再点击才能打开链接",