Skip to content

AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.

refactor: remove unused code and enforce no-unused-vars (#598)

Dariusz Korytoccc5ed3f2976
diff --git a/.oxlintrc.json b/.oxlintrc.json
index a2485dfd..b466cb6e 100644
--- a/.oxlintrc.json
+++ b/.oxlintrc.json
@@ -5,8 +5,7 @@
"correctness": "error"
},
"rules": {
- // Unused code is removed in a dedicated pass before this rule is enforced.
- "no-unused-vars": "off"
+ "no-unused-vars": ["error", { "argsIgnorePattern": "^_", "varsIgnorePattern": "^_", "caughtErrorsIgnorePattern": "^_", "ignoreRestSiblings": true }]
},
"overrides": [
{
diff --git a/apps/api/src/companion-discovery-runtime.ts b/apps/api/src/companion-discovery-runtime.ts
index 8d465e34..ea1014e2 100644
--- a/apps/api/src/companion-discovery-runtime.ts
+++ b/apps/api/src/companion-discovery-runtime.ts
@@ -1,6 +1,6 @@
import { ToolLoopAgent, Output, type LanguageModel } from "ai";
import { CompanionDiscoveryOutputSchema } from "@edgeever/shared";
-import { discoveryContext, type DiscoveryContextInput, type DiscoveryCandidate } from "./companion-discovery-context";
+import { discoveryContext, type DiscoveryContextInput } from "./companion-discovery-context";
export type { DiscoveryCandidate } from "./companion-discovery-context";
export async function generateCompanionDiscovery(args: DiscoveryContextInput & {
diff --git a/apps/api/src/companion-discovery.ts b/apps/api/src/companion-discovery.ts
index 2165adb5..f1dc2bd4 100644
--- a/apps/api/src/companion-discovery.ts
+++ b/apps/api/src/companion-discovery.ts
@@ -1,6 +1,6 @@
import { learnCompanionPreferences, refreshCompanionPreferences, applicableMemories } from "./companion-learning";
import { selectCompanionMemories } from "./companion-memory-context";
-import { CompanionDiscoveryOutputSchema, type CompanionDiscoveryItem, type CompanionDiscoveryOutput, type CompanionDiscoverySettings,
+import { CompanionDiscoveryOutputSchema, type CompanionDiscoveryItem, type CompanionDiscoverySettings,
type CompanionDiscoverySettingsInput, type MemoDetail } from "@edgeever/shared";
import type { DatabaseAdapter } from "./storage-contract";
import type { CompanionScope } from "./companion-service";
diff --git a/apps/api/src/companion-learning.test.mjs b/apps/api/src/companion-learning.test.mjs
index d38a8864..e5482d55 100644
--- a/apps/api/src/companion-learning.test.mjs
+++ b/apps/api/src/companion-learning.test.mjs
@@ -2,7 +2,7 @@ import { afterEach, expect, test } from "bun:test";
import { Database } from "bun:sqlite";
import { globSync, readFileSync } from "node:fs";
import { createSelfHostedStorageAdapter } from "./self-hosted-storage-adapter.ts";
-import { createMemoRecord, moveMemosToNotebook, updateMemoRecord } from "./memo-service.ts";
+import { createMemoRecord, moveMemosToNotebook } from "./memo-service.ts";
import { updateTagsForMemos } from "./tag-service.ts";
import { learnCompanionPreferences, applicableMemories } from "./companion-learning.ts";
import { listCompanionMemories, forgetCompanionMemory, saveCompanionMemory, companionRevision, importCompanionMemories } from "./companion-service.ts";
diff --git a/apps/api/src/companion-tool-actions.test.mjs b/apps/api/src/companion-tool-actions.test.mjs
index 8eb91c8a..f4db4651 100644
--- a/apps/api/src/companion-tool-actions.test.mjs
+++ b/apps/api/src/companion-tool-actions.test.mjs
@@ -120,7 +120,7 @@ describe("shared companion MCP adapter", () => {
});
const operations = [
- ["create_memo", n => ({ notebookId: "ideas", title: "New", contentMarkdown: "Exact new body" })],
+ ["create_memo", () => ({ notebookId: "ideas", title: "New", contentMarkdown: "Exact new body" })],
["update_memo", n => ({ memoId: n[0].id, title: "Changed", contentMarkdown: "Exact replacement" })],
["merge_memos", n => ({ memoIds: n.map(note => note.id), title: "Merged", notebookId: "target" })],
["move_memos", n => ({ memoIds: [n[0].id], notebookId: "target" })],
diff --git a/apps/api/src/demo-seed-data.test.mjs b/apps/api/src/demo-seed-data.test.mjs
index bc7720bc..b6f931f3 100644
--- a/apps/api/src/demo-seed-data.test.mjs
+++ b/apps/api/src/demo-seed-data.test.mjs
@@ -56,7 +56,7 @@ describe("demo seed catalog", () => {
expect(table?.fields.length).toBeGreaterThan(0);
expect(table?.records.length).toBeGreaterThan(0);
for (const record of table?.records ?? []) {
- for (const [fieldId, cellValue] of Object.entries(record.cells)) {
+ for (const cellValue of Object.values(record.cells)) {
if (Array.isArray(cellValue)) {
for (const item of cellValue) {
expect(item.resourceId).toBeDefined();
diff --git a/apps/api/src/index.ts b/apps/api/src/index.ts
index 5fc5de34..a6ad9da2 100644
--- a/apps/api/src/index.ts
+++ b/apps/api/src/index.ts
@@ -102,19 +102,12 @@ import {
deleteMemoRecord,
deleteMemosRecord,
emptyTrashMemosRecord,
- getCurrentWorkspaceIdentity,
getMemoDetail,
getMemoDetailRow,
- getMemosForBulkAction,
- importMemosRecord,
- listMemosForMcp,
mapMemoDetail,
mergeMemosRecord,
moveMemosRecord,
- moveMemosToNotebook,
restoreMemoRecord,
- restoreMemosRecord,
- searchMemoSummaries,
updateMemoRecord,
} from "./memo-service";
import { duplicateMemoRecord } from "./memo-duplicate-service";
diff --git a/apps/api/src/memo-service.ts b/apps/api/src/memo-service.ts
index 84b19e79..6c43a584 100644
--- a/apps/api/src/memo-service.ts
+++ b/apps/api/src/memo-service.ts
@@ -31,7 +31,6 @@ import { sha256 } from "./hash-utils";
import { getRequiredString } from "./mcp-json-rpc";
import {
escapeLike,
- listMemos,
mapMemoSummary,
toFtsQuery,
type MemoSummaryRow,
diff --git a/apps/api/src/notebook-service.ts b/apps/api/src/notebook-service.ts
index a0931b55..8c5e3db4 100644
--- a/apps/api/src/notebook-service.ts
+++ b/apps/api/src/notebook-service.ts
@@ -1,7 +1,7 @@
import type { Notebook, NotebookCreateInput } from "@edgeever/shared";
import type { AuditActor } from "./api-context";
import { AppError } from "./app-error";
-import { audit, auditStatement } from "./audit";
+import { auditStatement } from "./audit";
import { createId, isoNow, slugify } from "./entity-utils";
import type { DatabaseAdapter } from "./storage-contract";
import { isInboxNotebook, workspaceInboxId } from "./workspace-provisioning";
diff --git a/apps/api/src/scheduled-task-routes.test.mjs b/apps/api/src/scheduled-task-routes.test.mjs
index 5cad8336..c8c7ad77 100644
--- a/apps/api/src/scheduled-task-routes.test.mjs
+++ b/apps/api/src/scheduled-task-routes.test.mjs
@@ -177,7 +177,7 @@ describe("scheduled task routes", () => {
});
test("does not expose task management to API-token actors", async () => {
- const { app, environment } = createFixture();
+ const { environment } = createFixture();
const tokenApp = new Hono();
tokenApp.use("/api/v1/*", async (context, next) => {
context.set("auth", { ...auth, kind: "agent", actorType: "agent" });
diff --git a/apps/api/src/share-routes.test.mjs b/apps/api/src/share-routes.test.mjs
index f85a35bc..18d6d707 100644
--- a/apps/api/src/share-routes.test.mjs
+++ b/apps/api/src/share-routes.test.mjs
@@ -341,7 +341,7 @@ const memberAuth = {
role: "member",
};
-const createShareApp = (environment) => {
+const createShareApp = () => {
const app = new Hono();
app.use("/api/v1/*", async (c, next) => {
c.set("auth", memberAuth);
diff --git a/apps/desktop/src/main/diagnostic-log.test.mjs b/apps/desktop/src/main/diagnostic-log.test.mjs
index 2070dba5..66f751fd 100644
--- a/apps/desktop/src/main/diagnostic-log.test.mjs
+++ b/apps/desktop/src/main/diagnostic-log.test.mjs
@@ -1,4 +1,4 @@
-import { describe, expect, test } from "bun:test";
+import { expect, test } from "bun:test";
import { mkdtemp, readFile, stat, writeFile } from "node:fs/promises";
import { tmpdir } from "node:os";
import { join } from "node:path";
diff --git a/apps/extension/article-clip.test.mjs b/apps/extension/article-clip.test.mjs
index 4f8b7da9..71e023b0 100644
--- a/apps/extension/article-clip.test.mjs
+++ b/apps/extension/article-clip.test.mjs
@@ -16,7 +16,7 @@ const fixture=(name)=>createDocument(readFileSync(new URL(`./fixtures/platforms/
const read=(name,doc=fixture(name))=>name.startsWith("jike") ? readJike(doc,urls[name]) : name.startsWith("douban") ? readDouban(doc,platformTarget(urls[name]),urls[name]) : readArticle(doc,urls[name],"公众号");
test("article URLs normalize aliases and tracking, retaining only WeChat query identity/signature",()=>{
- for (const [name,url] of Object.entries(urls)) expect(platformTarget(url+"?from=share#comments")?.url).toBe(url);
+ for (const url of Object.values(urls)) expect(platformTarget(url+"?from=share#comments")?.url).toBe(url);
const long="https://mp.weixin.qq.com/s?__biz=MzA%3D%3D&mid=123&idx=1&sn=abc&scene=21&pass_ticket=unused";
expect(platformTarget(long)).toEqual({platform:"wechat",id:"MzA==/123/1",url:"https://mp.weixin.qq.com/s?__biz=MzA%3D%3D&mid=123&idx=1&sn=abc"});
expect(platformTarget(long.replace("&sn=abc", ""))?.platform).toBe("wechat");
diff --git a/apps/mobile/src/lib/mobile-theme.tsx b/apps/mobile/src/lib/mobile-theme.tsx
index 42febaaf..8347388a 100644
--- a/apps/mobile/src/lib/mobile-theme.tsx
+++ b/apps/mobile/src/lib/mobile-theme.tsx
@@ -2,7 +2,6 @@ import { createContext, useContext, useEffect, useMemo, useState, type ReactNode
import { useColorScheme } from "react-native";
import { readMobileThemePreference, writeMobileThemePreference, type MobileThemePreference } from "./preferences";
import {
- resolveMobileThemeStyles,
type MobileResolvedTheme,
} from "./mobile-theme-colors";
export { resolveMobileThemeColor, resolveMobileThemeStyles, type MobileResolvedTheme } from "./mobile-theme-colors";
diff --git a/apps/mobile/src/screens/WorkspaceEditors.tsx b/apps/mobile/src/screens/WorkspaceEditors.tsx
index d5f99081..2bdde5fb 100644
--- a/apps/mobile/src/screens/WorkspaceEditors.tsx
+++ b/apps/mobile/src/screens/WorkspaceEditors.tsx
@@ -1,7 +1,7 @@
import { useCallback, useEffect, useMemo, useRef, useState } from "react";
import { useMutation, useQueryClient, type UseMutationResult } from "@tanstack/react-query";
import { File as ExpoFile } from "expo-file-system";
-import { ActivityIndicator, Check, ChevronDown, ChevronLeft, RotateCcw } from "../components/icons";
+import { ActivityIndicator, ChevronDown, ChevronLeft, RotateCcw } from "../components/icons";
import { BackHandler, KeyboardAvoidingView, Platform, View } from "react-native";
import { SafeAreaView } from "react-native-safe-area-context";
import { Alert, Pressable, Text, TextInput } from "../components/LocalizedText";
@@ -29,7 +29,6 @@ import { createMobileDataScope, upsertLocalMemo } from "../lib/local-mirror";
import { recordEditorStartup } from "../lib/startup-performance";
import { prepareUploadAsset, type MobileImageUploadAsset } from "../lib/mobile-image-upload";
import { uploadMobileResource } from "../lib/mobile-resource-upload";
-import MobileWebClipCapture from "../components/MobileWebClipCapture";
import LocalTiptapEditor, { type LocalTiptapEditorRef } from "../components/LocalTiptapEditor";
import { SAFE_DOM_WEBVIEW_PROPS } from "../lib/mobile-dom";
import { safeDomCall } from "../lib/safe-dom-call";
@@ -52,9 +51,6 @@ import { createOptimisticMemo, type MobileMemoUpdatePayload } from "./workspace-
import { styles } from "./workspace-styles";
import { NotebookPickerModal, SmartTagButton, TagPickerModal } from "./WorkspacePickers";
import {
- deleteMobileResourceFromDoc,
- getMobileResourceUpdatePayload,
- renameMobileResourceInDoc,
type MobileResourceTarget,
} from "../lib/mobile-attachments";
import {
@@ -153,7 +149,6 @@ export const CreateMemoModal = ({
initialSharedImages = [],
notebooks,
onCreated,
- onDismiss,
onQueued,
syncQueueScope,
}: {
@@ -1269,18 +1264,3 @@ const createLocalImagePreviewDataUrl = async (asset: { mimeType?: string | null;
const mimeType = asset.mimeType || file.type || "application/octet-stream";
return `data:${mimeType};base64,${await file.base64()}`;
};
-
-const appendResourceMarkdown = (
- currentMarkdown: string,
- resource: {
- filename: string;
- kind: "image" | "attachment";
- url: string;
- }
-) => {
- const label = resource.filename.replace(/\]/g, "\\]");
- const markdown = resource.kind === "image" ? `![${label}](${resource.url})` : `附件:[${label}](${resource.url})`;
- const trimmed = currentMarkdown.trimEnd();
-
- return trimmed ? `${trimmed}\n\n${markdown}\n` : `${markdown}\n`;
-};
diff --git a/apps/mobile/src/screens/WorkspaceNotesView.tsx b/apps/mobile/src/screens/WorkspaceNotesView.tsx
index 65d8c979..23b2ceb6 100644
--- a/apps/mobile/src/screens/WorkspaceNotesView.tsx
+++ b/apps/mobile/src/screens/WorkspaceNotesView.tsx
@@ -1,7 +1,7 @@
import { memo, useRef, type ReactNode } from "react";
import type { MemoFilterMode, MemoSortMode } from "@edgeever/client";
import { DEFAULT_MEMO_TITLE, getMemoListTimestamp, getNotebookDescendantMemoCount, type MemoSummary, type Notebook } from "@edgeever/shared";
-import { MOBILE_UI_METRICS, toggleMobileMemoFilterMode } from "@edgeever/shared/mobile-ui";
+import { toggleMobileMemoFilterMode } from "@edgeever/shared/mobile-ui";
import { FlatList, Platform, RefreshControl, useWindowDimensions, View } from "react-native";
import { Gesture, GestureDetector, MouseButton, PointerType } from "react-native-gesture-handler";
import { ActivityIndicator, Check, ChevronDown, ChevronLeft, LayoutTemplate, MoreHorizontal, Plus, RotateCcw, Search, Sparkles, Tag, X } from "../components/icons";
@@ -87,7 +87,7 @@ export const NotesView = ({
selectedMemoIds: Set<string>;
}) => {
const { resolvedTheme } = useMobileTheme();
- const { preference: localePreference, translate } = useMobileLocale();
+ const { translate } = useMobileLocale();
const searchActive = searchText.trim().length > 0;
const filterActive = memoFilterMode !== "all" || Boolean(selectedTag);
// With sub-notebooks hidden, an empty parent must not look like its notes are gone.
@@ -235,7 +235,6 @@ const MemoList = ({
emptyActions,
emptyDescription,
emptyTitle,
- error,
isError,
initialSyncProgress,
isLoading,
@@ -272,7 +271,7 @@ const MemoList = ({
selectionMode?: boolean;
selectedMemoIds?: Set<string>;
}) => {
- const { preference: localePreference, translate } = useMobileLocale();
+ const { translate } = useMobileLocale();
const { width } = useWindowDimensions();
const columnCount = width >= 1000 ? 3 : width >= 600 ? 2 : 1;
const hasInitialSyncProgress = initialSyncProgress !== null;
diff --git a/apps/mobile/src/screens/WorkspaceScreen.tsx b/apps/mobile/src/screens/WorkspaceScreen.tsx
index 666312d9..917f8045 100644
--- a/apps/mobile/src/screens/WorkspaceScreen.tsx
+++ b/apps/mobile/src/screens/WorkspaceScreen.tsx
@@ -1,4 +1,4 @@
-import { memo, useCallback, useEffect, useMemo, useRef, useState, type ReactNode } from "react";
+import { useCallback, useEffect, useMemo, useRef, useState, type ReactNode } from "react";
import { useInfiniteQuery, useMutation, useQuery, useQueryClient, type InfiniteData, type QueryKey } from "@tanstack/react-query";
import * as Clipboard from "expo-clipboard";
import type { ListMemosResponse, MemoFilterMode, MemoSortMode } from "@edgeever/client";
@@ -20,7 +20,7 @@ import { SafeAreaView, useSafeAreaInsets } from "react-native-safe-area-context"
import { Alert, Pressable, Text } from "../components/LocalizedText";
import { ApiRequestError } from "@edgeever/client";
import { DEFAULT_MEMO_TITLE, getNotebookScopeIds, hasDiagramDocumentMarker, markdownToDoc, type MemoDetail, type MemoSummary, type Notebook } from "@edgeever/shared";
-import { MOBILE_UI_METRICS, toggleMobileMemoFilterMode } from "@edgeever/shared/mobile-ui";
+import { MOBILE_UI_METRICS } from "@edgeever/shared/mobile-ui";
import { clearMobileMemoDraft, readMobileMemoDraft, type MobileMemoDraft } from "../lib/mobile-drafts";
import {
readMobileImageCompressionEnabled,
@@ -29,7 +29,6 @@ import {
writeMobileImageCompressionEnabled,
saveMobileShowDescendantNotes,
writeMobileMemoListDensity,
- type MobileLocalePreference,
type MobileMemoListDensity,
} from "../lib/preferences";
import { localizeUntitledMemoTitle, localizeMissingNotebookName, toMobileSyncErrorSourceText, useMobileLocale } from "../lib/mobile-locale";
@@ -46,7 +45,6 @@ import {
markMobileMemoUpdateError,
queueMobileMemoUpdate,
shouldQueueMobileMemoSaveError,
- type MobileSyncQueueItem,
} from "../lib/sync-queue";
import { deleteMobileMemos } from "../lib/mobile-memo-delete";
import { removeMobileMemosFromListCache } from "../lib/mobile-memo-list-cache";
@@ -56,13 +54,10 @@ import {
listLocalMemos,
listLocalNotebooks,
upsertLocalNotebook,
- listLocalTags,
resolveLocalMemo,
syncMobileLocalMirror,
upsertLocalMemo,
- type MobileBootstrapProgress,
} from "../lib/local-mirror";
-import { AccountSecurityPanel } from "./AccountSecurityModal";
import { beginEditorStartup, markStartup } from "../lib/startup-performance";
import MobileWebClipCapture from "../components/MobileWebClipCapture";
import { MobileCreateChoiceModal, MobileTemplatePickerModal } from "../components/MobileTemplatePicker";
@@ -86,11 +81,7 @@ import { useMobileLocalMirrorSync } from "../hooks/useMobileLocalMirrorSync";
import { useMobileWorkspaceSelection } from "../hooks/useMobileWorkspaceSelection";
import {
flattenNotebooks,
- formatMemoPreviewDate,
- getResolvedMobileLocale,
- getTextSearchMatches,
isEnglishMobileLocale,
- parseTags,
} from "./workspace-utils";
import {
applyOptimisticMemoToCache,
@@ -1079,10 +1070,6 @@ export const WorkspaceScreen = ({
},
});
- const handleTogglePin = (memo: MemoDetail) => {
- updateMemoMutation.mutate({ memo, payload: { isPinned: !memo.isPinned } });
- };
-
const handleDeleteMemo = (memo: MemoDetail) => {
const permanent = memoView === "trash" || memo.isDeleted;
if (!permanent) {
diff --git a/apps/web/src/components/DiagramEditorPane.tsx b/apps/web/src/components/DiagramEditorPane.tsx
index 9deecb9c..739993e4 100644
--- a/apps/web/src/components/DiagramEditorPane.tsx
+++ b/apps/web/src/components/DiagramEditorPane.tsx
@@ -4,7 +4,7 @@ import { formatMindMapOutline, projectMindMapOutline, updateMindMapOutlineDraft,
import { MindMapOutlineEditor } from "@/components/MindMapOutlineEditor";
import { focusArchitectureRelations } from "@/lib/architecture-relations";
import { MemoTitleInput } from "@/components/MemoTitleInput";
-import { useCallback, useEffect, useLayoutEffect, useMemo, useRef, useState, type DragEvent as ReactDragEvent, type PointerEvent as ReactPointerEvent, type ReactNode } from "react";
+import { useCallback, useEffect, useLayoutEffect, useMemo, useRef, useState, type DragEvent as ReactDragEvent, type PointerEvent as ReactPointerEvent } from "react";
import { Dom, Export, Graph, History, Keyboard, Scroller, Selection, type Edge, type Node } from "@antv/x6";
import * as m from "motion/react-m";
import {
@@ -12,7 +12,6 @@ import {
AppWindow,
ArrowDownUp,
Binary,
- Blocks,
Bot,
Box,
Boxes,
@@ -1325,7 +1324,6 @@ const diagramEdgeLabel = (
},
};
}
- const flowchart = null;
return {
position: { distance: 0.5, offset: 0 },
attrs: {
@@ -2043,7 +2041,6 @@ export const DiagramEditorPane = ({
useEffect(() => {
if (!containerRef.current || !document) return;
const appearance = appearanceRef.current;
- const palette = resolveDiagramPalette(documentTheme, appearance);
let graph!: Graph;
graph = new Graph({
container: containerRef.current,
diff --git a/apps/web/src/components/DiagramToolbar.tsx b/apps/web/src/components/DiagramToolbar.tsx
index 1c813122..8a4392a4 100644
--- a/apps/web/src/components/DiagramToolbar.tsx
+++ b/apps/web/src/components/DiagramToolbar.tsx
@@ -265,7 +265,6 @@ const DiagramZoomPercentField = ({
};
export const DiagramToolbar = ({
- appearance,
canRedo,
canUndo,
hasSelection,
diff --git a/apps/web/src/components/EditorPane.tsx b/apps/web/src/components/EditorPane.tsx
index f02872a9..523f01ac 100644
--- a/apps/web/src/components/EditorPane.tsx
+++ b/apps/web/src/components/EditorPane.tsx
@@ -12,13 +12,11 @@ import {
History,
RotateCcw,
Trash2,
- Tags,
ReplaceAll,
Paperclip,
Pencil,
Sparkles,
Type,
- X,
Check,
CircleAlert,
LoaderCircle,
@@ -49,13 +47,10 @@ import {
nextTitleStatusClearance,
} from "@/components/MemoEditorChromeDensity";
import { MemoTitleInput } from "@/components/MemoTitleInput";
-import { Input } from "@/components/ui/input";
import {
- DropdownMenu,
DropdownMenuItem,
DropdownMenuSeparator,
} from "@/components/ui/dropdown-menu";
-import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from "@/components/ui/tooltip";
import { EditorToolbar } from "./EditorToolbar";
import { EditorOutline } from "./EditorOutline";
import { SelectionAiActions } from "./editor/SelectionAiActions";
@@ -69,7 +64,6 @@ import {
} from "./editor/editor-instance-identity";
import {
analyzeMarkdownModeContent,
- isMarkdownSourceUnchanged,
resolveMarkdownModeContent,
} from "./editor/editor-mode-content";
import { useEditorMarkdownMode } from "./editor/useEditorMarkdownMode";
@@ -307,7 +301,6 @@ import {
shouldInsertDroppedResourceFiles,
isCreatedMemoEditorFocused,
isEditorReady,
- MemoSaveRequestError,
releaseEditorMedia,
resetEditorDocument,
shouldRetryCreatedMemoFocus,
@@ -4143,7 +4136,7 @@ const RichEditorPane = ({
{onCreatePoster && !effectiveReadOnly && <DropdownMenuItem disabled={!memo || saveMutation.isPending} onSelect={() => {
const selection = editor?.state.selection;
const text = selection && !selection.empty ? editor?.state.doc.textBetween(selection.from, selection.to, "\n") ?? "" : editor?.getText() ?? memo?.contentText ?? "";
- void (async () => { if (!memo) return; if (hasUnsavedChangesRef.current) await saveMutation.mutateAsync(); await onCreatePoster(memoRef.current ?? memo, text); })().catch((error) => setSaveState("error"));
+ void (async () => { if (!memo) return; if (hasUnsavedChangesRef.current) await saveMutation.mutateAsync(); await onCreatePoster(memoRef.current ?? memo, text); })().catch(() => setSaveState("error"));
}}>{t("poster.createFromNote")}</DropdownMenuItem>}
{!isMobileViewport && !useMobilePlainTextEditor && !useMarkdownSourceEditor && (
<DropdownMenuItem
diff --git a/apps/web/src/components/InfographicGallery.tsx b/apps/web/src/components/InfographicGallery.tsx
index 8cd77d63..48a833cd 100644
--- a/apps/web/src/components/InfographicGallery.tsx
+++ b/apps/web/src/components/InfographicGallery.tsx
@@ -12,7 +12,6 @@ import {
Search,
X,
} from "lucide-react";
-import { Button } from "@/components/ui/button";
import { Input } from "@/components/ui/input";
import {
INFOGRAPHIC_SAMPLE_CATEGORIES,
diff --git a/apps/web/src/components/MemoListPane.tsx b/apps/web/src/components/MemoListPane.tsx
index fa3e9319..974248dc 100644
--- a/apps/web/src/components/MemoListPane.tsx
+++ b/apps/web/src/components/MemoListPane.tsx
@@ -27,7 +27,6 @@ import {
Trash2,
KeyRound,
CheckSquare,
- ArrowDownWideNarrow,
LayoutList,
List,
FileText as FileIcon,
@@ -37,11 +36,7 @@ import {
Folder,
Merge,
FilePlus2,
- Compass,
- Layers,
- Settings,
MoreVertical,
- CheckCircle2,
TagX,
Image as ImageIcon,
Share2,
@@ -84,7 +79,6 @@ import type {
NotebookMoveOption,
} from "@/lib/app-helpers";
import { contentEnterMotion, paneEnterMotion } from "@/lib/motion";
-import type { SyncQueueSummary } from "@/lib/sync-queue";
import { api } from "@/lib/api";
import { isLocalMemoId } from "@/lib/local-mirror";
import { copyTextToClipboard } from "@/lib/clipboard";
@@ -351,20 +345,6 @@ const MobileSelectionActionBar = ({
);
};
-const CheckCircleCheck = ({ className }: { className?: string }) => (
- <svg
- className={cn("h-4 w-4 fill-current", className)}
- viewBox="0 0 20 20"
- xmlns="http://www.w3.org/2000/svg"
- >
- <path
- fillRule="evenodd"
- d="M10 18a8 8 0 100-16 8 8 0 000 16zm3.707-9.293a1 1 0 00-1.414-1.414L9 10.586 7.707 9.293a1 1 0 00-1.414 1.414l2 2a1 1 0 001.414 0l4-4z"
- clipRule="evenodd"
- />
- </svg>
-);
-
export const MemoListPane = ({
notebooks,
notebook,
@@ -431,11 +411,8 @@ export const MemoListPane = ({
setMobileMoveOpen,
mobileMoreOpen,
setMobileMoreOpen,
- desktopFilterOpen,
setDesktopFilterOpen,
- desktopSortOpen,
setDesktopSortOpen,
- desktopActionsOpen,
setDesktopActionsOpen,
isLoading,
isRefreshing,
@@ -563,7 +540,6 @@ export const MemoListPane = ({
const listScrollRef = useRef<HTMLDivElement | null>(null);
const [listScrollElement, setListScrollElement] = useState<HTMLDivElement | null>(null);
const [isDesktopList, setIsDesktopList] = useState(isDesktopViewport);
- const moveTargetSelectRef = useRef<HTMLSelectElement | null>(null);
const previousSelectionModeRef = useRef(selectionMode);
const skipSelectedMemoAutoScrollRef = useRef(false);
const setListScrollNode = useCallback((node: HTMLDivElement | null) => {
@@ -627,8 +603,6 @@ export const MemoListPane = ({
? t("workspace.selection.updatingPin")
: selectionPinLabel;
const selectionToggleTitle = canToggleVisibleMemoSelection ? visibleSelectionToggleLabel : t("memoList.noSelectableInList");
- const moveTargetTitle =
- view === "trash" ? t("workspace.selection.trashCannotMove") : notebooks.length === 0 ? t("workspace.selection.noMovableNotebook") : isMoving ? t("workspace.selection.moving") : t("memoList.moveToNotebook");
const searchActive = Boolean(search.trim());
const hasListConstraint = searchActive || filterMode !== "all" || Boolean(selectedTag);
const activeFilterLabel = filterOptions.find((option) => option.value === filterMode)?.label ?? t("options.memoFilter.all");
@@ -955,7 +929,7 @@ export const MemoListPane = ({
setMemoContextMenu(null);
};
- const handleOpenSelectionKeyboardContextMenu = (memo: MemoSummary, target: HTMLElement) => {
+ const handleOpenSelectionKeyboardContextMenu = (memo: MemoSummary) => {
if (!isDesktopViewport()) {
return;
}
@@ -1016,26 +990,6 @@ export const MemoListPane = ({
writeMemoListDensityPreference(value);
};
- const handleMoveTargetSelectKeyDown = (event: ReactKeyboardEvent<HTMLButtonElement>) => {
- if (event.key === "Escape") {
- event.preventDefault();
- event.currentTarget.blur();
- listRootRef.current?.focus();
- return;
- }
-
- if (event.key !== "Enter") {
- return;
- }
-
- if (selectedMemoIds.size === 0 || !moveTargetNotebookId || isMoving || view === "trash") {
- return;
- }
-
- event.preventDefault();
- onMoveSelectedMemos(moveTargetNotebookId);
- };
-
const handleListKeyDown = (event: ReactKeyboardEvent<HTMLDivElement>) => {
if (!isDesktopViewport()) {
return;
@@ -1548,7 +1502,7 @@ export const MemoListPane = ({
onDelete={() => onDeleteMemo(memo.id)}
onOpenContextMenu={(event) => handleOpenMemoContextMenu(memo, event)}
onOpenSelectionContextMenu={(event) => handleOpenSelectionContextMenu(memo, event)}
- onOpenSelectionKeyboardContextMenu={(target) => handleOpenSelectionKeyboardContextMenu(memo, target)}
+ onOpenSelectionKeyboardContextMenu={() => handleOpenSelectionKeyboardContextMenu(memo)}
onOpenKeyboardContextMenu={(target) => handleOpenMemoKeyboardContextMenu(memo, target)}
onToggle={(event) => handleToggleMemo(memo.id, event)}
/>
diff --git a/apps/web/src/components/NotebookPane.tsx b/apps/web/src/components/NotebookPane.tsx
index 09951619..1a274c1a 100644
--- a/apps/web/src/components/NotebookPane.tsx
+++ b/apps/web/src/components/NotebookPane.tsx
@@ -21,8 +21,6 @@ import {
Tag,
Paperclip,
Trash2,
- KeyRound,
- LogOut,
CloudOff,
AlertTriangle,
RefreshCw,
@@ -35,7 +33,6 @@ import {
Workflow,
} from "lucide-react";
import { Button } from "@/components/ui/button";
-import { Switch } from "@/components/ui/switch";
import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from "@/components/ui/tooltip";
import {
DropdownMenu,
@@ -53,7 +50,7 @@ import { cn } from "@/lib/utils";
import { useShowDescendantNotesPreference } from "@/lib/descendant-notes-preference";
import { BETA_BADGE_CLASSNAME } from "@/lib/workspace-ui";
import type { Notebook, AuthUser, NoteCreateKind } from "@edgeever/shared";
-import type { NotebookNode, NotebookDropPosition, NotebookSortMode } from "@/lib/app-helpers";
+import type { NotebookDropPosition, NotebookSortMode } from "@/lib/app-helpers";
import type { SyncQueueSummary } from "@/lib/sync-queue";
import {
buildNotebookTree,
@@ -509,11 +506,6 @@ export const NotebookPane = ({
isSyncingQueuedChanges,
onSyncQueuedChanges,
onDiscardConflicts,
- imageCompressionEnabled,
- onImageCompressionChange,
- authRequired,
- onLogout,
- isLoggingOut,
demoMode = false,
onResetDemo,
isResettingDemo = false,
diff --git a/apps/web/src/components/PosterEditorPane.tsx b/apps/web/src/components/PosterEditorPane.tsx
index 72a0154e..f2db4256 100644
--- a/apps/web/src/components/PosterEditorPane.tsx
+++ b/apps/web/src/components/PosterEditorPane.tsx
@@ -39,7 +39,6 @@ import {
type PosterElement,
} from "@edgeever/shared";
import { Button } from "@/components/ui/button";
-import { Input } from "@/components/ui/input";
import {
Dialog,
DialogContent,
diff --git a/apps/web/src/components/PublicSharePage.tsx b/apps/web/src/components/PublicSharePage.tsx
index dc567e75..b265a050 100644
--- a/apps/web/src/components/PublicSharePage.tsx
+++ b/apps/web/src/components/PublicSharePage.tsx
@@ -220,7 +220,7 @@ export const PublicSharePasswordForm = ({
};
export const PublicSharePage = () => {
- const { t, i18n } = useTranslation();
+ const { t } = useTranslation();
const { token = "" } = useParams();
const shareQuery = useQuery({
queryKey: ["public-share", token],
diff --git a/apps/web/src/components/ThemeProvider.tsx b/apps/web/src/components/ThemeProvider.tsx
index b8524fe5..0c5aad0c 100644
--- a/apps/web/src/components/ThemeProvider.tsx
+++ b/apps/web/src/components/ThemeProvider.tsx
@@ -6,7 +6,6 @@ import {
DEFAULT_CUSTOM_LIGHT_COLORS,
normalizeThemeColors,
type CustomEditorTheme,
- type ThemeColors,
} from "@/lib/custom-editor-theme";
export {
diff --git a/apps/web/src/components/WorkspaceApp.tsx b/apps/web/src/components/WorkspaceApp.tsx
index a50da2c1..6bb295c8 100644
--- a/apps/web/src/components/WorkspaceApp.tsx
+++ b/apps/web/src/components/WorkspaceApp.tsx
@@ -9,17 +9,14 @@ import {
useRef,
useSyncExternalStore,
type CSSProperties,
- type ReactNode,
- type MouseEvent,
type KeyboardEvent as ReactKeyboardEvent,
type PointerEvent as ReactPointerEvent,
} from "react";
import { useInfiniteQuery, useQuery, useMutation, useQueryClient } from "@tanstack/react-query";
import type { PluginPanelOpenOptions } from "@edgeever/plugin-api";
-import { RefreshCw, X } from "lucide-react";
+import { RefreshCw } from "lucide-react";
import { useTranslation } from "react-i18next";
import * as m from "motion/react-m";
-import { Button } from "@/components/ui/button";
import { MemoListPane, MemoSelectionActionBar } from "./MemoListPane";
import { MobileBottomNav, MobileNotebookPicker } from "./WorkspaceMobileChrome";
import { QuickMemoSwitcher } from "./QuickMemoSwitcher";
@@ -58,7 +55,6 @@ import type {
AppNoticeDialogState,
MobileBottomNavItem,
NotebookDropPosition,
- NotebookMoveOption,
MemoFilterMode,
MemoSortMode,
MemoDocumentAction,
diff --git a/apps/web/src/components/dialogs/ConfirmDialogs.tsx b/apps/web/src/components/dialogs/ConfirmDialogs.tsx
index 84fa6187..58fd784c 100644
--- a/apps/web/src/components/dialogs/ConfirmDialogs.tsx
+++ b/apps/web/src/components/dialogs/ConfirmDialogs.tsx
@@ -1,5 +1,5 @@
import { useState, useEffect, useRef } from "react";
-import { AlertTriangle, ShieldCheck, X } from "lucide-react";
+import { AlertTriangle, ShieldCheck } from "lucide-react";
import { useTranslation } from "react-i18next";
import { Button } from "@/components/ui/button";
import { Dialog, DialogContent, DialogHeader, DialogTitle, DialogDescription, DialogFooter } from "@/components/ui/dialog";
@@ -22,7 +22,6 @@ export const AppConfirmDialog = ({
isWorking = false,
title,
tone = "danger",
- closeOnBrowserBack,
onCancel,
onConfirm,
}: {
diff --git a/apps/web/src/components/dialogs/ShareMemoDialog.tsx b/apps/web/src/components/dialogs/ShareMemoDialog.tsx
index 0efaaf73..e1fa87ea 100644
--- a/apps/web/src/components/dialogs/ShareMemoDialog.tsx
+++ b/apps/web/src/components/dialogs/ShareMemoDialog.tsx
@@ -112,13 +112,6 @@ export const ShareMemoDialog = ({
markCopied(target, await copyTextToClipboard(value));
};
- const copiedLabel = (target: "link" | "password" | "both", idleKey: string) =>
- copyState === "copied" && copyTarget === target
- ? "sharing.copied"
- : copyState === "error" && copyTarget === target
- ? "sharing.copyFailed"
- : idleKey;
-
return (
<Dialog open={open} onOpenChange={onOpenChange}>
<DialogContent
diff --git a/apps/web/src/components/settings/AiModelCard.tsx b/apps/web/src/components/settings/AiModelCard.tsx
index 5011dcc7..7778fc19 100644
--- a/apps/web/src/components/settings/AiModelCard.tsx
+++ b/apps/web/src/components/settings/AiModelCard.tsx
@@ -1,7 +1,7 @@
import { useState, type FormEvent, type ReactNode } from "react";
import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
import type { AiProvider } from "@edgeever/shared";
-import { ChevronDown, Loader2, Plus, Server, Sparkles, TriangleAlert } from "lucide-react";
+import { ChevronDown, Loader2, Plus, Sparkles, TriangleAlert } from "lucide-react";
import { useTranslation } from "react-i18next";
import { AiProviderCard } from "@/components/settings/AiProviderCard";
import {
diff --git a/apps/web/src/components/settings/PreferenceCard.tsx b/apps/web/src/components/settings/PreferenceCard.tsx
index f9b74eb1..a99b51ae 100644
--- a/apps/web/src/components/settings/PreferenceCard.tsx
+++ b/apps/web/src/components/settings/PreferenceCard.tsx
@@ -32,7 +32,7 @@ import {
import { Button } from "@/components/ui/button";
import { Dialog, DialogContent, DialogDescription, DialogFooter, DialogHeader, DialogTitle } from "@/components/ui/dialog";
import { Input } from "@/components/ui/input";
-import { SETTINGS_ITEM_DESCRIPTION_CLASSNAME, SETTINGS_ITEM_ICON_CLASSNAME, SETTINGS_ITEM_TITLE_CLASSNAME } from "./settings-ui";
+import { SETTINGS_ITEM_ICON_CLASSNAME, SETTINGS_ITEM_TITLE_CLASSNAME } from "./settings-ui";
import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from "@/components/ui/select";
import { Switch } from "@/components/ui/switch";
import { ToggleGroup, ToggleGroupItem } from "@/components/ui/toggle-group";
diff --git a/apps/web/src/hooks/useNoteProse.ts b/apps/web/src/hooks/useNoteProse.ts
index 2b7fc9cf..81549b05 100644
--- a/apps/web/src/hooks/useNoteProse.ts
+++ b/apps/web/src/hooks/useNoteProse.ts
@@ -4,7 +4,6 @@ import {
resolveNoteProse,
type AccountNoteProse,
type NoteProsePatch,
- type ResolvedNoteProse,
} from "@edgeever/shared";
import { api } from "@/lib/api";
import { readLocalNoteProseMigration } from "@/lib/note-prose-local";
diff --git a/apps/web/src/lib/app-helpers.ts b/apps/web/src/lib/app-helpers.ts
index 00a679f4..04bdf32b 100644
--- a/apps/web/src/lib/app-helpers.ts
+++ b/apps/web/src/lib/app-helpers.ts
@@ -1,10 +1,9 @@
-import type { MemoSummary, Notebook, TiptapDoc } from "@edgeever/shared";
+import type { MemoSummary, Notebook } from "@edgeever/shared";
import { DEFAULT_MEMO_TITLE } from "@edgeever/shared";
import { getMobileNotebookSearchVisibleIds } from "@edgeever/shared/mobile-ui";
import type { MemoFilterMode, MemoSortMode } from "@edgeever/client";
import { buildNotebookTree, type NotebookNode, type NotebookNodeComparator } from "./utils";
import * as React from "react";
-import type { ReactNode } from "react";
import type { TFunction } from "i18next";
export type Pane = "notebooks" | "memos" | "editor";
diff --git a/apps/web/src/lib/plugins/plugin-host.ts b/apps/web/src/lib/plugins/plugin-host.ts
index 0ccc5e5d..0a7a49ed 100644
--- a/apps/web/src/lib/plugins/plugin-host.ts
+++ b/apps/web/src/lib/plugins/plugin-host.ts
@@ -41,7 +41,6 @@ import {
serializeTableDocument, tableFallbackMarkdown, structuredApiError,
posterCapabilities, pluginPoster, pluginInfographic, applyPosterEdits, applyInfographicOperations, serializePosterDocument, serializeInfographicDocument,
} from "./structured-note-api";
-import { api } from "@/lib/api";
import type { EdgeEverRepository } from "@/lib/repository";
import { WebPluginSecretStore, type PluginSecretStorage } from "@/lib/plugins/plugin-secret-store";
import { WebPluginPackageStore, type CachedPluginPackage, type PluginPackageStorage } from "@/lib/plugins/plugin-package-store";
diff --git a/apps/web/src/lib/poster-canvas.ts b/apps/web/src/lib/poster-canvas.ts
index 8cd5e882..3bebeba1 100644
--- a/apps/web/src/lib/poster-canvas.ts
+++ b/apps/web/src/lib/poster-canvas.ts
@@ -9,7 +9,6 @@ import {
Gradient,
Path,
Shadow,
- Point,
util,
type FabricObject,
} from "fabric";
diff --git a/apps/web/src/lib/repository.ts b/apps/web/src/lib/repository.ts
index 930f01c2..0682ddaf 100644
--- a/apps/web/src/lib/repository.ts
+++ b/apps/web/src/lib/repository.ts
@@ -1,6 +1,6 @@
import { assertLocalMemoSnapshot } from "./local-memo-guard";
import { localizeDefaultMemoTemplate } from "@edgeever/shared/memo-template-seeds";
-import { markdownToDoc, type MemoDetail, type MemoRevision, type MemoSummary, type MemoTemplate, type Notebook, type Resource, type ResourceListItem, type ResourceStorageSummary, type TagSummary, type TiptapDoc } from "@edgeever/shared";
+import { markdownToDoc, type MemoDetail, type MemoRevision, type MemoTemplate, type Notebook, type Resource, type ResourceListItem, type ResourceStorageSummary, type TagSummary, type TiptapDoc } from "@edgeever/shared";
import { api } from "@/lib/api";
import {
getLocalMemo,
diff --git a/packages/shared/src/content.ts b/packages/shared/src/content.ts
index 7a33b8b6..d3e61fa7 100644
--- a/packages/shared/src/content.ts
+++ b/packages/shared/src/content.ts
@@ -3,18 +3,18 @@ import {
createEdgeEverDocumentExtensions,
type CreateEdgeEverDocumentExtensionsOptions,
} from "./document-extensions";
-import { MergeDivider, MERGE_DIVIDER_NODE_TYPE } from "./merge-divider";
-import { PdfAttachment, PDF_ATTACHMENT_NODE_TYPE, upgradeStandalonePdfLinks } from "./pdf-attachment";
-import { FileAttachment, FILE_ATTACHMENT_NODE_TYPE, upgradeStandaloneFileLinks } from "./file-attachment";
+import { MERGE_DIVIDER_NODE_TYPE } from "./merge-divider";
+import { PDF_ATTACHMENT_NODE_TYPE, upgradeStandalonePdfLinks } from "./pdf-attachment";
+import { FILE_ATTACHMENT_NODE_TYPE, upgradeStandaloneFileLinks } from "./file-attachment";
import {
BLOCK_MATH_NODE_TYPE,
createEdgeEverMarkdownMathematics,
INLINE_MATH_NODE_TYPE,
} from "./mathematics-markdown";
import { projectNativeUnknownContentForMarkdown } from "./mobile-content-compatibility";
-import { PluginEmbed, PLUGIN_EMBED_NODE_TYPE } from "./plugin-embed";
+import { PLUGIN_EMBED_NODE_TYPE } from "./plugin-embed";
import { NEW_IMAGE_WIDTH_PERCENT, parseImageWidth } from "./image-display";
-import { ImageGallery, IMAGE_GALLERY_NODE_TYPE, groupConsecutiveImagesIntoGalleries, normalizeImageGalleries } from "./image-gallery";
+import { IMAGE_GALLERY_NODE_TYPE, groupConsecutiveImagesIntoGalleries, normalizeImageGalleries } from "./image-gallery";
import { EMPTY_EXTERNAL_LINK_NODE_TYPE } from "./empty-external-link";
import { FRONT_MATTER_LANGUAGE, createFrontMatterNode, getFrontMatterSource, splitMarkdownFrontMatter } from "./front-matter";
diff --git a/packages/shared/src/diagram-layout.ts b/packages/shared/src/diagram-layout.ts
index 1a594199..4e96dc73 100644
--- a/packages/shared/src/diagram-layout.ts
+++ b/packages/shared/src/diagram-layout.ts
@@ -1,4 +1,4 @@
-import { compactFlowchartNodeSize, flowchartNodePresentation, visualTextUnits } from "./diagram-node-presentation";
+import { flowchartNodePresentation, visualTextUnits } from "./diagram-node-presentation";
export { compactFlowchartNodeSize, flowchartNodePresentation } from "./diagram-node-presentation";
import { DIAGRAM_READABLE_MIN_SCALE, FLOWCHART_LAYOUT_SPACING } from "./diagram-flowchart-style";
export {
diff --git a/packages/shared/src/mathematics.ts b/packages/shared/src/mathematics.ts
index f156b152..63431021 100644
--- a/packages/shared/src/mathematics.ts
+++ b/packages/shared/src/mathematics.ts
@@ -3,11 +3,9 @@ import { BlockMath, InlineMath } from "@tiptap/extension-mathematics";
import type { Node as ProseMirrorNode } from "@tiptap/pm/model";
import { TextSelection, type Transaction } from "@tiptap/pm/state";
import {
- BLOCK_MATH_NODE_TYPE,
edgeEverBlockMathMarkdownTokenizer,
edgeEverInlineMathMarkdownTokenizer,
findInlineMathSpans,
- INLINE_MATH_NODE_TYPE,
matchBlockMathText,
matchInlineMathSuffix,
} from "./mathematics-markdown";