Skip to content

AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.

fix(web): restrict WebDAV backup to desktop

tianma-ifde60c9b41b6a
diff --git a/apps/web/src/lib/runtime.test.mjs b/apps/web/src/lib/runtime.test.mjs
new file mode 100644
index 00000000..147a93fd
--- /dev/null
+++ b/apps/web/src/lib/runtime.test.mjs
@@ -0,0 +1,42 @@
+import { afterEach, describe, expect, test } from "bun:test";
+import { isNativeDesktopRuntime } from "./runtime.ts";
+
+const originalWindow = Object.getOwnPropertyDescriptor(globalThis, "window");
+
+afterEach(() => {
+ if (originalWindow) {
+ Object.defineProperty(globalThis, "window", originalWindow);
+ } else {
+ delete globalThis.window;
+ }
+});
+
+describe("native desktop runtime detection", () => {
+ test("detects the native desktop bridge", () => {
+ globalThis.window = {
+ edgeeverDesktop: { isAvailable: true },
+ };
+
+ expect(isNativeDesktopRuntime()).toBe(true);
+ });
+
+ test("does not expose desktop-only features in a browser", () => {
+ globalThis.window = {};
+
+ expect(isNativeDesktopRuntime()).toBe(false);
+ });
+
+ test("does not rely on an Electron user agent without the native bridge", () => {
+ globalThis.window = {
+ navigator: { userAgent: "Mozilla/5.0 Electron/39.0.0" },
+ };
+
+ expect(isNativeDesktopRuntime()).toBe(false);
+ });
+
+ test("returns false during server-side rendering", () => {
+ delete globalThis.window;
+
+ expect(isNativeDesktopRuntime()).toBe(false);
+ });
+});
diff --git a/apps/web/src/lib/runtime.ts b/apps/web/src/lib/runtime.ts
index bfc44a3e..cbcd1360 100644
--- a/apps/web/src/lib/runtime.ts
+++ b/apps/web/src/lib/runtime.ts
@@ -1,20 +1,2 @@
-export type NativeDesktopWindow = Window & {
- __EDGEEVER_NATIVE_DESKTOP__?: boolean;
- process?: {
- versions?: {
- electron?: string;
- };
- };
-};
-
-export const isNativeDesktopRuntime = () => {
- if (typeof window === "undefined") return false;
- const nativeWindow = window as NativeDesktopWindow;
- const electronProcess = nativeWindow.process?.versions?.electron;
- const electronUserAgent = /Electron\//i.test(window.navigator.userAgent);
- return Boolean(
- nativeWindow.__EDGEEVER_NATIVE_DESKTOP__ ||
- electronProcess ||
- electronUserAgent
- );
-};
+export const isNativeDesktopRuntime = () =>
+ Boolean(typeof window !== "undefined" && window.edgeeverDesktop?.isAvailable);
diff --git a/package.json b/package.json
index f73666d1..8cde716e 100644
--- a/package.json
+++ b/package.json
@@ -36,7 +36,7 @@
"verify:web-performance": "bun scripts/verify-web-performance.mjs",
"test:release-planning": "bun test scripts/plan-native-release.test.mjs scripts/check-native-release-assets.test.mjs",
"test:desktop:sidecar": "bun scripts/test-desktop-sidecar.mjs",
- "test:desktop": "bun test apps/desktop/src/main/account-scope.test.mjs apps/desktop/src/main/diagnostic-log.test.mjs apps/desktop/src/main/file-association.test.mjs apps/desktop/src/main/file-permissions.test.mjs apps/desktop/src/main/installation-location.test.mjs apps/desktop/src/main/resource-url.test.mjs apps/desktop/src/main/staged-resource.test.mjs apps/desktop/src/main/user-data-directory.test.mjs apps/desktop/src/main/window-open-policy.test.mjs apps/desktop/src/main/window-visibility.test.mjs apps/web/src/lib/api.test.mjs apps/web/src/lib/app-page-path.test.mjs apps/web/src/lib/desktop-resources.test.mjs apps/web/src/lib/desktop-sync.test.mjs apps/web/src/lib/local-mirror.test.mjs apps/web/src/lib/repository.test.mjs apps/web/src/lib/sync-queue.test.mjs && bun run test:desktop:sidecar",
+ "test:desktop": "bun test apps/desktop/src/main/account-scope.test.mjs apps/desktop/src/main/diagnostic-log.test.mjs apps/desktop/src/main/file-association.test.mjs apps/desktop/src/main/file-permissions.test.mjs apps/desktop/src/main/installation-location.test.mjs apps/desktop/src/main/resource-url.test.mjs apps/desktop/src/main/staged-resource.test.mjs apps/desktop/src/main/user-data-directory.test.mjs apps/desktop/src/main/window-open-policy.test.mjs apps/desktop/src/main/window-visibility.test.mjs apps/web/src/lib/api.test.mjs apps/web/src/lib/app-page-path.test.mjs apps/web/src/lib/desktop-resources.test.mjs apps/web/src/lib/desktop-sync.test.mjs apps/web/src/lib/local-mirror.test.mjs apps/web/src/lib/repository.test.mjs apps/web/src/lib/runtime.test.mjs apps/web/src/lib/sync-queue.test.mjs && bun run test:desktop:sidecar",
"verify:desktop-package": "bun scripts/verify-desktop-package.mjs",
"build:cloudflare": "bun run typecheck && bun run build",
"build:site": "bun --cwd apps/site build",