Skip to content

AI-native knowledge base & Evernote/Obsidian alternative with instant sync & native MCP. Free on Cloudflare or self-hosted via Docker.

feat(sharing): show the author's built-in font on public shares

tianma-iff1949e795f88
diff --git a/apps/api/src/share-routes.test.mjs b/apps/api/src/share-routes.test.mjs
index afd1e021..71bedfc2 100644
--- a/apps/api/src/share-routes.test.mjs
+++ b/apps/api/src/share-routes.test.mjs
@@ -99,11 +99,59 @@ describe("public memo shares", () => {
expect(response.status).toBe(200);
expect(await response.json()).toMatchObject({
- share: { memoShareTokens: { memo_target: targetToken } },
+ share: { memoShareTokens: { memo_target: targetToken }, bodyFont: null },
});
sqlite.close();
});
+ test("publishes the author's built-in note font and ignores anything else", async () => {
+ const { sqlite, environment } = createDatabaseEnvironment();
+ sqlite.query("INSERT INTO users (id, username, password_hash, note_body_font) VALUES (?, ?, ?, ?)")
+ .run("usr_author", "author", "hash", "wenkai");
+ sqlite.query("UPDATE memo_shares SET created_by = ? WHERE id = ?")
+ .run("usr_author", "share_source");
+ const app = new Hono();
+ registerPublicShareRoutes(app);
+
+ const published = await app.request(`/api/public/shares/${sourceToken}`, {}, environment);
+ expect(published.status).toBe(200);
+ expect((await published.json()).share.bodyFont).toBe("wenkai");
+
+ sqlite.query("UPDATE users SET note_body_font = ? WHERE id = ?").run("Comic Sans", "usr_author");
+ const ignored = await app.request(`/api/public/shares/${sourceToken}`, {}, environment);
+ expect((await ignored.json()).share.bodyFont).toBeNull();
+ sqlite.close();
+ });
+
+ test("saves a signed-in user's published note font", async () => {
+ const { sqlite, environment } = createDatabaseEnvironment();
+ sqlite.query("INSERT INTO users (id, username, password_hash) VALUES (?, ?, ?)")
+ .run("usr_author", "author", "hash");
+ const app = new Hono();
+ app.use("*", async (c, next) => {
+ c.set("auth", { kind: "user", actorType: "user", actorId: "usr_author", username: "author", displayName: null, scopes: [], workspaceId: "ws_member", role: "owner" });
+ await next();
+ });
+ registerMemoShareRoutes(app);
+
+ const response = await app.request("/api/v1/me/note-body-font", {
+ method: "PUT",
+ headers: { "content-type": "application/json" },
+ body: JSON.stringify({ bodyFont: "source-han-serif" }),
+ }, environment);
+ expect(response.status).toBe(200);
+ expect(sqlite.query("SELECT note_body_font FROM users WHERE id = ?").get("usr_author").note_body_font).toBe("source-han-serif");
+
+ const cleared = await app.request("/api/v1/me/note-body-font", {
+ method: "PUT",
+ headers: { "content-type": "application/json" },
+ body: JSON.stringify({ bodyFont: null }),
+ }, environment);
+ expect(cleared.status).toBe(200);
+ expect(sqlite.query("SELECT note_body_font FROM users WHERE id = ?").get("usr_author").note_body_font).toBeNull();
+ sqlite.close();
+ });
+
test("serves shared PDF byte ranges with public-share cache controls", async () => {
const { sqlite, environment } = createDatabaseEnvironment();
sqlite.query(
diff --git a/apps/api/src/share-routes.ts b/apps/api/src/share-routes.ts
index f7465c0d..de9edf6a 100644
--- a/apps/api/src/share-routes.ts
+++ b/apps/api/src/share-routes.ts
@@ -1,4 +1,4 @@
-import { collectMemoLinkIds, isPdfAttachment, MemoShareUpdateSchema, PublicShareUnlockSchema, resolveMemoContentDoc, resolvePlayableMediaMimeType, type MemoShare, type PublicMemoShare, type TiptapDoc } from "@edgeever/shared";
+import { collectMemoLinkIds, isPdfAttachment, MemoShareUpdateSchema, NoteBodyFontUpdateSchema, parsePublishedNoteBodyFont, PublicShareUnlockSchema, resolveMemoContentDoc, resolvePlayableMediaMimeType, type MemoShare, type PublicMemoShare, type TiptapDoc } from "@edgeever/shared";
import { zValidator } from "@hono/zod-validator";
import type { Hono } from "hono";
import { getCookie, setCookie } from "hono/cookie";
@@ -40,6 +40,7 @@ type PublicMemoShareRow = {
tags_json: string;
updated_at: string;
password_hash: string | null;
+ note_body_font: string | null;
};
type ShareGateRow = {
workspace_id: string;
@@ -134,10 +135,12 @@ export const registerPublicShareRoutes = (app: Hono<AppEnv>) => {
if (!token) return notFound(c, "Shared note not found");
const row = await c.env.storage.db.prepare(
- `SELECT ms.workspace_id, m.title, mc.content_json, mc.content_markdown, m.tags_json, m.updated_at, ms.password_hash
+ `SELECT ms.workspace_id, m.title, mc.content_json, mc.content_markdown, m.tags_json, m.updated_at, ms.password_hash,
+ u.note_body_font
FROM memo_shares ms
INNER JOIN memos m ON m.id = ms.memo_id AND m.workspace_id = ms.workspace_id
INNER JOIN memo_contents mc ON mc.memo_id = m.id
+ LEFT JOIN users u ON u.id = ms.created_by
WHERE ms.token = ? AND m.is_deleted = 0
LIMIT 1`
).bind(token).first<PublicMemoShareRow>();
@@ -170,6 +173,7 @@ export const registerPublicShareRoutes = (app: Hono<AppEnv>) => {
tags: parseJsonArray(row.tags_json),
updatedAt: row.updated_at,
memoShareTokens,
+ bodyFont: parsePublishedNoteBodyFont(row.note_body_font),
};
c.header("Cache-Control", "private, no-store");
c.header("X-Robots-Tag", "noindex, nofollow, noarchive");
@@ -273,6 +277,18 @@ export const registerPublicShareRoutes = (app: Hono<AppEnv>) => {
};
export const registerMemoShareRoutes = (app: Hono<AppEnv>) => {
+ app.put("/api/v1/me/note-body-font", zValidator("json", NoteBodyFontUpdateSchema), async (c) => {
+ const denied = requireUser(c);
+ if (denied) return denied;
+ const actorId = c.get("auth").actorId;
+ if (!actorId) return apiError(c, "note_body_font_unavailable", "This session cannot publish a note font", 403);
+ const bodyFont = c.req.valid("json").bodyFont;
+ await c.env.storage.db.prepare(
+ `UPDATE users SET note_body_font = ?, updated_at = ? WHERE id = ?`
+ ).bind(bodyFont, isoNow(), actorId).run();
+ return c.json({ bodyFont });
+ });
+
app.get("/api/v1/memos/:id/share", async (c) => {
const denied = requireUser(c);
if (denied) return denied;
diff --git a/apps/web/src/app/App.tsx b/apps/web/src/app/App.tsx
index af8eee24..73c3d26f 100644
--- a/apps/web/src/app/App.tsx
+++ b/apps/web/src/app/App.tsx
@@ -18,6 +18,7 @@ import {
import { classifyLoginError, getLoginProblemMessageKey } from "@/lib/login-error";
import { EVERNOTE_MIGRATION_PATH } from "@/lib/routes";
import { isBrowserOffline } from "@/lib/network-status";
+import { syncPublishedNoteBodyFont } from "@/lib/published-note-body-font";
import type { AuthSession } from "@edgeever/shared";
const EvernoteImportGuidePane = lazy(() =>
@@ -83,6 +84,11 @@ const AuthenticatedWorkspace = () => {
const desktopAccountId = sessionQuery.data?.authenticated ? sessionQuery.data.user?.id ?? null : null;
+ useEffect(() => {
+ if (!desktopAccountId) return;
+ void syncPublishedNoteBodyFont();
+ }, [desktopAccountId]);
+
useEffect(() => {
if (!desktopBridge?.isAvailable || sessionQuery.isLoading) return;
let active = true;
diff --git a/apps/web/src/components/PublicSharePage.tsx b/apps/web/src/components/PublicSharePage.tsx
index 6fbea724..2fb198a2 100644
--- a/apps/web/src/components/PublicSharePage.tsx
+++ b/apps/web/src/components/PublicSharePage.tsx
@@ -17,8 +17,10 @@ import {
parseImageWidth,
getImageReferrerPolicy,
createEdgeEverDocumentExtensions,
+ parsePublishedNoteBodyFont,
type PublicMemoShare,
} from "@edgeever/shared";
+import { applyEditorBodyFontPreference } from "@/lib/editor-body-font";
import { createEdgeEverMathematics } from "@edgeever/shared/mathematics";
import { PdfAttachment } from "@/components/editor/PdfAttachment";
import { FileAttachment } from "@/components/editor/FileAttachment";
@@ -192,6 +194,20 @@ export const PublicSharePage = () => {
});
const share = shareQuery.data?.share;
const passwordRequired = isSharePasswordError(shareQuery.error, "share_password_required");
+ const publishedBodyFont = share ? parsePublishedNoteBodyFont(share.bodyFont) : undefined;
+
+ useEffect(() => {
+ if (publishedBodyFont === undefined) return undefined;
+ if (!publishedBodyFont) {
+ delete document.documentElement.dataset.editorBodyFont;
+ document.documentElement.style.removeProperty("--editor-body-font-family");
+ } else {
+ applyEditorBodyFontPreference({ choice: publishedBodyFont, customFamily: "" });
+ }
+ return () => {
+ applyEditorBodyFontPreference();
+ };
+ }, [publishedBodyFont]);
useEffect(() => {
const previousTitle = document.title;
diff --git a/apps/web/src/components/settings/PreferenceCard.tsx b/apps/web/src/components/settings/PreferenceCard.tsx
index 6d699636..a2333c7c 100644
--- a/apps/web/src/components/settings/PreferenceCard.tsx
+++ b/apps/web/src/components/settings/PreferenceCard.tsx
@@ -44,6 +44,7 @@ import {
writeEditorBodyFontPreference,
type EditorBodyFontChoice,
} from "@/lib/editor-body-font";
+import { syncPublishedNoteBodyFont } from "@/lib/published-note-body-font";
import { ShortcutSettingsItem } from "./ShortcutSettingsItem";
import { CustomEditorThemeDialog } from "./CustomEditorThemeDialog";
import {
@@ -207,6 +208,7 @@ export const PreferenceCard = ({
setEditorBodyFont(preference);
writeEditorBodyFontPreference(preference);
applyEditorBodyFontPreference(preference);
+ void syncPublishedNoteBodyFont();
};
return (
diff --git a/apps/web/src/lib/published-note-body-font.ts b/apps/web/src/lib/published-note-body-font.ts
new file mode 100644
index 00000000..ff8daff8
--- /dev/null
+++ b/apps/web/src/lib/published-note-body-font.ts
@@ -0,0 +1,17 @@
+import { api } from "@/lib/api";
+import { readEditorBodyFontPreference } from "@/lib/editor-body-font";
+
+let lastPublished: string | undefined;
+
+export const syncPublishedNoteBodyFont = async () => {
+ const preference = readEditorBodyFontPreference();
+ const bodyFont = preference.choice === "system" || preference.choice === "custom" ? null : preference.choice;
+ const marker = bodyFont ?? "";
+ if (lastPublished === marker) return;
+ lastPublished = marker;
+ try {
+ await api.updatePublishedNoteBodyFont(bodyFont);
+ } catch {
+ lastPublished = undefined;
+ }
+};
diff --git a/migrations/0054_user_note_body_font.sql b/migrations/0054_user_note_body_font.sql
new file mode 100644
index 00000000..6416d87c
--- /dev/null
+++ b/migrations/0054_user_note_body_font.sql
@@ -0,0 +1 @@
+ALTER TABLE users ADD COLUMN note_body_font TEXT;
diff --git a/packages/client/src/index.ts b/packages/client/src/index.ts
index def654ef..ccfd2989 100644
--- a/packages/client/src/index.ts
+++ b/packages/client/src/index.ts
@@ -803,6 +803,12 @@ export const createEdgeEverClient = (options: EdgeEverClientOptions = {}) => {
getPublicMemoShare: (token: string) =>
request<PublicMemoShareResponse>(`/api/public/shares/${encodeURIComponent(token)}`),
+ updatePublishedNoteBodyFont: (bodyFont: PublicMemoShare["bodyFont"]) =>
+ request<{ bodyFont: PublicMemoShare["bodyFont"] }>("/api/v1/me/note-body-font", {
+ method: "PUT",
+ body: JSON.stringify({ bodyFont }),
+ }),
+
unlockPublicMemoShare: (token: string, password: string) =>
request<{ ok: true }>(`/api/public/shares/${encodeURIComponent(token)}/unlock`, {
method: "POST",
diff --git a/packages/shared/src/schemas.ts b/packages/shared/src/schemas.ts
index 9207f89d..4be44d93 100644
--- a/packages/shared/src/schemas.ts
+++ b/packages/shared/src/schemas.ts
@@ -386,6 +386,10 @@ export const MemoShareUpdateSchema = z.object({
passwordProtected: z.boolean(),
});
+export const NoteBodyFontUpdateSchema = z.object({
+ bodyFont: z.enum(["wenkai", "wenkai-screen", "source-han-serif", "source-han-sans", "source-serif"]).nullable(),
+});
+
export const PublicShareUnlockSchema = z.object({
password: z.string().min(1).max(64),
});
diff --git a/packages/shared/src/sharing.ts b/packages/shared/src/sharing.ts
index 50bde288..34604369 100644
--- a/packages/shared/src/sharing.ts
+++ b/packages/shared/src/sharing.ts
@@ -11,6 +11,21 @@ export type MemoShare = {
password?: string;
};
+export const PUBLISHED_NOTE_BODY_FONTS = [
+ "wenkai",
+ "wenkai-screen",
+ "source-han-serif",
+ "source-han-sans",
+ "source-serif",
+] as const;
+
+export type PublishedNoteBodyFont = (typeof PUBLISHED_NOTE_BODY_FONTS)[number];
+
+export const parsePublishedNoteBodyFont = (value: unknown): PublishedNoteBodyFont | null =>
+ typeof value === "string" && (PUBLISHED_NOTE_BODY_FONTS as readonly string[]).includes(value)
+ ? value as PublishedNoteBodyFont
+ : null;
+
export type PublicMemoShare = {
title: string | null;
contentJson: TiptapDoc;
@@ -18,6 +33,8 @@ export type PublicMemoShare = {
tags: string[];
updatedAt: string;
memoShareTokens: Record<string, string>;
+ /** Built-in face chosen by the author. Null keeps the system font and downloads nothing. */
+ bodyFont: PublishedNoteBodyFont | null;
};
const RESOURCE_URL_PATTERN = /^\/api\/v1\/resources\/([^/?#]+)\/blob(?:[?#].*)?$/;
diff --git a/tests/note-sharing-menu.test.ts b/tests/note-sharing-menu.test.ts
index 61bd8e74..11762521 100644
--- a/tests/note-sharing-menu.test.ts
+++ b/tests/note-sharing-menu.test.ts
@@ -24,5 +24,7 @@ describe("note sharing menu", () => {
expect(shareDialogSource).toContain('t("sharing.passwordToggle")');
expect(shareDialogSource).toContain("api.updateMemoShare(memoId, { passwordProtected })");
expect(publicShareSource).toContain("api.unlockPublicMemoShare");
+ expect(publicShareSource).toContain("parsePublishedNoteBodyFont(share.bodyFont)");
+ expect(publicShareSource).toContain("applyEditorBodyFontPreference({ choice: publishedBodyFont, customFamily: \"\" })");
});
});