Skip to content

The VS Code of video editing, built for agents.

TypeScript

Refactor timeline component to improve scroll handling and update element references

konstantin-paulusc1a28375b144
diff --git a/apps/web/src/components/engine/timeline/timeline.ts b/apps/web/src/components/engine/timeline/timeline.ts
index 90a708fd..eb3c8a1c 100644
--- a/apps/web/src/components/engine/timeline/timeline.ts
+++ b/apps/web/src/components/engine/timeline/timeline.ts
@@ -137,7 +137,7 @@ export function createTimeline() {
const layers = layersEl;
const scrollY = c.Timeline.scrollY[sid] ?? 0;
- const newScrollY = Math.max(0, Math.min(scrollY, container.scrollHeight - container.clientHeight));
+ const newScrollY = Math.max(0, Math.min(scrollY, layers.scrollHeight - container.clientHeight));
c.Timeline.scrollY[sid] = newScrollY;
layers.style.transform = `translateY(${-newScrollY}px)`;
@@ -273,8 +273,8 @@ export function createTimeline() {
const layers = document.querySelector<HTMLElement>('[data-timeline-layers]');
assert(layers, 'Timeline layers element must be defined');
- const layersContainer = document.querySelector<HTMLElement>('[data-timeline-layers-container]');
- assert(layersContainer, 'Timeline layers container element must be defined');
+ const layersContainer = document.querySelector<HTMLElement>('[data-timeline-layers-viewport]');
+ assert(layersContainer, 'Timeline layers viewport element must be defined');
timeline.pointer = pointer;
layersEl = layers;
diff --git a/apps/web/src/components/timeline/layers/layers.tsx b/apps/web/src/components/timeline/layers/layers.tsx
index a6dbfb93..d5a36c51 100644
--- a/apps/web/src/components/timeline/layers/layers.tsx
+++ b/apps/web/src/components/timeline/layers/layers.tsx
@@ -260,16 +260,18 @@ export function Layers() {
{clock()}
</span>
</div>
- <div
- data-timeline-layers
- class="relative h-full z-0 group/layers flex flex-col pb-0.5"
- onPointerDown={handlePointerDown}
- >
- <LayerContextProvider>
- <Index each={layers()}>
- {(layer) => <Layer layer={layer()} />}
- </Index>
- </LayerContextProvider>
+ <div data-timeline-layers-viewport class="relative h-full z-0 overflow-hidden">
+ <div
+ data-timeline-layers
+ class="min-h-full group/layers flex flex-col pb-0.5"
+ onPointerDown={handlePointerDown}
+ >
+ <LayerContextProvider>
+ <Index each={layers()}>
+ {(layer) => <Layer layer={layer()} />}
+ </Index>
+ </LayerContextProvider>
+ </div>
</div>
</div>
</div>