The VS Code of video editing, built for agents.
TypeScript
feat: optimize canvas position handling by replacing ResizeObserver with computed effect
konstantin-paulusf3d3a08cc28a
diff --git a/apps/web/src/components/canvas/canvas.tsx b/apps/web/src/components/canvas/canvas.tsxindex ad62c035..fe2f004c 100644--- a/apps/web/src/components/canvas/canvas.tsx+++ b/apps/web/src/components/canvas/canvas.tsx@@ -2,7 +2,7 @@* License, v. 2.0. If a copy of the MPL was not distributed with this* file, You can obtain one at http://mozilla.org/MPL/2.0/. */-import { createEffect, on, onCleanup, onMount } from "solid-js";+import { createComputed, createEffect, on } from "solid-js";import { useWorld } from "@diffusionstudio/koota-solid";import { findSceneAt, screenToWorld, worldToLocal, Library, Root } from "@diffusionstudio/runtime";import { CameraController, EngineCanvas, nodesAt, panBy } from "@/engine";@@ -23,28 +23,19 @@ export function Canvas() {const { uiVisible } = useLayout();let container!: HTMLDivElement;- /**- * Where the canvas sits on screen, kept up as the panels around it change- * size (the left one animates between the sidebar's tabs).- */- let origin: DOMRect | null = null;- const observer = new ResizeObserver(() => (origin = container.getBoundingClientRect()));- onMount(() => observer.observe(container));- onCleanup(() => observer.disconnect());-/*** Showing or hiding the panels moves the canvas's corner across the* screen; the camera moves back by as much, so what is drawn stays where it- * was. The grid snaps rather than animates when the panels come and go, so- * the new place can be read straight away, ahead of the observer.+ * was. The computed runs before Solid applies the toggle to the DOM, so it+ * reads where the canvas was; the effect runs after, and reads where it is+ * now. The grid snaps rather than animates, so the new place is final.*/+ let before!: DOMRect;+ createComputed(on(uiVisible, () => (before = container.getBoundingClientRect()), { defer: true }));createEffect(on(uiVisible, () => {- const before = origin;- origin = container.getBoundingClientRect();- if (!before) return;-- const dx = origin.left - before.left;- const dy = origin.top - before.top;+ const after = container.getBoundingClientRect();+ const dx = after.left - before.left;+ const dy = after.top - before.top;if (dx || dy) panBy(world, dx, dy);}, { defer: true }));