Skip to content

EffectCraft: An open-source motion graphics and compositing tool written by scratch in pure Rust

Refactor animation presets reveal ID

Altynzhan Karybai102b20207d59
diff --git a/crates/ui-egui/src/menus/frontend.rs b/crates/ui-egui/src/menus/frontend.rs
index 2000cb31c..180c623b0 100644
--- a/crates/ui-egui/src/menus/frontend.rs
+++ b/crates/ui-egui/src/menus/frontend.rs
@@ -487,7 +487,7 @@ pub fn frontend(app: &mut EffectcraftApp, ctx: &egui::Context, id: &str, p: Valu
app.ui.effects_search.clear();
app.ui.effects_view.presets = true;
app.ui.effects_open.insert("presets".into());
- ctx.data_mut(|data| data.insert_temp(egui::Id::unique("fx-reveal-presets"), true));
+ ctx.data_mut(|data| data.insert_temp(egui::Id::unique(crate::panels::effects_presets::REVEAL_PRESETS_ID), true));
app.show_panel(PanelKind::EffectsPresets);
Value::Null
}
diff --git a/crates/ui-egui/src/panels/effects_presets.rs b/crates/ui-egui/src/panels/effects_presets.rs
index d7cb7de43..44c77ec22 100644
--- a/crates/ui-egui/src/panels/effects_presets.rs
+++ b/crates/ui-egui/src/panels/effects_presets.rs
@@ -17,6 +17,7 @@ use crate::{EffectcraftApp, widgets};
const ROW_H: f32 = 21.0;
const RECENT_MAX: usize = 8;
+pub(crate) const REVEAL_PRESETS_ID: &str = "fx-reveal-presets";
/// A user animation preset file.
#[derive(Clone, Debug, PartialEq)]
@@ -397,7 +398,7 @@ pub fn show(app: &mut EffectcraftApp, ui: &mut egui::Ui, rect: Rect) {
// Favorites and Recently Used.
let favs: Vec<_> = app.session.prefs.effects_favorites.iter().filter_map(|id| lookup(id)).filter(|e| keep(e)).collect();
let recent: Vec<_> = app.ui.effects_recent.iter().filter_map(|id| lookup(id)).filter(|e| keep(e)).collect();
- let reveal_presets = ctx.data_mut(|data| data.remove_temp::<bool>(egui::Id::unique("fx-reveal-presets"))).unwrap_or(false);
+ let reveal_presets = ctx.data_mut(|data| data.remove_temp::<bool>(egui::Id::unique(REVEAL_PRESETS_ID))).unwrap_or(false);
if reveal_presets {
// These rows come before Animation Presets. Scroll past expanded lists so the section is
// visible even when Favorites or Recently Used is long.