Skip to content

EffectCraft: An open-source motion graphics and compositing tool written by scratch in pure Rust

Merge remote-tracking branch 'origin/main' into jp/ja-dialogs

midasdf10e8a5e1c514
diff --cc ROADMAP.md
index e3dc2792c,f4c99d61f..40f3c5a5f
--- a/ROADMAP.md
+++ b/ROADMAP.md
@@@ -97,7 -97,7 +97,7 @@@ UI strings translated out of ≈ 4,200
| Korean | none | 0% |
| Vietnamese | none | 0% |
- Also shipped: Traditional Chinese (partial, 39%), Ukrainian (partial, 27%), Czech (partial, 27%) and Russian (menus only, 15%). No language has had
-Also shipped: Traditional Chinese (partial, 29%), Ukrainian (partial, 29%), Czech (partial, 29%), Georgian (partial, 38%; native-speaker reviewed) and Russian (menus only, 16%). No other language has had
++Also shipped: Traditional Chinese (partial, 39%), Ukrainian (partial, 27%), Czech (partial, 27%), Georgian (partial, 38%; native-speaker reviewed) and Russian (menus only, 15%). No other language has had
native-speaker review.
## Upcoming
diff --cc crates/ui-egui/src/i18n/ui.rs
index d8b982dbf,34e2dda86..6569dd147
--- a/crates/ui-egui/src/i18n/ui.rs
+++ b/crates/ui-egui/src/i18n/ui.rs
@@@ -5416,66 -5490,15 +6402,17 @@@ mod tests
("engine settings pages", include_str!("../../../engine/src/prefs.rs")),
("engine viewer channels", include_str!("../../../engine/src/viewer.rs")),
("engine viewer commands", include_str!("../../../engine/src/commands/viewer_cmds.rs")),
+ // The text animator menu's labels come from the engine as data, like the settings pages.
+ ("engine text animator kinds", include_str!("../../../project/src/build.rs")),
];
- /// Call shapes that hand a string literal straight to the user.
- const CALLS: &[&str] = &[
- ".label(\"",
- ".button(\"",
- ".small(\"",
- ".strong(\"",
- ".heading(\"",
- ".monospace(\"",
- ".on_hover_text(\"",
- ".on_disabled_hover_text(\"",
- ".hint_text(\"",
- ".text(\"",
- ".prefix(\"",
- ".suffix(\"",
- "RichText::new(\"",
- "Label::new(\"",
- "Button::new(\"",
- "Window::new(\"",
- "CollapsingHeader::new(\"",
- ];
-
- /// Literals that stay as they are: a unit or a separator reads the same in every language.
- const UNITS: &[&str] = &[" px", "%", "·", "s", "ms", "°", "fps", " bpc", " mm", " s", " %", " pixels"];
-
fn catalogs() -> Vec<(&'static str, &'static str)> {
- JAPANESE
- .iter()
- .copied()
- .chain(SIMPLIFIED_CHINESE.iter().copied())
- .chain(TRADITIONAL_CHINESE.iter().copied())
- .chain(UKRAINIAN.iter().copied())
- .chain(PORTUGUESE.iter().copied())
- .chain(CZECH.iter().copied())
- .chain(SPANISH.iter().copied())
- .collect()
+ ROWS.iter().flat_map(|(_, rows)| rows.iter().copied()).collect()
}
- #[test]
- fn czech_panels_translate_and_keep_project_content_and_argument_order() {
- set_current("cs");
- assert_eq!(tr("Composition Name:"), "Název kompozice:");
- assert_eq!(tr("Cancel"), "Zrušit");
- assert_eq!(tr("Guide Layer"), "Pomocná vrstva", "the layer context menus' item, as Layer ▸ Guide Layer");
- assert_eq!(tr("my layer.mp4"), "my layer.mp4");
- assert_eq!(tr_args("Proxy Use: {}", &[&"Best"]), "Použití zástupných souborů: Best");
- assert_eq!(tr_args("Step {} of {}: {}", &[&1, &3, &"Colour"]), "Krok 1 z 3: Colour");
- assert_eq!(tr_args("Template: {}\n{}", &[&"Title", &"My description"]), "Šablona: Title\nMy description");
- assert_eq!(tr_args("Leave all attributes in \"{}\"", &[&"File Čeština"]), "Ponechat všechny atributy v „File Čeština“");
- assert_eq!(
- tr_args("{} — double-click to open, {}-click to reveal", &[&"File.ecproj", &"Alt"]),
- "File.ecproj — dvojklikem otevřete, kliknutím s Alt zobrazíte umístění"
- );
- assert_eq!(tr_args("Proxy Use: {}", &[]), "Použití zástupných souborů: ");
- set_current("en");
- assert_eq!(tr("Composition Name:"), "Composition Name:");
+ /// `en`'s row in `rows`, else `en`: what `tr` should return without pinning one wording.
+ fn row(rows: &[(&'static str, &'static str)], en: &'static str) -> &'static str {
+ rows.iter().find(|(source, _)| *source == en).map_or(en, |(_, translated)| *translated)
}
/// A row that translates nothing, repeats a source string, or changes the number of values the
@@@ -5560,41 -5551,19 +6465,43 @@@
#[test]
fn tr_args_fills_values_in_order() {
set_current("zh-hans");
- assert_eq!(tr_args("Proxy Use: {}", &[&"Best"]), "代理使用:Best");
- assert_eq!(tr_args("Step {} of {}: {}", &[&1, &3, &"Colour"]), "第 1 步,共 3 步:Colour");
- assert_eq!(tr_args("Proxy Use: {}", &[]), "代理使用:");
+ let template = row(SIMPLIFIED_CHINESE, "Proxy Use: {}");
+ assert_eq!(tr_args("Proxy Use: {}", &[&"Best"]), template.replacen("{}", "Best", 1));
+ assert_eq!(tr_args("Proxy Use: {}", &[]), template.replacen("{}", "", 1));
set_current("en");
+ assert_eq!(tr_args("Step {} of {}: {}", &[&1, &3, &"Colour"]), "Step 1 of 3: Colour");
assert_eq!(tr_args("Proxy Use: {}", &[&"Best"]), "Proxy Use: Best");
+ assert_eq!(tr_args("Proxy Use: {}", &[]), "Proxy Use: ");
}
+ /// Japanese reads its own rows: values fill the placeholders in order, and a name that is not a
+ /// row (a layer or file name) stays verbatim.
+ #[test]
+ fn japanese_rows_translate_the_panels() {
+ set_current("ja");
+ assert_eq!(tr("Composition Name:"), "コンポジション名:");
+ // The panel/dialog second step: panel tabs, form labels, context menus and messages.
+ assert_eq!(tr("Effect Controls"), "エフェクトコントロール");
+ assert_eq!(tr("Media Duration"), "メディアの長さ");
+ assert_eq!(tr("Bring Layer to Front"), "レイヤーを最前面へ");
+ assert_eq!(tr("All Transform Properties"), "すべてのトランスフォームプロパティ");
+ assert_eq!(tr("Fill Color: RGB"), "塗りの色: RGB");
+ assert_eq!(tr("Lines added"), "追加行数");
+ // The composition-settings tabs and the Preview transport pass these through `tr` as
+ // variables, so a missing row would fall back to English unnoticed.
+ assert_eq!(tr("Basic"), "基本");
+ assert_eq!(tr("Advanced"), "詳細");
+ assert_eq!(tr("Play/Stop"), "再生/停止");
+ assert_eq!(tr("my layer.mp4"), "my layer.mp4");
+ assert_eq!(tr_args("Proxy Use: {}", &[&"Best"]), "プロキシの使用:Best");
+ assert_eq!(tr_args("Step {} of {}: {}", &[&1, &3, &"Colour"]), "ステップ1/3:Colour");
+ set_current("en");
+ }
+
- /// Every row is asked for by a converted panel: a leftover row means the panel went back to its
- /// English literal. A string a helper draws for the panel (a toolbar tooltip, a popup item, a
- /// checkbox label) is looked up inside that helper, so its English source only appears as a
- /// literal there - `helper_labels_are_translated` keeps those helpers honest.
+ /// Every row is asked for by a converted panel: a leftover row is stale, because the panel's
+ /// English source changed or went away. A string a helper draws for the panel (a toolbar
+ /// tooltip, a popup item, a checkbox label) is looked up inside that helper, so its English
+ /// source only appears as a literal there.
#[test]
fn every_row_is_used_by_a_converted_panel() {
for (en, _) in catalogs() {
diff --cc docs/gaps.md
index 7507a06d7,f8fcd64c2..5fca185e1
--- a/docs/gaps.md
+++ b/docs/gaps.md
@@@ -72,7 -72,7 +72,7 @@@ are grouped by area; the issue tracker
| 13 | **3D model formats and materials** | After Effects 26 imports FBX, USD/USDZ, STL besides glTF and OBJ (`usd_plugins`), and Substance 3D materials with mesh displacement (26.0–26.2); we read glTF, OBJ, STL (binary and ASCII, with facet colours) and FBX 7.x (binary and ASCII: meshes, hierarchy, Lambert/Phong materials and textures; no FBX animation or skinning yet) | Product shots and 3D scenes come as FBX/USDZ | 25–45 h | — · [file-format-parity.md](file-format-parity.md) |
| 14 | **Object Matte** (26.2, disk cache in 26.5) | First slice (#783): the Object Matte effect (Effect ▸ Matte) and `objectMatte.apply` turn a point (and optional box) on a reference frame into a matte and follow the object up to 600 frames each way, or segment every frame on its own; Roto Brush's engine, cache and model (MobileSAM from Settings ▸ Roto Brush, classical graph cut without it). Since then: the Object Matte tool in the viewer (click / drag a box, hover crosshair), the box as the model's box prompt, background tracking with progress and cancel, Freeze, and segmentations kept in the disk cache (26.5). Missing: a comparison with After Effects ([plan](fidelity/object-matte.md)) | The new one-click roto | 10–20 h | G7 · [target-app-parity.md](target-app-parity.md) |
| 15 | **Hardware video decode and encode** | No VideoToolbox, NVENC, Quick Sync or VA-API; #498 asks for it (answered: CUDA / NVENC need Nvidia's proprietary SDK through FFI, which the no-`unsafe` rule forbids); open PR #819 adds hardware decoding via `filmcraft-platform`; FilmCraft has VideoToolbox / NVENC / VA-API paths to borrow | 4K playback and export speed | 25–45 h | G5/G6 · [hardware-parity.md](hardware-parity.md) |
- | 16 | **Localization depth** | Menus in 10 languages (ja, zh-hans, zh-hant, uk, es, pt-br, ru, fr, de, cs: 628 rows each); panels in 6 (ja 996 rows, zh-hans and zh-hant 998 each, uk 524, pt-br 417, cs 518); effect names translated in Simplified Chinese (306, plus the generated Effect menu), their ~1,650 parameter names untranslated; Korean and Italian (After Effects ships them) absent; Hangul probe added (#599 closed) | After Effects is used heavily in Japan, China, Korea, Brazil, Europe | 60–110 h + native review | G9 · [localization-parity.md](localization-parity.md) |
-| 16 | **Localization depth** | Menus in 11 languages (ja, zh-hans, zh-hant, uk, es, pt-br, ru, fr, de, cs, ka: 628 rows each); panels in 7 (ja, zh-hans, zh-hant, uk, pt-br, cs, ka); effect names translated in Simplified Chinese and Georgian (307, plus the generated Effect menu), their ~1,650 parameter names untranslated; Korean and Italian (After Effects ships them) absent; Hangul probe added (#599 closed) | After Effects is used heavily in Japan, China, Korea, Brazil, Europe | 60–110 h + native review | G9 · [localization-parity.md](localization-parity.md) |
++| 16 | **Localization depth** | Menus in 11 languages (ja, zh-hans, zh-hant, uk, es, pt-br, ru, fr, de, cs, ka: 628 rows each); panels in 7 (ja 996 rows, zh-hans and zh-hant 998 each, uk 524, pt-br 417, cs 518, ka 886); effect names translated in Simplified Chinese (306) and Georgian (307, plus the generated Effect menu), their ~1,650 parameter names untranslated; Korean and Italian (After Effects ships them) absent; Hangul probe added (#599 closed) | After Effects is used heavily in Japan, China, Korea, Brazil, Europe | 60–110 h + native review | G9 · [localization-parity.md](localization-parity.md) |
| 17 | **Media Browser lists files import refuses** | `media_browser.rs` lists AVI; `media::is_importable` has none of them (Targa and Radiance HDR import since #745; DPX and Cineon since #756, log shown as stored: no Cineon Settings conversion yet; MXF OP1a / OP-Atom since #767; FilmCraft has no AVI demuxer); #431 and #324 closed | Confusing failures on common VFX formats | 15–30 h | G6 · [file-format-parity.md](file-format-parity.md) |
| 18 | **Relative paths and relinking** | Projects store absolute footage paths; no relink when a project moves | Moving or sharing a project breaks it | 6–12 h | G4 · [file-format-parity.md](file-format-parity.md) |
| 19 | **Plug-in ecosystem** | No After Effects SDK hosting (#600, #327 OpenFX, #334, #376 plug-in manager); our WebAssembly API has no third-party plug-ins | Many pro projects depend on Trapcode, Element, Saber… | 40–80 h for API growth; SDK hosting needs an owner decision | G8 · [scripting-parity.md](scripting-parity.md) |
diff --cc docs/localization-parity.md
index a03d72e1c,d642af43c..f6f29cdd3
--- a/docs/localization-parity.md
+++ b/docs/localization-parity.md
@@@ -1,6 -1,6 +1,6 @@@
# Localization parity
- > **Last reviewed:** 2026-10-22 · **Last updated:** 2026-10-22 · **Change:** minor (the panel/dialog catalogs grow by 303 rows in Japanese, Simplified Chinese and Traditional Chinese: panel tabs, form and dialog labels, context menus, tracker/graph/text-panel labels, credits and File-panel footers; Japanese 1,624 of ≈ 4,200 interface strings (39%), Simplified and Traditional Chinese 1,626 (Simplified Chinese 1,932 with its 306 effect names, 46%); previously: minor, catalogs recounted at `upstream/main` 470ea7a3: menus in 10 languages, panels in 6, Hangul probe (#599)) · **Target:** Adobe After Effects 2026
-> **Last reviewed:** 2026-10-14 · **Last updated:** 2026-10-23 · **Change:** minor (Georgian: menus, panels and effect names; missing strings show in English; `missing_translations_report` lists them) · **Target:** Adobe After Effects 2026
++> **Last reviewed:** 2026-10-14 · **Last updated:** 2026-10-23 · **Change:** minor (Georgian: menus, panels and effect names; missing strings show in English; `missing_translations_report` lists them; previously: minor, the panel/dialog catalogs grow by 303 rows in Japanese, Simplified Chinese and Traditional Chinese: panel tabs, form and dialog labels, context menus, tracker/graph/text-panel labels, credits and File-panel footers; Japanese 1,624 of ≈ 4,200 interface strings (39%), Simplified and Traditional Chinese 1,626 (Simplified Chinese 1,932 with its 306 effect names, 46%); previously: minor, catalogs recounted at `upstream/main` 470ea7a3: menus in 10 languages, panels in 6, Hangul probe (#599)) · **Target:** Adobe After Effects 2026
How much of EffectCraft's interface is translated, language by language, compared with After
Effects. [gaps.md](gaps.md) gap 16 and workstream G9 hold the work;
@@@ -17,16 -17,17 +17,18 @@@ interface; Arabic and Hebrew text *in l
## How EffectCraft translates
- **Menus:** `crates/ui-egui/src/i18n.rs`, one catalog per language keyed by
- `(command, English label)`. A test (`every_translation_key_exists_in_the_actual_menu_tree`)
- fails if any fixed menu entry is untranslated or a row is stale, so every catalog covers all
- fixed entries (628 catalog rows each at `ad8b6acb`, counted). The generated Effect menu is not part of that fixed tree: its entries
- `(command, English label)` (624 catalog rows each at 470ea7a3, counted). A test
- (`menu_catalogs_have_no_stale_or_duplicate_rows`) fails on a row whose entry left the menu tree
- or on a repeated row. The generated Effect menu is not part of that fixed tree: its entries
-- and category submenus take their labels from the effect catalog below.
++ `(command, English label)`. A test (`menu_catalogs_have_no_stale_or_duplicate_rows`) fails on a
++ row whose entry left the menu tree or on a repeated row, so every catalog covers all fixed
++ entries (628 catalog rows each at `ad8b6acb`, counted). The generated Effect menu is not part of
++ that fixed tree: its entries and category submenus take their labels from the effect catalog
++ below.
- **Panels, dialogs, buttons, tooltips:** `crates/ui-egui/src/i18n/ui.rs`, keyed by the English
- source string, with English fallback. Catalogs exist for Japanese (410 rows), Simplified and
- Traditional Chinese (506 each), Ukrainian (505), Brazilian Portuguese (400) and Czech (501);
- counted at 470ea7a3. Georgian has every row the Chinese catalogs have at this revision (695, as
- both Chinese catalogs now have), plus 191 for panels converted to the catalog.
+ source string, with English fallback. Catalogs exist for Japanese (996 rows), Simplified and
+ Traditional Chinese (998 each), Ukrainian (524), Brazilian Portuguese (417), Czech (518) and
- Spanish (513); counted at `ad8b6acb`.
++ Spanish (513); counted at `ad8b6acb`. Georgian has the 695 rows the Chinese catalogs held at
++ `470ea7a3`, plus 191 for panels converted to the catalog since (886 in all).
- **Effect names:** `crates/ui-egui/src/i18n/effects.rs`, keyed by **effect id**, in Simplified
- Chinese (306 rows, one per effect in the registry, plus its 21 categories). The registry's
+ Chinese and Georgian (307 rows, one per effect in the registry, plus its 21 categories). The registry's
English name stays the effect's identity: `effect.list`, `effect.apply {"effect": …}`, scripts
and expressions match on it, and the property tree stores it as the effect group's name. Only
the drawing — the Effect menu, Effect Controls, the Timeline and Effects & Presets — goes
@@@ -81,16 -87,17 +89,17 @@@ Other languages EffectCraft ships (4)
| Language | Code | UI strings translated | Status | To `full` |
|---|---|---|---|---|
-| Traditional Chinese | `zh-hant` | 1,130 (≈ 29%): menus 624 rows, panels 506 | partial | 6–9 h + review |
-| Ukrainian | `uk` | 1,129 (≈ 29%): menus 624 rows, panels 505 | partial | 6–9 h + review |
-| Czech | `cs` | 1,125 (≈ 29%): menus 624 rows, panels 501 | Existing catalog entries covered; unwrapped UI, effects and engine text still in English; AI-assisted, not yet native-speaker proofread | Remaining strings + independent native review |
-| Georgian | `ka` | 1,514 (≈ 39%): menus 628 rows, panels 886 (the Chinese catalogs' 695 plus 191 Georgian-only rows: form dialogs, context menus, column headers), effect names 307 + 21 categories; native-speaker reviewed | partial | 5–8 h |
+| Traditional Chinese | `zh-hant` | 1,626 (≈ 39%): menus 628 rows, panels 998 | partial | 6–9 h + review |
+| Ukrainian | `uk` | 1,152 (≈ 27%): menus 628 rows, panels 524 | partial | 6–9 h + review |
+| Czech | `cs` | 1,146 (≈ 27%): menus 628 rows, panels 518 | Existing catalog entries covered; unwrapped UI, effects and engine text still in English; AI-assisted, not yet native-speaker proofread | Remaining strings + independent native review |
++| Georgian | `ka` | 1,514 (≈ 39%): menus 628 rows, panels 886 (the Chinese catalogs' 695 at `470ea7a3` plus 191 Georgian-only rows: form dialogs, context menus, column headers), effect names 307 + 21 categories; native-speaker reviewed | partial | 5–8 h |
-Russian (`ru`) has a menu catalog (624 rows, ≈ 16%); After Effects also ships Italian, which EffectCraft does not (8–12 h).
+Russian (`ru`) has a menu catalog (628 rows, ≈ 15%); After Effects also ships Italian, which EffectCraft does not (8–12 h).
-**Overall: ≈ 18%**, the average coverage of After Effects' 10 non-English languages
-(Simplified and Traditional Chinese 29%, Japanese 27%, Brazilian Portuguese 26%, Spanish, French,
-German and Russian 16%, Korean and Italian 0%; 175 / 10, was ≈ 12% on 10 October). This is the localization row in
-[target-app-parity.md](target-app-parity.md#by-dimension).
+**Overall: ≈ 21%**, the average coverage of After Effects' 10 non-English languages
+(Simplified Chinese 46%, Traditional Chinese 39%, Japanese 39%, Brazilian Portuguese 25%,
+Spanish, French, German and Russian 15%, Korean and Italian 0%; 209 / 10, was ≈ 18% on 12 October).
+This is the localization row in [target-app-parity.md](target-app-parity.md#by-dimension).
**Effort.** One-time work first: route parameter names and engine messages through
a catalog, wrap the remaining panel literals, and add a Hangul probe (10–20 h). Then each language
@@@ -104,8 -111,8 +113,9 @@@ can give; only Georgian, contributed b
| Date | Change | Summary |
|---|---|---|
+| 2026-10-22 | minor | Panel/dialog second step: 300 more catalog rows in Japanese, Simplified Chinese and Traditional Chinese, plus the three rows the review found missing (Basic, Advanced and Play/Stop) — panel tabs, form and dialog labels, panel context menus, the tracker and graph controls, text-panel options, File-panel footers and credits; the panel tables are now 996 Japanese and 998 Chinese rows, all drawn through `tr`/`tr_args`, with the tests keeping the three catalogs listing the same sources; Simplified Chinese reaches 1,932 (46%) with its 306 effect names, and the overall share is 21% |
| 2026-10-12 | minor | Recounted: Russian, French, German and Czech menus (#873, #987), Brazilian Portuguese and Czech panels (#830, #987), Hangul probe (#599); overall ≈ 12% to ≈ 18%; Korean and Italian still absent |
+ | 2026-10-14 | minor | Georgian (`ka`): menus 628, panels 886 (191 Georgian-only, in `GEORGIAN_PANELS`), effect names and categories in `effects.rs` |
| 2026-10-10 | major | First localization parity document: catalog rows counted for all six languages, the twelve-language table, After Effects' 11 shipped languages from its bundle |
| 2026-10-11 | minor | Ukrainian panel catalog brought level with the Chinese ones (495 of 496 rows, counted at this commit); its share rises to ≈ 29%. The other languages' panel counts are the 10 October measurement |
| 2026-10-13 | minor | Effect names and the generated Effect menu leave English: `i18n/effects.rs` adds 306 rows keyed by effect id (Simplified Chinese, from After Effects 2026's interface and Adobe's Chinese documentation for the `CC` series) and the 21 category names. Parameter names are still English; no other language has rows |