EffectCraft: An open-source motion graphics and compositing tool written by scratch in pure Rust
fix(text): the tests and docs follow the layer being kept
zitann2020197d6cd229db
diff --git a/crates/engine/src/cmd/layer/create.rs b/crates/engine/src/cmd/layer/create.rsindex 7962c2485..ccc4810a9 100644--- a/crates/engine/src/cmd/layer/create.rs+++ b/crates/engine/src/cmd/layer/create.rs@@ -161,7 +161,7 @@ pub(super) fn text_range_p(p: &Value) -> Option<std::ops::Range<usize>> {/// It is left justified unless `justify` is given. The layer is named by `name`, else the first 40/// characters of the first text line, else "Text". `edit: true` also opens a new editing/// session with anchor `0` and the caret after the text, selecting all initial text so the next-/// insertion replaces it. The session has `created: true`, so leaving it empty removes the layer.+/// insertion replaces it. The session has `created: true`; leaving it empty keeps the layer, as After Effects does.pub(super) fn new_text(s: &mut Session, p: &Value) -> Result<Value> {let cid = comp_id(s, p)?;let comp = s.project.comp(cid).ok_or(EngineError::NoComp)?.clone();diff --git a/crates/engine/src/cmd/text_edit.rs b/crates/engine/src/cmd/text_edit.rsindex ce1f6d831..cdb650486 100644--- a/crates/engine/src/cmd/text_edit.rs+++ b/crates/engine/src/cmd/text_edit.rs@@ -71,7 +71,8 @@ pub struct TextEdit {/// Character panel changes made with only a caret: the style the next typed text takes.#[serde(default)]pub pending: Option<CharStyle>,- /// The layer was made by a Type tool click; leaving it empty deletes it.+ /// The layer was made by a Type tool click. Kept when left empty, as After Effects does, so this+ /// only records how the edit began.#[serde(default)]pub created: bool,/// Line position kept by repeated up / down moves (layout space).diff --git a/crates/engine/src/tests/text_edit.rs b/crates/engine/src/tests/text_edit.rsindex ddab0d173..c48cff7e3 100644--- a/crates/engine/src/tests/text_edit.rs+++ b/crates/engine/src/tests/text_edit.rs@@ -260,12 +260,12 @@ fn clipboard_and_paste_formatting() {}#[test]-fn type_tool_layers_point_box_and_empty_cleanup() {+fn type_tool_layers_point_box_and_empty_layer_is_kept() {let mut s = Session::default();s.execute("comp.new", json!({"name": "C", "width": 640, "height": 360, "duration": 4})).unwrap();let t = s.execute("layer.newText", json!({"text": "", "position": [100, 200], "justify": "left", "edit": true})).unwrap()["layer"].as_u64().unwrap();assert_eq!(s.state.text_edit.as_ref().map(|e| e.layer.0), Some(t));- // Leaving an untouched Type-tool layer deletes it.+ // Leaving an untouched Type-tool layer keeps it, as After Effects does.s.execute("text.endEdit", json!({})).unwrap();assert_eq!(s.active_comp().unwrap().layers.len(), 1, "an empty Type-tool layer is kept, as in AE");let b = s.execute("layer.newText", json!({"text": "", "box": [40, 50, 300, 120], "edit": true})).unwrap()["layer"].as_u64().unwrap();diff --git a/crates/ui-egui/tests/it/ui_text_edit.rs b/crates/ui-egui/tests/it/ui_text_edit.rsindex 84a218466..9f298ec19 100644--- a/crates/ui-egui/tests/it/ui_text_edit.rs+++ b/crates/ui-egui/tests/it/ui_text_edit.rs@@ -171,7 +171,7 @@ fn type_tool_click_type_edit_and_commit() {/// #831: clicking another panel (a solid's row in the Timeline) ends text editing and gives the/// keyboard back, whether the edit began with the Type tool (which stays selected) or by command:/// typed characters change no text and Space plays. The Character panel keeps the edit, and a-/// text layer clicked into being and left empty goes away.+/// text layer clicked into being and left empty stays, as it does in After Effects.#[test]fn clicking_another_panel_stops_typing_into_text() {for type_tool in [false, true] {@@ -194,7 +194,7 @@ fn clicking_another_panel_stops_typing_into_text() {assert_eq!(layers(&h), 3, "the Type tool started a text layer");let at_row = row(&h);click(&mut h, at_row, Modifiers::NONE);- assert_eq!(layers(&h), 2, "left empty, it is removed");+ assert_eq!(layers(&h), 3, "left empty, it stays, as in After Effects");click(&mut h, at, Modifiers::NONE);} else {h.state_mut().session.execute("text.edit", json!({"layer": title})).unwrap();diff --git a/docs/agents.md b/docs/agents.mdindex d2b691b18..60f2c9572 100644--- a/docs/agents.md+++ b/docs/agents.md@@ -540,7 +540,7 @@ indices): character attributes3. `layer.setText {"range":[6,11], "size":40, "fill":"#ff5500"}` styles the selection (theCharacter panel does the same); with an empty range it sets the style the next typed text takes.4. `edit.copy`, `edit.paste`, `edit.pasteTextMatchFormatting` and `edit.pasteTextFormattingOnly`- work on the selected text; `text.endEdit` commits (an empty Type-tool layer is removed).+ work on the selected text; `text.endEdit` commits (an empty Type-tool layer is kept, as After Effects does).Fonts: `text.fonts` (MCP `list_fonts`) lists every family a text layer can use, bundled and installed, with itsstyles, origin (`bundled`, `system`, `user`), `variable` (it has variation axes) and own-language name