Skip to content

EffectCraft: An open-source motion graphics and compositing tool written by scratch in pure Rust

security: move the release workflow's write permission to the job level (SonarCloud githubactions:S8233) (#2241)

Dylan M. Taylor357b4c5bd531
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 4b630f9fd..3cfbdc8b0 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -10,55 +10,14 @@ on:
type: string
default: ""
-permissions:
- contents: write
-
concurrency:
group: release-${{ github.ref }}
cancel-in-progress: false
jobs:
- git-sources:
- name: Git dependencies come from storytold
- runs-on: ubuntu-latest
- permissions:
- contents: read
- steps:
- - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- - name: Git dependencies come from storytold
- run: |
- set -euo pipefail
- test -f Cargo.lock || { echo "Cargo.lock is missing"; exit 1; }
- # Source replacement, patches and path overrides in cargo config never show up
- # in Cargo.lock. Parsed rather than grepped: TOML has many spellings of one key.
- # Cargo still reads the legacy .cargo/config.
- python3 - <<'PY'
- import os, sys, tomllib
- for path in (".cargo/config", ".cargo/config.toml"):
- if not os.path.exists(path):
- continue
- config = tomllib.load(open(path, "rb"))
- replaced = [name for name, source in config.get("source", {}).items()
- if isinstance(source, dict) and "replace-with" in source]
- if replaced or "patch" in config or "paths" in config:
- print(f"{path} replaces, patches or overrides a source")
- sys.exit(1)
- PY
- # Fails when Cargo.lock is out of date with the manifests.
- cargo metadata --locked --format-version 1 > /dev/null
- python3 - <<'PY'
- import sys, tomllib
- lock = tomllib.load(open("Cargo.lock", "rb"))
- bad = sorted({p["source"] for p in lock.get("package", [])
- if p.get("source", "").startswith("git+")
- and not p["source"].startswith("git+https://github.com/storytold/")})
- if bad:
- print("Git dependencies outside github.com/storytold:", *bad, sep="\n")
- sys.exit(1)
- PY
-
release:
- needs: git-sources
+ permissions:
+ contents: write
# Intentionally tracked at @main (not SHA-pinned) so org-wide CI improvements, security fixes, and build optimizations propagate without PR churn across all craftapp repos.
uses: storytold/craft-common-actions/.github/workflows/release.yml@main
with: