EffectCraft: An open-source motion graphics and compositing tool written by scratch in pure Rust
fix: JS reliability bugs (SonarCloud S1764, S9383, S4275)
Dylan M. Taylor798339669252
diff --git a/apps/effectcraft-web/web/sw.js b/apps/effectcraft-web/web/sw.jsindex 8c7efc2e5..c5605c81f 100644--- a/apps/effectcraft-web/web/sw.js+++ b/apps/effectcraft-web/web/sw.js@@ -38,7 +38,7 @@ self.addEventListener("fetch", (event) => {const hit = await cache.match(key, { ignoreSearch: req.mode === "navigate" });if (hit) return hit;const res = await fetch(req);- if (res.ok && res.type === "basic") cache.put(req, res.clone());+ if (res.ok && res.type === "basic") void cache.put(req, res.clone()).catch(() => {});return res;})(),);diff --git a/crates/expr/src/prelude.js b/crates/expr/src/prelude.jsindex 4da7bc63b..df6ed3ff4 100644--- a/crates/expr/src/prelude.js+++ b/crates/expr/src/prelude.js@@ -461,7 +461,7 @@ Comp.prototype = {var l = this.layer(i);if (l.__info[10] === 'Camera' && l.active) return l;}- __err('Composition "' + this.name + '" has no active camera');+ return __err('Composition "' + this.name + '" has no active camera');},layer: function (a, rel) {if (a !== null && typeof a === 'object' && a.__isLayer) return this.layer(a.index + (rel || 0));diff --git a/crates/script/src/scriptui.js b/crates/script/src/scriptui.jsindex af1e14b5e..52c65efb6 100644--- a/crates/script/src/scriptui.js+++ b/crates/script/src/scriptui.js@@ -840,7 +840,7 @@ function __uiJson(c, inherited) {o.value = Number(c.value) || 0;o.min = Number(c.minvalue) || 0;o.max = Number(c.maxvalue);- if (!(o.max === o.max)) o.max = 100;+ if (Number.isNaN(o.max)) o.max = 100;}if (c.items) {o.items = c.items.map(function (it) { return String(it.text); });