Skip to content

EffectCraft: An open-source motion graphics and compositing tool written by scratch in pure Rust

Fix animation Browse Presets command (#2172)

Altynzhan Karybaid5bbf730460a
diff --git a/crates/ui-egui/src/menus.rs b/crates/ui-egui/src/menus.rs
index 92893dcb6..c9e527ae3 100644
--- a/crates/ui-egui/src/menus.rs
+++ b/crates/ui-egui/src/menus.rs
@@ -1317,7 +1317,13 @@ pub fn frontend(app: &mut EffectcraftApp, ctx: &egui::Context, id: &str, p: Valu
app.ui.home_templates = true;
Value::Null
}
- "effect.manage" | "anim.browsePresets" => {
+ "effect.manage" => {
+ app.show_panel(PanelKind::EffectsPresets);
+ Value::Null
+ }
+ "anim.browsePresets" => {
+ app.ui.effects_view.presets = true;
+ app.ui.effects_open.insert("presets".into());
app.show_panel(PanelKind::EffectsPresets);
Value::Null
}
diff --git a/crates/ui-egui/tests/it/ui_menus.rs b/crates/ui-egui/tests/it/ui_menus.rs
index ca4c8cabc..b06dfaa22 100644
--- a/crates/ui-egui/tests/it/ui_menus.rs
+++ b/crates/ui-egui/tests/it/ui_menus.rs
@@ -46,6 +46,22 @@ fn shown(h: &Harness<'_, EffectcraftApp>, label: &str) -> bool {
h.query_by_label_contains(label).is_some()
}
+#[test]
+fn browse_presets_opens_the_animation_presets_list() {
+ use effectcraft_ui_egui::dock::PanelKind;
+
+ let mut app = EffectcraftApp::new(Session::default());
+ app.ui.effects_view.presets = false;
+ app.ui.effects_open.clear();
+
+ let result = effectcraft_ui_egui::menus::invoke(&mut app, &egui::Context::default(), "anim.browsePresets", json!({}));
+
+ assert!(result.is_ok());
+ assert_eq!(app.ui.focused, PanelKind::EffectsPresets);
+ assert!(app.ui.effects_view.presets);
+ assert!(app.ui.effects_open.contains("presets"));
+}
+
/// Space (or any shortcut) while a menu is open goes to the menu, not the app: it started the
/// preview behind the open menu.
#[test]