Skip to content

armgit / ente

Public Imported from GitHub
0

πŸ’š End-to-end encrypted cloud for everything.

[mob][photos] Remove redundant back-button comments

ashil-pilot09359935c8ca
diff --git a/mobile/packages/ente_components/lib/components/app_bar_component.dart b/mobile/packages/ente_components/lib/components/app_bar_component.dart
index c91df9ab8c..b9a72d9cde 100644
--- a/mobile/packages/ente_components/lib/components/app_bar_component.dart
+++ b/mobile/packages/ente_components/lib/components/app_bar_component.dart
@@ -808,7 +808,6 @@ class _HeaderAppBarBackButton extends StatelessWidget {
behavior: HitTestBehavior.opaque,
onTap: onBack ?? () => Navigator.maybePop(context),
child: Padding(
- // Preserve the icon position even with custom, compact headers.
padding: EdgeInsets.only(
left: horizontalPadding - left,
top: _centeredTop(chromeHeight, _defaultBackIconSize) - top,
diff --git a/mobile/packages/ente_components/test/components/app_surface_widgets_test.dart b/mobile/packages/ente_components/test/components/app_surface_widgets_test.dart
index 9661f09b97..34aca7cb15 100644
--- a/mobile/packages/ente_components/test/components/app_surface_widgets_test.dart
+++ b/mobile/packages/ente_components/test/components/app_surface_widgets_test.dart
@@ -282,8 +282,7 @@ void main() {
);
expect(tester.getTopLeft(title).dx, offset == 0 ? 16 : 52);
- // Tap near each corner outside the arrow. The expanded title starts
- // at y=48 and retains its own taps where it overlaps the target.
+ // The expanded title owns taps from y=48, so use y=47 for Back.
for (final point in [
const Offset(5, 5),
const Offset(51, 5),
@@ -297,7 +296,6 @@ void main() {
final previousBackTaps = backTaps;
final previousTitleTaps = titleTaps;
- // The area just outside each edge must no longer trigger back.
for (final point in const [
Offset(3, 28),
Offset(53, 5),
@@ -314,7 +312,6 @@ void main() {
}
expect(actionTaps, 2);
- // While collapsing, the title moves through the enlarged back target.
controller.jumpTo(20);
await tester.pump();
final previousBackTaps = backTaps;