Skip to content

armgit / ente

Public Imported from GitHub
0

πŸ’š End-to-end encrypted cloud for everything.

Limit Space link rotations to five per day

Neeraj Gupta0990f839a79e
diff --git a/server/space/controller/links.go b/server/space/controller/links.go
index 481adb02f3..ad855962a5 100644
--- a/server/space/controller/links.go
+++ b/server/space/controller/links.go
@@ -5,6 +5,7 @@ import (
"crypto/sha256"
"database/sql"
"errors"
+ "net/http"
"strings"
"github.com/ente/museum/ente"
@@ -150,6 +151,13 @@ func (c *LinksController) Rotate(ctx context.Context, space *repo.SpaceRecord, r
if errors.Is(err, repo.ErrSpaceLinkSecretReused) {
return nil, ente.NewBadRequestWithMessage("space link secret has already been used")
}
+ if errors.Is(err, repo.ErrSpaceLinkRotationLimitReached) {
+ return nil, &ente.ApiError{
+ Code: ente.ErrorCode("SPACE_LINK_ROTATION_LIMIT_REACHED"),
+ Message: "space link can only be rotated five times per day",
+ HttpStatusCode: http.StatusTooManyRequests,
+ }
+ }
return nil, err
}
return spaceLinkStatus(link), nil
diff --git a/server/space/repo/links.go b/server/space/repo/links.go
index 56c26d9d96..c19847304b 100644
--- a/server/space/repo/links.go
+++ b/server/space/repo/links.go
@@ -4,16 +4,20 @@ import (
"context"
"database/sql"
"errors"
+ "time"
"github.com/ente/stacktrace"
"github.com/lib/pq"
)
var (
- ErrSpaceLinkSecretReused = errors.New("space link secret reused")
- ErrSpaceLinkStateChanged = errors.New("space link state changed")
+ ErrSpaceLinkSecretReused = errors.New("space link secret reused")
+ ErrSpaceLinkStateChanged = errors.New("space link state changed")
+ ErrSpaceLinkRotationLimitReached = errors.New("space link rotation limit reached")
)
+const maxSpaceLinkRotationsPerDay = 5
+
func isSpaceLinkUniqueViolation(err error, constraint string) bool {
var pgErr *pq.Error
return errors.As(err, &pgErr) &&
@@ -188,6 +192,20 @@ func (r *LinksRepository) Rotate(
if currentVersion != keyVersion {
return nil, sql.ErrNoRows
}
+ // Link deactivation updates updated_at, recording when each rotation succeeded.
+ var recentRotations int
+ if err := tx.QueryRowContext(ctx, `
+ SELECT COUNT(*)
+ FROM space_links
+ WHERE space_id = $1
+ AND active = FALSE
+ AND updated_at >= now_utc_micro_seconds() - $2
+ `, spaceID, (24 * time.Hour).Microseconds()).Scan(&recentRotations); err != nil {
+ return nil, stacktrace.Propagate(err, "")
+ }
+ if recentRotations >= maxSpaceLinkRotationsPerDay {
+ return nil, ErrSpaceLinkRotationLimitReached
+ }
if _, err := tx.ExecContext(ctx, `
UPDATE space_links
SET active = FALSE