Skip to content

armgit / ente

Public Imported from GitHub
0

πŸ’š End-to-end encrypted cloud for everything.

Wait for progress dialog frame

Neeraj Gupta0f712cf9cb50
diff --git a/mobile/packages/ui/lib/components/progress_dialog.dart b/mobile/packages/ui/lib/components/progress_dialog.dart
index 026c057b55..13f83b7225 100644
--- a/mobile/packages/ui/lib/components/progress_dialog.dart
+++ b/mobile/packages/ui/lib/components/progress_dialog.dart
@@ -175,6 +175,7 @@ class ProgressDialog {
if (identical(_route, route)) _route = null;
}),
);
+ await WidgetsBinding.instance.endOfFrame;
if (_showLogs) debugPrint('ProgressDialog shown');
return true;
}
diff --git a/mobile/packages/ui/test/components/progress_dialog_test.dart b/mobile/packages/ui/test/components/progress_dialog_test.dart
index fc758b5702..68ca2bec2b 100644
--- a/mobile/packages/ui/test/components/progress_dialog_test.dart
+++ b/mobile/packages/ui/test/components/progress_dialog_test.dart
@@ -3,6 +3,24 @@ import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
void main() {
+ testWidgets('show waits for a frame before completing', (tester) async {
+ final context = await _pumpPage(tester);
+ final dialog = _dialog(context, 'Pending');
+ var completed = false;
+ final shown = dialog.show().whenComplete(() {
+ completed = true;
+ });
+
+ await tester.idle();
+ expect(completed, isFalse);
+ await tester.pump();
+ expect(await shown, isTrue);
+
+ final hidden = dialog.hide();
+ await tester.pumpAndSettle();
+ expect(await hidden, isTrue);
+ });
+
testWidgets('hide before the first frame removes the dialog', (tester) async {
final context = await _pumpPage(tester);
final dialog = _dialog(context, 'Pending');