Skip to content

armgit / ente

Public Imported from GitHub
0

πŸ’š End-to-end encrypted cloud for everything.

Expand automatic PR approval by author and path

Manav Rathi10d98ad38bd1
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index c5791c31da..fdbf93a2d5 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -1,5 +1,2 @@
/.github/ @ua741 @mnvr-sudo
/server/ @ua741 @mnvr-sudo
-/mobile/packages/ente_components/ @ashilkn @AmanRajSinghMourya
-/rust/crates/ml/ @laurenspriem @mnvr-sudo
-/rust/crates/image/ @laurenspriem @mnvr-sudo
diff --git a/.github/workflows/pr-approval.yml b/.github/workflows/pr-approval.yml
index 35521a532c..544c092640 100644
--- a/.github/workflows/pr-approval.yml
+++ b/.github/workflows/pr-approval.yml
@@ -16,10 +16,9 @@ jobs:
# Keep author IDs in sync with the rules below.
if: >-
github.repository == 'ente/ente' &&
- github.event.pull_request.user.id == 24503581 &&
+ contains(fromJSON('[24503581,231175576,239996999,64626875,293300083,2698932,281837475]'), github.event.pull_request.user.id) &&
github.event.sender.id == github.event.pull_request.user.id &&
github.triggering_actor == github.event.sender.login &&
- github.event.pull_request.head.repo.full_name == github.repository &&
github.event.pull_request.changed_files <= 100 &&
!github.event.pull_request.draft
runs-on: ubuntu-latest
@@ -41,9 +40,34 @@ jobs:
with:
github-token: ${{ steps.app_token.outputs.token }}
script: |
+ const excludePrefixes = [".github/", "server/"];
const rules = {
// mnvr
- 24503581: { excludePrefixes: [".github/"] },
+ 24503581: {},
+ // neeraj-pilot
+ 231175576: {},
+ // laurens-pilot
+ 239996999: { allowPrefixes: ["mobile/", "rust/"] },
+ // AswinAsok
+ 64626875: { allowPrefixes: ["web/", "desktop/"] },
+ // ashil-pilot
+ 293300083: { allowPrefixes: ["mobile/"] },
+ // anandbaburajan
+ 2698932: {
+ allowPrefixes: [
+ "web/",
+ "desktop/",
+ "rust/crates/space/",
+ "rust/bindings/wasm/space/",
+ ],
+ },
+ // aman-pilot
+ 281837475: {
+ allowPrefixes: [
+ "mobile/apps/locker/",
+ "mobile/packages/ente_components/",
+ ],
+ },
};
const { pull_request: pr } = context.payload;
const rule = rules[pr.user.id];
@@ -69,8 +93,12 @@ jobs:
previous_filename ? [filename, previous_filename] : [filename],
);
if (
- paths.some((path) =>
- rule.excludePrefixes.some((prefix) => path.startsWith(prefix)),
+ paths.some(
+ (path) =>
+ !path.includes("/") ||
+ excludePrefixes.some((prefix) => path.startsWith(prefix)) ||
+ (rule.allowPrefixes &&
+ !rule.allowPrefixes.some((prefix) => path.startsWith(prefix))),
)
) {
core.info("These paths require human approval.");