Skip to content

armgit / ente

Public Imported from GitHub
0

πŸ’š End-to-end encrypted cloud for everything.

[desktop] Shorten comment, credit changelog entry

aswinpradeepc1d536e179c57
diff --git a/desktop/changes/view-logs-linux.md b/desktop/changes/view-logs-linux.md
index 254625a87b..6ec9a32426 100644
--- a/desktop/changes/view-logs-linux.md
+++ b/desktop/changes/view-logs-linux.md
@@ -1 +1 @@
-- Fixed the "View logs" button hanging on Linux instead of dismissing once the file manager opened.
+- Fixed the "View logs" button hanging on Linux instead of dismissing once the file manager opened - @aswinpradeepc
diff --git a/desktop/src/main/services/dir.ts b/desktop/src/main/services/dir.ts
index f1aa9753fd..fa53581179 100644
--- a/desktop/src/main/services/dir.ts
+++ b/desktop/src/main/services/dir.ts
@@ -16,9 +16,7 @@ export const openDirectory = async (dirPath: string) => {
// shell.openPath requires native separators, not our POSIX IPC paths.
const nativePath = path.normalize(dirPath);
- // On Linux shell.openPath launches xdg-open without waiting for it, and
- // drops the callback that'd settle the promise it returned (see OpenPath in
- // Electron's platform_util_linux.cc). Awaiting it would hang this handler.
+ // On Linux shell.openPath's promise never settles, so don't await it.
if (process.platform == "linux") {
if (!existsSync(nativePath))
throw new Error(`Failed to open directory ${dirPath}`);