Skip to content

armgit / ente

Public Imported from GitHub
0

πŸ’š End-to-end encrypted cloud for everything.

[mob][photos] Remove caption quotes in file viewer

ashil-pilot4304fec68da7
diff --git a/mobile/apps/photos/changes/remove-file-viewer-caption-quotes.md b/mobile/apps/photos/changes/remove-file-viewer-caption-quotes.md
new file mode 100644
index 0000000000..1822c6d27c
--- /dev/null
+++ b/mobile/apps/photos/changes/remove-file-viewer-caption-quotes.md
@@ -0,0 +1 @@
+- Removed quotation marks around captions in the file viewer.
diff --git a/mobile/apps/photos/lib/ui/home/memories/full_screen_memory.dart b/mobile/apps/photos/lib/ui/home/memories/full_screen_memory.dart
index c7a9e03768..4431446be3 100644
--- a/mobile/apps/photos/lib/ui/home/memories/full_screen_memory.dart
+++ b/mobile/apps/photos/lib/ui/home/memories/full_screen_memory.dart
@@ -1355,9 +1355,6 @@ class _MemoryViewerScrimsAndCaption extends StatelessWidget {
final file = inheritedData.memories[safeIndex].file;
final caption = file.caption;
final captionText = caption == null || caption.isEmpty ? null : caption;
- final captionStyle = component.TextStyles.mini.copyWith(
- color: Colors.white.withValues(alpha: 0.8),
- );
return Stack(
fit: StackFit.expand,
children: [
@@ -1432,20 +1429,13 @@ class _MemoryViewerScrimsAndCaption extends StatelessWidget {
alignment: Alignment.centerLeft,
child: GestureDetector(
onTap: () => unawaited(showDetailsSheet(context, file)),
- child: Row(
- mainAxisSize: MainAxisSize.min,
- children: [
- Text('"', style: captionStyle),
- Flexible(
- child: Text(
- captionText,
- maxLines: 1,
- overflow: TextOverflow.ellipsis,
- style: captionStyle,
- ),
- ),
- Text('"', style: captionStyle),
- ],
+ child: Text(
+ captionText,
+ maxLines: 1,
+ overflow: TextOverflow.ellipsis,
+ style: component.TextStyles.mini.copyWith(
+ color: Colors.white.withValues(alpha: 0.8),
+ ),
),
),
),
diff --git a/mobile/apps/photos/lib/ui/viewer/file/detail_page.dart b/mobile/apps/photos/lib/ui/viewer/file/detail_page.dart
index fc966c6e38..c85940f2a0 100644
--- a/mobile/apps/photos/lib/ui/viewer/file/detail_page.dart
+++ b/mobile/apps/photos/lib/ui/viewer/file/detail_page.dart
@@ -983,9 +983,6 @@ class _GalleryFileViewerBottomOverlay extends StatelessWidget {
}
final safePadding = MediaQuery.paddingOf(context);
- final captionStyle = getEnteTextTheme(
- context,
- ).mini.copyWith(color: textBaseDark.withValues(alpha: 0.8));
final filmstripInset = hasFilmstrip
? filmstripLayout.additionalBottomInset
: 0.0;
@@ -1049,20 +1046,13 @@ class _GalleryFileViewerBottomOverlay extends StatelessWidget {
alignment: Alignment.centerLeft,
child: GestureDetector(
onTap: () => showDetailsSheet(context, file),
- child: Row(
- mainAxisSize: MainAxisSize.min,
- children: [
- Text('"', style: captionStyle),
- Flexible(
- child: Text(
- captionText,
- maxLines: 1,
- overflow: TextOverflow.ellipsis,
- style: captionStyle,
- ),
- ),
- Text('"', style: captionStyle),
- ],
+ child: Text(
+ captionText,
+ maxLines: 1,
+ overflow: TextOverflow.ellipsis,
+ style: getEnteTextTheme(context).mini.copyWith(
+ color: textBaseDark.withValues(alpha: 0.8),
+ ),
),
),
),