Skip to content

armgit / ente

Public Imported from GitHub
0

πŸ’š End-to-end encrypted cloud for everything.

[mob][photos] Show ML progress on the People widget setup page

r4khul4a97598eabe1
diff --git a/mobile/apps/photos/changes/ml-consent-screen.md b/mobile/apps/photos/changes/ml-consent-screen.md
index 62169c876d..a6231388d4 100644
--- a/mobile/apps/photos/changes/ml-consent-screen.md
+++ b/mobile/apps/photos/changes/ml-consent-screen.md
@@ -1 +1 @@
-- Refreshed the machine learning consent screen and added a consent sheet for the home banner and People widgets.
+- Refreshed the machine learning consent screen and added a consent sheet for the home banner and People widgets. The People widget setup page now shows machine learning progress.
diff --git a/mobile/apps/photos/lib/ui/settings/widgets/people_widget_settings.dart b/mobile/apps/photos/lib/ui/settings/widgets/people_widget_settings.dart
index 099f1de657..ddb73b9f19 100644
--- a/mobile/apps/photos/lib/ui/settings/widgets/people_widget_settings.dart
+++ b/mobile/apps/photos/lib/ui/settings/widgets/people_widget_settings.dart
@@ -10,6 +10,7 @@ import "package:photos/services/home_widget_service.dart";
import "package:photos/services/people_home_widget_service.dart";
import "package:photos/settings/local_settings.dart";
import "package:photos/theme/ente_theme.dart";
+import "package:photos/ui/components/banners/ml_progress_banner.dart";
import "package:photos/ui/viewer/search/result/people_section_all_page.dart";
class PeopleWidgetSettings extends StatefulWidget {
@@ -96,7 +97,7 @@ class _PeopleWidgetSettingsState extends State<PeopleWidgetSettings> {
? context.strings.peopleWidgetDesc
: context.strings.addPeopleWidgetPrompt,
slivers: <Widget>[
- if (!hasInstalledAny)
+ if (!hasInstalledAny) ...[
SliverToBoxAdapter(
child: Padding(
padding: const EdgeInsets.symmetric(horizontal: 32.0),
@@ -111,8 +112,20 @@ class _PeopleWidgetSettingsState extends State<PeopleWidgetSettings> {
],
),
),
- )
- else ...[
+ ),
+ const SliverToBoxAdapter(
+ child: Padding(
+ padding: EdgeInsets.fromLTRB(16, 24, 16, 0),
+ child: MLProgressBanner(),
+ ),
+ ),
+ ] else ...[
+ const SliverToBoxAdapter(
+ child: Padding(
+ padding: EdgeInsets.symmetric(horizontal: 16),
+ child: MLProgressBanner(),
+ ),
+ ),
if (kDebugMode)
SliverToBoxAdapter(
child: Padding(