Skip to content

armgit / ente

Public Imported from GitHub
0

πŸ’š End-to-end encrypted cloud for everything.

fix(EditAlbumDetailsDialog):fixed-legacy-title-with-spaces

Aswin Asok5b625a89f940
diff --git a/web/apps/photos/src/components/Collections/EditAlbumDetailsDialog.tsx b/web/apps/photos/src/components/Collections/EditAlbumDetailsDialog.tsx
index adc3192e09..3a4962a2d8 100644
--- a/web/apps/photos/src/components/Collections/EditAlbumDetailsDialog.tsx
+++ b/web/apps/photos/src/components/Collections/EditAlbumDetailsDialog.tsx
@@ -83,7 +83,7 @@ export const EditAlbumDetailsDialog: React.FC<EditAlbumDetailsDialogProps> = ({
const descriptionLength = albumDescriptionGraphemeCount(trimmedDescription);
const isDescriptionTooLong = descriptionLength > maxAlbumDescriptionLength;
const hasChanges =
- trimmedName != initialName ||
+ trimmedName != initialName.trim() ||
trimmedDescription != initialDescription.trim() ||
pendingCoverID !== undefined;
const isSaveDisabled =
@@ -119,18 +119,19 @@ export const EditAlbumDetailsDialog: React.FC<EditAlbumDetailsDialogProps> = ({
return Promise.resolve(true);
};
- const hasSelectableCover = files.some(
+ const canShowCoverEditor = files.some(
(file) => file.metadata.fileType !== FileType.video,
);
- const existingCoverID = collection.pubMagicMetadata?.data.coverID ?? 0;
- const canShowCoverEditor = hasSelectableCover || existingCoverID > 0;
- const effectiveCoverID = pendingCoverID ?? existingCoverID;
+ const effectiveCoverID =
+ pendingCoverID ?? collection.pubMagicMetadata?.data.coverID ?? 0;
const effectiveCoverFile =
pendingCoverID === undefined
? initialCoverFile
: pendingCoverID > 0
? files.find(({ id }) => id === pendingCoverID)
- : files[0];
+ : collection.pubMagicMetadata?.data.asc
+ ? files.at(-1)
+ : files[0];
return (
<>