Skip to content

armgit / ente

Public Imported from GitHub
0

πŸ’š End-to-end encrypted cloud for everything.

Preserve eyebrow title callbacks

Neeraj Gupta5fb2674da6bc
diff --git a/mobile/packages/ente_components/lib/components/app_bar_component.dart b/mobile/packages/ente_components/lib/components/app_bar_component.dart
index 840e42609f..175cd3c592 100644
--- a/mobile/packages/ente_components/lib/components/app_bar_component.dart
+++ b/mobile/packages/ente_components/lib/components/app_bar_component.dart
@@ -975,11 +975,20 @@ class _MovingHeaderTitle extends StatelessWidget {
final eyebrowText = eyebrow;
if (eyebrowText != null) {
+ final child = _buildEyebrowTitle(context, eyebrowText, textStyle);
return Positioned(
left: left,
right: right,
top: top,
- child: _buildEyebrowTitle(context, eyebrowText, textStyle),
+ child: onTap == null && onDoubleTap == null && onLongPress == null
+ ? child
+ : GestureDetector(
+ behavior: HitTestBehavior.opaque,
+ onTap: onTap,
+ onDoubleTap: onDoubleTap,
+ onLongPress: onLongPress,
+ child: child,
+ ),
);
}
diff --git a/mobile/packages/ente_components/test/components/app_surface_widgets_test.dart b/mobile/packages/ente_components/test/components/app_surface_widgets_test.dart
index a031e21be3..f4950a2b28 100644
--- a/mobile/packages/ente_components/test/components/app_surface_widgets_test.dart
+++ b/mobile/packages/ente_components/test/components/app_surface_widgets_test.dart
@@ -772,7 +772,7 @@ void main() {
expect(tester.takeException(), isNull);
});
- testWidgets('SliverAppBarComponent preserves tap-only title callbacks', (
+ testWidgets('SliverAppBarComponent preserves title callbacks with eyebrow', (
tester,
) async {
var tapped = false;
@@ -783,6 +783,7 @@ void main() {
slivers: [
SliverAppBarComponent(
title: 'Tap me',
+ eyebrow: 'Context',
onTitleTap: () => tapped = true,
actions: const [Icon(Icons.search)],
),