Skip to content

armgit / ente

Public Imported from GitHub
0

πŸ’š End-to-end encrypted cloud for everything.

[mobile][photos] Improve image editor color slider interaction

r4khul629a83d24d6c
diff --git a/mobile/apps/photos/lib/ui/tools/editor/image_editor/image_editor_color_picker.dart b/mobile/apps/photos/lib/ui/tools/editor/image_editor/image_editor_color_picker.dart
index f412dda810..0b62ba14ce 100644
--- a/mobile/apps/photos/lib/ui/tools/editor/image_editor/image_editor_color_picker.dart
+++ b/mobile/apps/photos/lib/ui/tools/editor/image_editor/image_editor_color_picker.dart
@@ -4,11 +4,15 @@ import "package:flutter/material.dart";
class ImageEditorColorPicker extends StatefulWidget {
final double value;
final ValueChanged<double> onChanged;
+ final ValueChanged<double>? onChangeStart;
+ final String? semanticLabel;
const ImageEditorColorPicker({
super.key,
required this.value,
required this.onChanged,
+ this.onChangeStart,
+ this.semanticLabel,
});
@override
@@ -51,8 +55,8 @@ class ColorSliderState extends State<ImageEditorColorPicker> {
Color(0xFFFF0080),
Color(0xFFFF0000),
],
- begin: Alignment.centerLeft,
- end: Alignment.centerRight,
+ begin: AlignmentDirectional.centerStart,
+ end: AlignmentDirectional.centerEnd,
),
border: Border.all(color: colors.fillLight, width: 6),
),
@@ -68,11 +72,15 @@ class ColorSliderState extends State<ImageEditorColorPicker> {
overlayShape: const RoundSliderOverlayShape(overlayRadius: 0),
trackShape: const _TransparentTrackShape(),
),
- child: Slider(
- value: widget.value,
- onChanged: widget.onChanged,
- min: 0.0,
- max: 1.0,
+ child: Semantics(
+ label: widget.semanticLabel,
+ child: Slider(
+ value: widget.value,
+ onChanged: widget.onChanged,
+ onChangeStart: widget.onChangeStart,
+ min: 0.0,
+ max: 1.0,
+ ),
),
),
),